#24 Add rubygem-net-telnet license tag.
Closed 2 years ago by vondruch. Opened 3 years ago by jaruga.

file modified
+5 -1
@@ -21,7 +21,7 @@

  %endif

  

  

- %global release 95

+ %global release 96

  %{!?release_string:%global release_string %{?development_release:0.}%{release}%{?development_release:.%{development_release}}%{?dist}}

  

  # The RubyGems library has to stay out of Ruby directory three, since the
@@ -462,6 +462,7 @@

  Summary:    Provides telnet client functionality

  Version:    %{net_telnet_version}

  Group:      Development/Libraries

+ License:    Ruby or BSD

  Requires:   ruby(release)

  Requires:   ruby(rubygems) >= %{rubygems_version}

  Provides:   rubygem(net-telnet) = %{version}-%{release}
@@ -1083,6 +1084,9 @@

  %{gem_dir}/specifications/xmlrpc-%{xmlrpc_version}.gemspec

  

  %changelog

+ * Fri Jul 27 2018 Jun Aruga <jaruga@redhat.com> - 2.5.1-96

+ - Add rubygem-net-telnet license tag.

+ 

  * Fri Jul 27 2018 Igor Gnatenko <ignatenkobrain@fedoraproject.org> - 2.5.1-95

  - Rebuild for new binutils

  

I just noticed that rubygem-net-telnet did not have LICENSE tag.
The license file is gems/net-telnet-0.1.1/LICENSE.txt
Upstream: https://github.com/ruby/net-telnet

There are more subpackages like this. Is it actually required? This is what guidelines says:

If a source package generates multiple binary packages, the License: field may differ between them if necessary. This implies that a single spec may have multiple per-subpackage License: tags. Each of those License: tags must comply with all applicable guidelines.

I'm against merging this, as the same license is specified in Ruby main package. There's no need to specify licenses for subpackages unless they differ from the main one, right?

Please close this ticket, as I am fine for that.

Pull-Request has been closed by vondruch

2 years ago