rpms / ruby

Clone
Source Code
GIT

#73 Add Recommends: redhat-rpm-config to devel subpackage
Merged 3 years ago by pvalena. Opened 3 years ago by pvalena.
rpms/ pvalena/ruby redhat-rpm-config  into  master

file modified
+8 -1 
@@ -22,7 +22,7 @@ 
 

  %endif
 

  

  

- %global release 136
 

+ %global release 137
 

  %{!?release_string:%define release_string %{?development_release:0.}%{release}%{?development_release:.%{development_release}}%{?dist}}
 

  

  # The RubyGems library has to stay out of Ruby directory tree, since the
 
@@ -219,6 +219,9 @@ 
 

  # This would not be needed if ~50 packages depending on -devel used
 

  # --disable-gems
 

  Requires:   rubygems
 

+ # Users need CFLAGS from /usr/lib/rpm/redhat/redhat-hardened-cc1
 

+ # for building gems with binary extensions (rhbz#1905222).
 

+ Recommends: redhat-rpm-config
 

  

  %description devel
 

  Header files and libraries for building an extension library for the
 
@@ -1286,6 +1289,10 @@ 
 

  

  

  %changelog
 

+ * Tue Dec 15 16:26:46 CET 2020 Pavel Valena <pvalena@redhat.com> - 2.7.2-137
 

+ - Add Recommends: redhat-rpm-config to devel subpackage.
 

+   Resolves: rhbz#1905222
 

+ 

  * Tue Nov 24 18:16:02 CET 2020 Vít Ondruch <vondruch@redhat.com> - 2.7.2-136
 

  - Add explicit `BR: make`.

as it's needed for building (gem install ...) gems with binary extensions.

This is a workaround to have /usr/lib/rpm/redhat/redhat-hardened-cc1
on the system, as same CFLAGS are reused from when Ruby was build.

Resolves: rhbz#1905222

Build failed.

Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=57541019

It has succeded for me, as well as the simple-koji-ci build.

@zuul there seems to be a koji: ConnectionError.

Fedora CI build succeded, but there're credentials issues though:
Could not update commit status, please check if your scan credentials belong to a member of the organization or a collaborator of the repository and repo:status scope is selected

@mvadkert anything to be done from our side?

I've created a COPR build as well. Tested the usage manually:
https://git.io/JLZiN

The recommends are there, but gcc fails to build eventmachine due to "unrecognized option '--gdwarf-4'". Is that something we should report? It's however not related to ruby version: https://git.io/JLZXe as the older ruby also suffers from this issue (I wonder why it's release 135, and not 136). It may be just something on my system, so please let me know if it's and issue for you.

@vondruch, @jaruga PTAL.
Edited 3 years ago by pvalena

Build failed.

LGTM

I just would like to emphasize the redhat-hardened-cc1 is optionally required runtime dependency in this comment. It is required for the gem with the extensions, but required for the gem without the extensions.

How about changing the "for" with "in case of the"?

# Users need CFLAGS from /usr/lib/rpm/redhat/redhat-hardened-cc1
# in case of the building gems with binary extensions (rhbz#1905222).

I just would like to emphasize the redhat-hardened-cc1 is optionally required runtime dependency in this comment. It is required for the gem with the extensions, but required for the gem without the extensions.

How about changing the "for" with "in case of the"?

```

Users need CFLAGS from /usr/lib/rpm/redhat/redhat-hardened-cc1

in case of the building gems with binary extensions (rhbz#1905222).

```

IMHO the wording has the exact intended meaning (need for ...). Also, AFAIK in case of cannot be used with -ing (cannot remember the rule now). Furthermore, in any variant, the proposed wording seems to me very "unnatural" (WRT English) for this case. I'm keeping the original one, sorry.

Thanks for review!

rebased onto 369a719872c24289ec4ae435ef7e67cad24d386b
3 years ago

rebased onto 2a35234
3 years ago

(Fixed two typos.)

Pull-Request has been merged by pvalena
3 years ago

Build failed.
Changes Summary 1
+8 -1
file changed
ruby.spec
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.