#78 Fix for rpmlint
Closed 7 months ago by vondruch. Opened 7 months ago by jaruga.
rpms/ jaruga/ruby wip/fix-by-rpmlint  into  rawhide

file modified
+7 -3
@@ -22,7 +22,7 @@ 

  %endif

  

  

- %global release 146

+ %global release 147

  %{!?release_string:%define release_string %{?development_release:0.}%{release}%{?development_release:.%{development_release}}%{?dist}}

  

  # The RubyGems library has to stay out of Ruby directory tree, since the
@@ -293,7 +293,7 @@ 

  # with disabled RubyGems.

  

  %package default-gems

- Summary:    Default gems which are part of Ruby StdLib.

+ Summary:    Default gems which are part of Ruby StdLib

  Requires:   ruby(rubygems) >= %{rubygems_version}

  Supplements: ruby(rubygems)

  # Include the io-console dependency for reline.
@@ -942,6 +942,7 @@ 

  # Platform independent libraries.

  %dir %{ruby_libdir}

  %exclude %{ruby_libdir}/bigdecimal*

+ %exclude %{ruby_libdir}/io

  %exclude %{ruby_libdir}/irb*

  %exclude %{ruby_libdir}/json*

  %exclude %{ruby_libdir}/psych*
@@ -964,7 +965,6 @@ 

  %{ruby_libdir}/find.rb

  %{ruby_libdir}/forwardable*

  %{ruby_libdir}/getoptlong*

- %{ruby_libdir}/io

  %{ruby_libdir}/ipaddr.rb

  %{ruby_libdir}/kconv.rb

  %{ruby_libdir}/logger*
@@ -1375,6 +1375,10 @@ 

  

  

  %changelog

+ * Fri Mar 19 2021 Jun Aruga <jaruga@redhat.com> - 3.0.0-147

+ - Exclude the duplicated io directory on the ruby-libs.

+ - Update the ruby-default-gems summary.

+ 

  * Tue Mar 02 2021 Vít Ondruch <vondruch@redhat.com> - 3.0.0-146

  - Fix flaky excon test suite.

  - Properly support DWARF5 debug information.

This PR includes the 2 commits to fix the warnings by rpmlint

ruby-default-gems.noarch: W: summary-ended-with-dot C Default gems which are part of Ruby StdLib.
ruby-libs.x86_64: W: dangling-symlink /usr/share/ruby/io /usr/share/gems/gems/io-console-0.5.6/lib/io

  • Exclude the duplicated io directory on the ruby-libs.
  • Update the ruby-default-gems summary.

I tested installing ruby, and installing rubygem-mysql2 and rubygem-pg with the updated ruby.
After the update, the warnings by the rpmlint are disappeared.

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

Thx for PR but sorry, I have noticed too late. I have fixed the summary already while the other commit is not acceptable => closing this.

Pull-Request has been closed by vondruch

7 months ago

@fbo I think the following command used in the rpm-linter is not enough.

rpmlint /root/src/src.fedoraproject.org/rpms/ruby/*.rpm

I want to see the *.spec file is also checked by rpmlint like this. Could you fix it?

rpmlint /root/src/src.fedoraproject.org/rpms/ruby/*.rpm /path/to/*.spec

@jaruga Thanks for the feedback I'll create a change for your request. I'll keep you updated.

@fbo ok, thanks. One more thing. I want to see the Zuul CI is executed not only at the pull-request timing but also at the push timing showing the CI result on the commit like GitHub does. What do you think?
https://src.fedoraproject.org/rpms/ruby/commits/rawhide

Here is a not yet merged change for the rpm-lint job https://pagure.io/zuul-distro-jobs/pull-request/98.

It can be validated in the context of your PR if you want by adding in the Initial PR message the following:

Depends-on: https://pagure.io/zuul-distro-jobs/pull-request/98

Then add "recheck" as a comment here.

@fbo ok, thanks. One more thing. I want to see the Zuul CI is executed not only at the pull-request timing but also at the push timing showing the CI result on the commit like GitHub does. What do you think?
https://src.fedoraproject.org/rpms/ruby/commits/rawhide

It is not possible with Zuul, Zuul unit of testing is the Pull Request. It will always tests the tip commit of the PR as this is the one this is going to land on the target branch.

It is not possible with Zuul, Zuul unit of testing is the Pull Request. It will always tests the tip commit of the PR as this is the one this is going to land on the target branch.

OK. We all of us need about caring the checked items manually if we want to push a commit.

Metadata