PR#2: Update to bcrypt 3.1.16 - rpms/rubygem-bcrypt

rpms / rubygem-bcrypt

#2 Update to bcrypt 3.1.16

Merged 3 years ago by pvalena. Opened 3 years ago by pvalena.

rpms/ pvalena/rubygem-bcrypt rebase into master

Update to bcrypt 3.1.16

Pavel Valena • 3 years ago

1678b79

.gitignore

file modified

+1 -5

		`@@ -1,5 +1,1 @@`
		`- /bcrypt-3.1.7.gem`
		`- /bcrypt-3.1.9.gem`
		`- /bcrypt-3.1.10.gem`
		`- /bcrypt-3.1.11.gem`
		`- /bcrypt-3.1.12.gem`
		`+ /bcrypt-*.gem`

rubygem-bcrypt.spec

file modified

+10 -9

		`@@ -1,23 +1,20 @@`
		`%global gem_name bcrypt`

		`Name: rubygem-%{gem_name}`
		`- Version: 3.1.12`
		`- Release: 9%{?dist}`
		`+ Version: 3.1.16`
		`+ Release: 1%{?dist}`
		`Summary: Wrapper around bcrypt() password hashing algorithm`
		`# ext/* - Public Domain`
		`# spec/TestBCrypt.java - ISC`
		`License: MIT and Public Domain and ISC`
		`URL: https://github.com/codahale/bcrypt-ruby`
		`Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem`
		`+ BuildRequires: ruby`
		`BuildRequires: ruby(release)`
		`BuildRequires: rubygems-devel`
		`BuildRequires: ruby-devel`
		`BuildRequires: rubygem(rspec)`
		`BuildRequires: gcc`
		`- # bcrypt-ruby is renamed to brypt`
		`- Provides: rubygem(brypt-ruby) = %{version}`
		`- Provides: rubygem-bcrypt-ruby = %{version}-%{release}`
		`- Obsoletes: rubygem-bcrypt-ruby <= 3.1.2-2`

		`%description`
		`bcrypt() is a sophisticated and secure hash algorithm designed by The`
		`@@ -33,11 +30,11 @@`
		`Documentation for %{name}.`

		`%prep`
		`- %setup -q -c -T`
		`- %gem_install -n %{SOURCE0}`
		`+ %setup -q -n %{gem_name}-%{version}`

		`%build`
		`- # noop`
		`+ gem build ../%{gem_name}-%{version}.gemspec`
		`+ %gem_install`

		`%install`
		`mkdir -p %{buildroot}%{gem_dir}`
		`@@ -75,6 +72,10 @@`
		`%{gem_instdir}/spec`

		`%changelog`
		`+ * Wed Jan 20 13:40:24 CET 2021 Pavel Valena <pvalena@redhat.com> - 3.1.16-1`
		`+ - Update to bcrypt 3.1.16.`
		`+ Resolves: rhbz#1715983`
		`+`
		`* Wed Jan 6 12:16:53 CET 2021 Vít Ondruch <vondruch@redhat.com> - 3.1.12-9`
		`- Rebuilt for https://fedoraproject.org/wiki/Changes/Ruby_3.0`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (bcrypt-3.1.12.gem) = 1cb465bc00e40c82c7b9789cf5ba96273a455f4c1c993f411a9b80d39aa9c938e4909a094ca92af786ad3cd836eebac2aefcbe1bb29c6238947e55fcdc110d35`
		`+ SHA512 (bcrypt-3.1.16.gem) = 655483d73347c20f3b04a24d625cde05fd8e1da6f022363fbb2df828aea0623cb5b4981d97791301dcd83edc2719a2238d8d377af1558ca2ce4b3c8ade9bd343`

pvalena commented 3 years ago

To have latest bcrypt gem in Fedora.

Up-to-date Koji scratch-build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=60144335

Up-to-date Copr build:
https://copr.fedorainfracloud.org/coprs/build/1890648

Checks:

Koji build: failed (60093899)
Tests: ok
Syntax check: ok
Reverse dependencies: ok
Smoke test: ok
rpmlint: failed

5 packages and 1 specfiles checked; 1 errors, 2 warnings.
rubygem-bcrypt.x86_64: E: zero-length /usr/lib64/gems/ruby/bcrypt-3.1.16/gem.build_complete
rubygem-bcrypt.x86_64: W: obsolete-not-provided rubygem-bcrypt-ruby

Test log: https://git.io/JtmmX
gem2rpm diff: https://git.io/Jtmm1

vondruch commented on line 24 of rubygem-bcrypt.spec 3 years ago

Why removing Provides while keeping Obsoletes?

pvalena commented 3 years ago

Why removing Provides while keeping Obsoletes?

You're right, it probably doesn't make sense to keep this uprade path anymore. What I thought is that obsoletes may be suffucient to preserve upgrade path, while I find it no longer necessary to provide the old name.

rebased onto 1678b79

3 years ago

vondruch commented 3 years ago

LGTM

Pull-Request has been merged by pvalena

3 years ago