#4 Update to bson 4.6.0.
Merged 15 days ago by jaruga. Opened 17 days ago by jaruga.
rpms/ jaruga/rubygem-bson feature/update-to-4.6.0  into  master

file modified
+1

@@ -12,3 +12,4 @@ 

  /bson-4.2.2.gem

  /bson-4.3.0.gem

  /bson-4.5.0.gem

+ /bson-4.6.0.gem

file modified
+10 -4

@@ -2,16 +2,19 @@ 

  %global gem_name bson

  

  Name: rubygem-%{gem_name}

- Version: 4.5.0

- Release: 2%{?dist}

+ Version: 4.6.0

+ Release: 1%{?dist}

  Summary: Ruby Implementation of the BSON specification

  License: ASL 2.0

+ # Keep the URL, while different URL is used in the upstream gemspec file.

+ # Because there is a basic explanation about the bson

+ # that is a beneficial for Fedora user.

  URL: http://bsonspec.org

  Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem

  Requires: rubygem(bigdecimal)

  BuildRequires: ruby(release)

  BuildRequires: rubygems-devel >= 1.3.6

- BuildRequires: ruby-devel >= 1.9.3

+ BuildRequires: ruby-devel >= 2.3

  BuildRequires: gcc

  BuildRequires: rubygem(bigdecimal)

  BuildRequires: rubygem(rspec)

@@ -23,7 +26,7 @@ 

  Obsoletes: rubygem-bson_ext < 4.1.1-1

  

  %description

- A full featured BSON specification implementation, in Ruby.

+ A fully featured BSON specification implementation in Ruby.

  

  

  %package doc

@@ -83,6 +86,9 @@ 

  %{gem_instdir}/spec

  

  %changelog

+ * Tue Nov 19 2019 Jun Aruga <jaruga@redhat.com> - 4.6.0-1

+ - Update to bson 4.6.0.

+ 

  * Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 4.5.0-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild

  

file modified
+1 -1

@@ -1,1 +1,1 @@ 

- SHA512 (bson-4.5.0.gem) = 82ec026cd48c9bf3d6c74ad7a14d5a152e6f13d80c3f29fd4b6a73ad02f8de527adb47d0ff9a22da0cb19297a4937581806f985cc67f3e5d7b6142c3c9249e9e

+ SHA512 (bson-4.6.0.gem) = 78fdfcf8beb6e66b28d8568a44035957291b610d207f2509f7a4a0c359559202673cf3c8350848f988d0fdb78b93c9b6ffec5ffbf0efae184909578b1a886414

This PR is to update to the bson latest version 4.6.0.
To test this PR, you need to donwload bson-4.6.0.gem to your local environment.

After this PR will be okay, I can run fedpkg import *.src.rpm.
Some updates in the spec file comes from the gemspec file: https://github.com/mongodb/bson-ruby/blob/v4.6.0/bson.gemspec .

Could you review it?
Thanks.

I did following tests.

Dependency check

The previous URL was not really the best IMO, but neither the new one looks like improvement.

The previous URL was not really the best IMO, but neither the new one looks like improvement.

Why do you think? I thought the new one showing more concrete level documents, while previous one just showing the concept of bson.

There are some possible URLs. Which is your best in the URLs, if you can say that?

  • The previous URL: URL: http://bsonspec.org
  • The new URL I updated: URL: https://docs.mongodb.com/ruby-driver/current/bson-tutorials/ , because I thought the top page was better than the version specific document at s.homepage.
  • In the upstream gemspec file:
s.homepage          = 'https://docs.mongodb.com/ruby-driver/current/tutorials/bson-v4/'
  s.metadata = {
    'bug_tracker_uri' => 'https://jira.mongodb.org/projects/RUBY',
    'changelog_uri' => 'https://github.com/mongodb/bson-ruby/releases',
    'documentation_uri' => 'https://docs.mongodb.com/ruby-driver/current/tutorials/bson-v4/',
    'homepage_uri' => 'https://docs.mongodb.com/ruby-driver/current/tutorials/bson-v4/',
    'mailing_list_uri' => 'https://groups.google.com/group/mongodb-user',
    'source_code_uri' => 'https://github.com/mongodb/bson-ruby'
  }

The previous URL was not really the best IMO, but neither the new one looks like improvement.

Why do you think? I thought the new one showing more concrete level documents, while previous one just showing the concept of bson.

I always expect that if I open the URL, I will know what the package is good for, e.g. there will be basic explanation such as: "Ruby Implementation of the BSON Specification as defined at http://bsonspec.org/. You can use this packge to ....". Something what is really the "Homepage". I don't expect it to be link to the API documentation or link to tutorial.

And Frankly, the upstream is not doing good job here IMHO. The closest to what I expect is the https://github.com/mongodb/bson-ruby but it is missing the purpose of the package, i.e. why I should use it.

Thanks for sharing the expectation with the reason, Vit. It's useful to fix the different options.

The closest to what I expect is the https://github.com/mongodb/bson-ruby but it is missing the purpose of the package, i.e. why I should use it.

As your answer for my 2nd question "Which is your best in the URLs, if you can say that?", https://github.com/mongodb/bson-ruby is your best URL, right? As your actionable feedback.
I do not understand "it" in your comment "i.e. why I should use it." or the comment itself.

On rubygems.org they point to:
https://docs.mongodb.com/ruby-driver/current/tutorials/bson-v4/

and I don't think it is wrong. IMHO, if someone is looking at this package, they already know they want a BSON implementation in Ruby. First what comes to my mind is "how do I use it" (that's what is on almost every github-README page anyway).

So the tutorial would be the right place to point to, and the one-level-up page even has github page linked:
https://docs.mongodb.com/ruby-driver/current/bson-tutorials/

That works for me.

Good point, Pavel. https://docs.mongodb.com/ruby-driver/current/bson-tutorials/ has the github page link on the page. I think that the bson tutorial page can be an inclusive solution filling Vit's expectation if his expectation is the github page.

@pvalena you are looking at the issue as a Ruby developer. Try to look at it request as Fedora user. You have "rubygem-bson" installed on the system and you try to find out "why the hell is the package on my system". The first sentence from the tutorial says "This tutorial discusses using the core Ruby BSON gem." but this is useless information when you have not heard about Ruby neither about BSON yet. You don't event want to use it, you just want to figure what it is.

rebased onto b5130b5

15 days ago

Rebased with previous URL http://bsonspec.org adding a comment for the URL tag.
I also did run fedpkg import too, as it seems that there will not be a big change by an additional review. Please review again.

Pull-Request has been merged by jaruga

15 days ago