PR#1: Make test suite pass. - rpms/rubygem-kramdown

rpms / rubygem-kramdown

#1 Make test suite pass.

Closed 4 years ago by vondruch. Opened 6 years ago by vondruch.

rpms/ vondruch/rubygem-kramdown fix-tests into master

Make test suite pass.

Vít Ondruch • 6 years ago

2550c7a

rubygem-kramdown.spec

file modified

+14 -2

		`@@ -3,7 +3,7 @@`

		`Name: rubygem-%{gem_name}`
		`Version: 1.17.0`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`Summary: Fast, pure-Ruby Markdown-superset converter`

		`License: MIT`
		`@@ -11,6 +11,7 @@`
		`Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem`
		`BuildRequires: ruby(release)`
		`BuildRequires: rubygems-devel`
		`+ BuildRequires: rubygem(coderay)`
		`BuildRequires: rubygem(minitest) >= 5`
		`BuildRequires: rubygem(prawn)`
		`BuildRequires: rubygem(prawn-table)`
		`@@ -71,8 +72,16 @@`

		`pushd .%{gem_instdir}`

		`+ # We don't have stringex in Fedora.`
		`+ rm test/testcases/block/04_header/with_auto_ids.text`
		`+`
		`+ # We don't have any math conversion libraries (ritex, itextomml, sskatex,`
		`+ # katex) in Fedora.`
		`+ rm -rf test/testcases/block/15_math/*.text`
		`+ rm -rf test/testcases/span/math/*.text`
		`+`
		`# Some tests seem to be failing, need investigating`
		`- rake test \|\| true`
		`+ rake test`
		`popd`

		`%files`
		`@@ -94,6 +103,9 @@`
		`%doc %{gem_instdir}/doc/`

		`%changelog`
		`+ * Tue Jun 26 2018 Vít Ondruch <vondruch@redhat.com> - 1.17.0-2`
		`+ - Make test suite pass.`
		`+`
		`* Mon Jun 4 2018 Mamoru TASAKA <mtasaka@fedoraproject.org> - 1.17.0-1`
		`- 1.17.0`

no initial comment

vondruch commented 6 years ago

I'll merge it myself in a ~week unless you have any objections.

mtasaka commented 5 years ago

Personally, (although my feeling changes from day to day), I don't want to drop failed test suite completely, but want to check them every time I build manually.

vondruch commented 5 years ago

I don't disagree, but I prefer to be sure that the test suite passed in known (even broken) state. This catch all errors handling is not helpful. If this package becomes broken due to its build dependencies for whatever reason, I won't be able to catch such issues (looking at Koschei or trying to rebuild manually for instance).

vondruch commented 4 years ago

No test is ignored since e01594c, so this is likely obsolete => closing.