#1 Update to msgpack 1.4.4
Merged 2 years ago by vondruch. Opened 4 years ago by pvalena.
rpms/ pvalena/rubygem-msgpack rebase  into  rawhide

file modified
+1 -2
@@ -1,2 +1,1 @@ 

- /msgpack-0.5.11.gem

- /msgpack-1.1.0.gem

+ /msgpack-*.gem

file modified
+11 -28
@@ -2,8 +2,8 @@ 

  %global gem_name msgpack

  

  Name: rubygem-%{gem_name}

- Version: 1.1.0

- Release: 18%{?dist}

+ Version: 1.4.4

+ Release: 1%{?dist}

  Summary: MessagePack, a binary-based efficient data interchange format

  License: ASL 2.0

  URL: http://msgpack.org/
@@ -13,15 +13,9 @@ 

  BuildRequires: rubygems-devel

  BuildRequires: ruby-devel

  BuildRequires:  rubygem(rspec)

- # BuildRequires: rubygem(rake-compiler) => 0.8.3

  # BuildRequires: rubygem(rake-compiler) < 0.9

- # BuildRequires: rubygem(rspec) => 2.11

- # BuildRequires: rubygem(rspec) < 3

- # BuildRequires: rubygem(json) => 1.7

  # BuildRequires: rubygem(json) < 2

- # BuildRequires: rubygem(yard) => 0.8.2

  # BuildRequires: rubygem(yard) < 0.9

- Provides: rubygem(%{gem_name}) = %{version}

  

  %description

  MessagePack is a binary-based efficient object serialization library. It
@@ -38,18 +32,10 @@ 

  Documentation for %{name}.

  

  %prep

- gem unpack %{SOURCE0}

- 

- %setup -q -D -T -n  %{gem_name}-%{version}

- 

- gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec

+ %setup -q -n %{gem_name}-%{version}

  

  %build

- # Create the gem as gem install only works on a gem file

- gem build %{gem_name}.gemspec

- 

- # %%gem_install compiles any C extensions and installs the gem into ./%%gem_dir

- # by default, so that we can move it into the buildroot in %%install

+ gem build ../%{gem_name}-%{version}.gemspec

  %gem_install

  

  %install
@@ -57,19 +43,12 @@ 

  cp -a .%{gem_dir}/* \

          %{buildroot}%{gem_dir}/

  

- %if 0%{?fedora} || 0%{?rhel} >= 8

  mkdir -p %{buildroot}%{gem_extdir_mri}

  cp -ar .%{gem_extdir_mri}/{gem.build_complete,%{gem_name}} %{buildroot}%{gem_extdir_mri}/

- %else

- mkdir -p %{buildroot}%{gem_extdir_mri}/lib/%{gem_name}

- cp -ar .%{gem_instdir}/lib/%{gem_name}/%{gem_name}.so %{buildroot}%{gem_extdir_mri}/lib/%{gem_name}

- %endif

  

  # Prevent dangling symlink in -debuginfo (rhbz#878863).

  rm -rf %{buildroot}%{gem_instdir}/ext/

  

- rm -f %{buildroot}%{gem_instdir}/{.gitignore,.travis.yml}

- 

  # Run the test suite

  %check

  pushd .%{gem_instdir}
@@ -80,9 +59,9 @@ 

  %files

  %dir %{gem_instdir}

  %{gem_extdir_mri}

- %exclude %{gem_instdir}/.rubocop.yml

+ %exclude %{gem_instdir}/.*

  %license %{gem_instdir}/LICENSE

- %{gem_instdir}/appveyor.yml

+ %exclude %{gem_instdir}/appveyor.yml

  %{gem_instdir}/bench

  %{gem_libdir}

  %{gem_instdir}/msgpack.org.md
@@ -93,13 +72,17 @@ 

  %doc %{gem_docdir}

  %doc %{gem_instdir}/ChangeLog

  %{gem_instdir}/Gemfile

- %doc %{gem_instdir}/README.rdoc

+ %doc %{gem_instdir}/README.md

  %{gem_instdir}/Rakefile

  %doc %{gem_instdir}/doclib

  %{gem_instdir}/msgpack.gemspec

  %{gem_instdir}/spec

  

  %changelog

+ * Sun Feb 06 2022 Pavel Valena <pvalena@redhat.com> - 1.4.4-1

+ - Update to msgpack 1.4.4.

+   Resolves: rhbz#1533462

+ 

  * Wed Jan 26 2022 Vít Ondruch <vondruch@redhat.com> - 1.1.0-18

  - Rebuilt for https://fedoraproject.org/wiki/Changes/Ruby_3.1

  

file modified
+1 -1
@@ -1,1 +1,1 @@ 

- SHA512 (msgpack-1.1.0.gem) = 0142c9a446a476a7b4f9212513dd7b1fbe107193a473873f4eb6f4321d5515c42ea3540ac4de17f37f9e833f19bb75594d14b84ccf70b16d2a3840e066c873da

+ SHA512 (msgpack-1.4.4.gem) = 0ee58d5c334f7ee3e8b890d480b71141603bd5951b188ef162d2ca03f51ef40316ff386c505ccd9dc8a6e667359b9fd8934263b1200a4ee8a399c220e95156b0

also ehnance .spec and .gitignore files.

Resolves: rhbz#1533462
https://bugzilla.redhat.com/show_bug.cgi?id=1533462


To have latest msgpack gem in Fedora.

Note: I'm updating bootsnap as well with RoR 7.0.X.

Koji scratch-build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=82474905

Copr build:
https://copr.fedorainfracloud.org/coprs/build/3334854

Checks:

  • Koji build: failed (82474905)
  • Tests: ok
  • Syntax check: ok
  • Reverse dependencies: needs inspection (rubygem-bootsnap: (rubygem(msgpack) >= 1.0 with rubygem(msgpack) < 2) )
  • Smoke test: ok
  • rpmlint: failed
rubygem-msgpack-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/gems/ruby/msgpack-1.4.4/msgpack/msgpack.so-1.4.4-1.fc36.x86_64.debug
rubygem-msgpack-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/c9/884a92acc10b1fd99b0ff13dbb389d77802e1e ../../../.build-id/c9/884a92acc10b1fd99b0ff13dbb389d77802e1e
rubygem-msgpack-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/gems/ruby/msgpack-1.4.4/msgpack/msgpack.so-1.4.4-1.fc36.x86_64.debug
rubygem-msgpack.x86_64: E: non-executable-script /usr/share/gems/gems/msgpack-1.4.4/bench/run.sh 644 /bin/sh
rubygem-msgpack.x86_64: E: non-executable-script /usr/share/gems/gems/msgpack-1.4.4/bench/run_long.sh 644 /bin/sh
rubygem-msgpack.x86_64: E: non-executable-script /usr/share/gems/gems/msgpack-1.4.4/bench/run_symbols.sh 644 /bin/sh
rubygem-msgpack.x86_64: W: potential-bashisms /usr/share/gems/gems/msgpack-1.4.4/bench/run_long.sh
rubygem-msgpack.x86_64: W: potential-bashisms /usr/share/gems/gems/msgpack-1.4.4/bench/run_symbols.sh

Update log: https://gist.github.com/a6d6a8eace68e9d260b6787fc4ae6d7e
Test log: https://gist.github.com/b5f0d275f68fd02df94c33c819ea7cf4
gem2rpm diff: https://gist.github.com/7cad66cbda9e18b172c4a34886e0ea98


I've created an issue for rpmlint error:
https://github.com/msgpack/msgpack-ruby/issues/176

rebased onto 3612a8f

4 years ago

@spredzy, I've rebased, retested, please merge.

@spredzy rebased, retested, LGTM.

Please also consider adding @ruby-packagers-sig to commiters to this package.

rebased onto 61059be

3 years ago

rebased onto fd66cc9

3 years ago

rebased onto 4791922

3 years ago

rebased onto 39e5b79

2 years ago

This is causing failures now:
https://github.com/Shopify/bootsnap/issues/395

Rebased, retested, updated description.

rebased onto a2dc839

2 years ago

rebased onto 6e0d84d

2 years ago

rebased onto ad798e1

2 years ago

Updated, retested, reviewed.

This is blocking update of bootsnap: https://src.fedoraproject.org/rpms/rubygem-bootsnap/pull-request/4

LGTM and I can merge. Nevertheless, maybe it is the time to check @spredzy for his availability:

https://docs.fedoraproject.org/en-US/fesco/Policy_for_nonresponsive_package_maintainers/

Pull-Request has been merged by vondruch

2 years ago

@vondruch yes, please.

Done, you can move forward with build.

I've already created the ticket: https://bugzilla.redhat.com/show_bug.cgi?id=2051519

Thx