#2 Fix bogus date warnings when "fedpkg srpm".
Opened 10 months ago by jaruga. Modified 10 months ago
rpms/ jaruga/rubygem-nokogiri hotfix/bogus-date-warning  into  master

file modified
+2 -2

@@ -376,7 +376,7 @@ 

  - F-17: rebuild for ruby19

  - For now aviod build failure by touching some files

  

- * Thu Jan 18 2012 Mamoru Tasaka <mtasaka@fedoraproject.org> - 1.5.0-1

+ * Wed Jan 18 2012 Mamoru Tasaka <mtasaka@fedoraproject.org> - 1.5.0-1

  - 1.5.0

  

  * Sat Jan 14 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.5.0-0.5.beta4.1

@@ -385,7 +385,7 @@ 

  * Sun Jun 26 2011 Mamoru Tasaka <mtasaka@fedoraproject.org> - 1.5.0-0.5.beta4

  - Remove unneeded patch

  

- * Thu Mar 18 2011 Mamoru Tasaka <mtasaka@fedoraproject.org> - 1.5.0-0.4.beta4

+ * Fri Mar 18 2011 Mamoru Tasaka <mtasaka@fedoraproject.org> - 1.5.0-0.4.beta4

  - Patch for newer rake to make testsuite run

  

  * Wed Feb 09 2011 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.5.0-0.3.beta4.1

Thank you for maintaining this package.
I fixed below bogus date warnings changing the day of the week.

$ fedpkg srpm 
warning: bogus date in %changelog: Thu Jan 18 2012 Mamoru Tasaka <mtasaka@fedoraproject.org> - 1.5.0-1
warning: bogus date in %changelog: Thu Mar 18 2011 Mamoru Tasaka <mtasaka@fedoraproject.org> - 1.5.0-0.4.beta4



warning: bogus date in %changelog: Thu Jan 18 2012 Mamoru Tasaka <mtasaka@fedoraproject.org> - 1.5.0-1
warning: bogus date in %changelog: Thu Mar 18 2011 Mamoru Tasaka <mtasaka@fedoraproject.org> - 1.5.0-0.4.beta4
Wrote: /home/jaruga/git/fedora-packages/rubygem-nokogiri/rubygem-nokogiri-1.8.4-1.fc30.1.src.rpm

I checked cal command to check it. And now no warnings.

$ cal 18 03 2011

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=29117230

I don't want to do this type of change. Actually I am no longer sure what date is correct exactly - there is no rationale to believe that date is correct and day of the week is wrong, and both can be wrong. Also there is no guarantee that git commit date and changelog date is the same. And I don't want to modify history log once it is written.

Sure, yeah exactly there is no way to check which date is correct.
I just did not want to see the warnings for each "fedpkg srpm".
And it was more important for me to do it than display correct date.

So, do you think there is no way to suppress the warnings?

I investigated the detail.

Line: "Thu Jan 18 2012 Mamoru Tasaka mtasaka@fedoraproject.org - 1.5.0-1"

Possible date is "Wed Jan 18 2012" or "Thu Jan 19 2012"
Commit hash's Date is "Wed Jan 18 17:30:31 2012 +0900".

commit f462b6acbe596c5f2d50cf2135325487d05caac7
Author: TASAKA Mamoru <mtasaka@localhost.localdomain>
Date:   Wed Jan 18 17:30:31 2012 +0900

    1.5.0

It is impossible that changelog Jan 19 is future than commit date Jan 18.
So, correct date is "Wed Jan 18 2012".

Line: "Thu Mar 18 2011 Mamoru Tasaka mtasaka@fedoraproject.org - 1.5.0-0.4.beta4"

Possible date is "Fri Mar 18 2011" or "Thu Mar 17 2011"

commit hash's Date is "Fri Mar 18". So, both dates are possible.

commit a86b5ca51b544c23256c775de2b217e99fd5e16f
Author: Mamoru Tasaka <tasaka1@localhost.localdomain>
Date:   Fri Mar 18 05:18:34 2011 +0900

    Patch for newer rake to make testsuite run

If I may add my opinion- I agree with fixing the day of the week, but I would omit themainrel bump and changelog entry, and package rebuild.

At the moment the %changelog entry is nor correct, nor it has it any useful information (and produces warnings).

As the commit hash's date is probably the date you intened to put there (and the difference is negligent) I would prefer to change it, even though it's a "history log" and "should not" be modified.

As the commit hash's date is probably the date you intened to put there (and the difference is negligent) I would prefer to change it, even though it's a "history log" and "should not" be modified.

I agree with it.

@mtasaka
I think that the commit date might be the one you intended.
If you want, you can just close this ticket, then update the date as you like without the bump and changelog entry.

rebased onto 6b58fbd

10 months ago

@mtasaka I found a way to prove the actual commit date. The "CommitDate" is actual commit date. I rebased without my changelog comment.

$ git show --pretty=fuller f462b6acbe596c5f2d50cf2135325487d05caac7
commit f462b6acbe596c5f2d50cf2135325487d05caac7
Author:     TASAKA Mamoru <mtasaka@localhost.localdomain>
AuthorDate: Wed Jan 18 17:30:31 2012 +0900
Commit:     TASAKA Mamoru <mtasaka@localhost.localdomain>
CommitDate: Wed Jan 18 17:30:31 2012 +0900
...
  => Wed Jan 18 is the actual date.

$ git show --pretty=fuller a86b5ca51b544c23256c775de2b217e99fd5e16f
commit a86b5ca51b544c23256c775de2b217e99fd5e16f
Author:     Mamoru Tasaka <tasaka1@localhost.localdomain>
AuthorDate: Fri Mar 18 05:18:34 2011 +0900
Commit:     Mamoru Tasaka <tasaka1@localhost.localdomain>
CommitDate: Fri Mar 18 05:18:34 2011 +0900
...
  => Fri Mar 18 is the actual date