#5 Remove rubygem(minitest-reporters) dependency.
Closed 3 years ago by mtasaka. Opened 3 years ago by vondruch.
rpms/ vondruch/rubygem-nokogiri remove-minitest-reporters  into  rawhide

file modified
+9 -2
@@ -1,7 +1,7 @@ 

  %global	mainver		1.11.3

  #%%global	prever		.rc4

  

- %global	mainrel		1

+ %global	mainrel		2

  %global	prerpmver		%(echo "%{?prever}" | sed -e 's|\\.||g')

  

  %global	gem_name	nokogiri
@@ -29,7 +29,6 @@ 

  ##

  ## For %%check

  BuildRequires:	rubygem(minitest)

- BuildRequires:	rubygem(minitest-reporters)

  BuildRequires:	rubygems-devel

  Obsoletes:		ruby-%{gem_name} <= 1.5.2-2

  #BuildRequires:	ruby(racc)
@@ -170,6 +169,11 @@ 

  sed -i test/helper.rb \

  	-e '\@require.*simplecov@,\@^end$@d'

  

+ # Remove minitest-reporters. It does not provide any additional value while

+ # it blows up the dependency chain.

+ sed -i '/require..minitest.reporters./ s/^/#/' test/helper.rb

+ sed -i '/Minitest::Reporters/ s/^/#/' test/helper.rb

+ 

  # Need investigation. For now anyway build

  env \

  	RUBYLIB=".:lib:test:ext" \
@@ -203,6 +207,9 @@ 

  %{gem_dir}/doc/%{gem_name}-%{mainver}%{?prever}/

  

  %changelog

+ * Fri May 07 2021 Vít Ondruch <vondruch@redhat.com> - 1.11.3-2

+ - Remove rubygem(minitest-reporters) dependency.

+ 

  * Thu Apr  8 2021 Mamoru TASAKA <mtasaka@fedoraproject.org> - 1.11.3-1

  - 1.11.3

  

This does not provide any value for Fedora, but it bloats dependency chain. Less dependencies is also advantage for ELN.

I have not tried to push this change into upstream, since it seems there is additional value for upstream, because the dependency was introduced not long time ago:

https://github.com/sparklemotion/nokogiri/commit/1e5738699c696dab6867a99397c2aeec6176c548

I want to decline this for now. Checking this type on distribution side is burden for packagers.

Np. I just tried. I totally understand.

... But after a second thought, currently rubygem-maruku is orphaned, rubygem-minitest-reporters depends on it, and I want to kill (possibly) unresolved depedency right now (due to orphaned packages), so I am going to merge this.

Merged and built, thank you.

Pull-Request has been closed by mtasaka

3 years ago

currently rubygem-maruku is orphaned

Interesting, good catch. If it gets retired, it might influence also rubygem-tilt. But that is just one of the many templating libraries used for integration tests, so it is probably fine to let it go.

rubygem-minitest-reporters depends on it, and I want to kill (possibly) unresolved depedency right now (due to orphaned packages), so I am going to merge this.

I was also thinking about bcond_with, but I guess it would not make the situation any better (ELN does not really support it anyway :/)

Metadata