#7 Fix ELN build
Closed 9 months ago by mtasaka. Opened 9 months ago by yselkowitz.
rpms/ yselkowitz/rubygem-nokogiri rawhide  into  rawhide

file modified
+1 -3
@@ -109,10 +109,8 @@ 

  	gumbo-parser/src/Makefile \

  	-e 's|^\(CFLAGS.*=.*\)$|\1 -fPIC|'

  

- # MiniTest 5.19+

- %if 0%{?fedora} >= 39

+ # MiniTest 4.y compat shim dropped by default in Minitest 5.19

  grep -rl MiniTest nokogiri-*/test/ | xargs sed -i 's|MiniTest::|Minitest::|'

- %endif

  

  %build

  # Ummm...

ELN (the future RHEL 10) follows rawhide and therefore also has rubygem-minitest 5.19.

I have already pinged @mtasaka, but the condition is unnecessary IMHO. I have not realized that it will break ELN right away.

And it seems there is also upstream fix:

https://github.com/sparklemotion/nokogiri/commit/a29042b0c0dbdc1b488a97dd6d6dd88d4b583c05

rebased onto be4d70d

9 months ago

Pull-Request has been closed by mtasaka

9 months ago

(by applying the upstream change, thank yoi.)

Metadata