PR#1: Fix FTBFS: Update to rspec-collection_matchers 1.2.0. - rpms/rubygem-rspec-collection_matchers

rpms / rubygem-rspec-collection_matchers

#1 Fix FTBFS: Update to rspec-collection_matchers 1.2.0.

Merged 3 years ago by pvalena. Opened 3 years ago by pvalena.

rpms/ pvalena/rubygem-rspec-collection_matchers rebase into master

Update to rspec-collection_matchers 1.2.0.

Pavel Valena • 3 years ago

62189a8

rubygem-rspec-collection_matchers.spec

file modified

+17 -4

		`@@ -1,9 +1,12 @@`
		`# Generated from rspec-collection_matchers-1.1.3.gem by gem2rpm -- rpm-spec --`
		`%global gem_name rspec-collection_matchers`

		`+ # To skip execution of cucumber tests`
		`+ %bcond_without cucumber`
		`+`
		`Name: rubygem-%{gem_name}`
		`- Version: 1.1.3`
		`- Release: 7%{?dist}`
		`+ Version: 1.2.0`
		`+ Release: 1%{?dist}`
		`Summary: Collection cardinality matchers`
		`License: MIT`
		`URL: https://github.com/rspec/rspec-collection_matchers`
		`@@ -12,8 +15,13 @@`
		`BuildRequires: rubygems-devel`
		`BuildRequires: ruby`
		`BuildRequires: rubygem(rspec)`
		`+ BuildRequires: rubygem(rspec-support)`
		`+ BuildRequires: rubygem(activemodel)`
		`+ %if %{with cucumber}`
		`BuildRequires: rubygem(aruba)`
		`+ %endif`
		`BuildRequires: rubygem(activemodel)`
		`+ BuildRequires: rubygem(contracts)`
		`BuildArch: noarch`

		`%description`
		`@@ -44,9 +52,10 @@`
		`pushd .%{gem_instdir}`
		`rspec spec`

		`- # requires loaded 'rspec/matchers' in file executed by tests`
		- sed -i '/\s*When I run `rspec /,/^$/ s/^/#/' features/have.feature
		`+ %if %{with cucumber}`
		`+ RUBYOPT="-I${PWD}/lib" \`
		`cucumber`
		`+ %endif`
		`popd`

		`%files`
		`@@ -70,6 +79,10 @@`
		`%{gem_instdir}/spec`

		`%changelog`
		`+ * Thu Aug 06 15:17:11 GMT 2020 Pavel Valena <pvalena@redhat.com> - 1.2.0-1`
		`+ - Update to rspec-collection_matchers 1.2.0.`
		`+ Resolves: rhbz#1863731`
		`+`
		`* Sat Aug 01 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1.1.3-7`
		`- Second attempt - Rebuilt for`
		`https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (rspec-collection_matchers-1.1.3.gem) = 3af81c016f259f363c126ac829c8bd51b9c67d54c5c8b2def317b430b852c27eabbd538b79f0a5a919d5edba66f9501c38de560a7ac26023fae7b5588b57439d`
		`+ SHA512 (rspec-collection_matchers-1.2.0.gem) = 0988cabcd8873cbb7161fda3500ae77ae299024a25a1f3faa71cad673777097518db5fddc9ff0ca8e25653c4e790b7ba76fe234596848816276defddef2e308c`

pvalena commented 3 years ago

Fix FTBFS.
Resolves: rhbz#1863731

Also to have latest rspec-collection_matchers gem in Fedora.

Up-to-date Koji scratch-build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=48272381

Up-to-date Copr build:
https://copr.fedorainfracloud.org/coprs/build/1589380

Checks:

Syntax check: ok
Tests: failed (errors occured)
Dependent packages: ok
Smoke test: ok
rpmlint: ok

Log: https://git.io/JJaLS

vondruch commented on line 5 of rubygem-rspec-collection_matchers.spec 3 years ago

I am not sure this is the best name. But if you insist, then it would be useful to document the purpose at minimum.

vondruch commented on line 21 of rubygem-rspec-collection_matchers.spec 3 years ago

This is superfluous if there is BR: rubygem(rspec) above.

vondruch commented on line 35 of rubygem-rspec-collection_matchers.spec 3 years ago

Is this still relevant when you remove the line bellow?

vondruch commented 3 years ago

You also probably want to add/change the reference to rhbz#1863731

rebased onto 5e58a91

3 years ago

rebased onto 0f19215

3 years ago

pvalena commented 3 years ago

I am not sure this is the best name. But if you insist, then it would be useful to document the purpose at minimum.

Yes, in EPEL there's no cucumber, f.e.. This helps.

Fixed all. Thanks for review!

rebased onto 62189a8

3 years ago

Pull-Request has been merged by pvalena

3 years ago

vondruch commented 3 years ago

I am not sure this is the best name. But if you insist, then it would be useful to document the purpose at minimum.

Yes, in EPEL there's no cucumber, f.e.. This helps.

I am not questioning usability. I'm just questioning that not everybody who might touch this package might understand what is cucumber good for, so if the variable was named something like integration_test_suite, that could give a better clue.

pvalena commented 3 years ago

I am not questioning usability. I'm just questioning that not everybody who might touch this package might understand what is cucumber good for, so if the variable was named something like integration_test_suite, that could give a better clue.

Right, but at the same time, one should learn what cucumber (as in https://cucumber.io/) is, as it's integral part of maintenance. I wonder if it could be mistaken for anything else?

WYI: I've added the comment: + # To skip execution of cucumber tests

Edited 3 years ago by pvalena