#1 WIP: Update to spring 3.1.1
Closed a year ago by vondruch. Opened 2 years ago by pvalena.
rpms/ pvalena/rubygem-spring rebase  into  rawhide

file modified
+2 -11
@@ -1,11 +1,2 @@ 

- /spring-1.1.2.gem

- /spring-1.1.3.gem

- /rubygem-spring-1.3.6-tests.tar.gz

- /spring-1.3.6.gem

- /spring-1.4.0.gem

- /rubygem-spring-1.7.2-tests.tar.gz

- /spring-1.7.2.gem

- /rubygem-spring-2.0.0-tests.tar.gz

- /spring-2.0.0.gem

- /spring-2.1.1-tests.tar.gz

- /spring-2.1.1.gem

+ /spring-*.gem

+ /spring-*-tests.tar.gz

file modified
+9 -16
@@ -1,18 +1,15 @@ 

  %global gem_name spring

  

  Name: rubygem-%{gem_name}

- Version: 2.1.1

- Release: 4%{?dist}

+ Version: 4.0.0

+ Release: 1%{?dist}

  Summary: Rails application preloader

  License: MIT

  URL: https://github.com/rails/spring

  Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem

- # git clone https://github.com/rails/spring.git && cd spring

- # git archive -v -o spring-2.1.1-tests.tar.gz v2.1.1 test/

- Source1: %{gem_name}-%{version}-tests.tar.gz

- # Fir Ruby 3.0 compatibility.

- # https://github.com/rails/spring/pull/632

- Patch0: spring-2.1.1-Use-keyword-argument-instead-of-Has-as-optional-argument.patch

+ # git clone https://github.com/rails/spring.git --no-checkout

+ # git -C spring archive -v -o spring-4.0.0-tests.txz v4.0.0 test/

+ Source1: %{gem_name}-%{version}-tests.txz

  # Needed by `spring status`

  Requires: %{_bindir}/ps

  BuildRequires: ruby(release)
@@ -41,16 +38,8 @@ 

  %prep

  %setup -q -n %{gem_name}-%{version} -b 1

  

- pushd %{_builddir}

- %patch0 -p1

- popd

- 

  %build

- # Create the gem as gem install only works on a gem file

  gem build ../%{gem_name}-%{version}.gemspec

- 

- # %%gem_install compiles any C extensions and installs the gem into ./%%gem_dir

- # by default, so that we can move it into the buildroot in %%install

  %gem_install

  

  %install
@@ -87,6 +76,10 @@ 

  %doc %{gem_instdir}/README.md

  

  %changelog

+ * Mon Nov 01 2021 Pavel Valena <pvalena@redhat.com> - 4.0.0-1

+ - Update to spring 4.0.0.

+   Resolves: rhbz#2002484

+ 

  * Fri Jul 23 2021 Fedora Release Engineering <releng@fedoraproject.org> - 2.1.1-4

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild

  

file modified
+2 -2
@@ -1,2 +1,2 @@ 

- SHA512 (spring-2.1.1-tests.tar.gz) = 1a0fe68d07863ceec45882e0f0739c868e60844b78964f1079d35d3b00d6fbc69de82fa891c2b1f4ad81eeb567463ed6263ed3c83fd35c0a4e885f0f2eb7db26

- SHA512 (spring-2.1.1.gem) = a51c3f9cde3fc388ee63cc97bdd2da6eba8a4813d77f2dbe7c8bc98bd6789793120429b4254804971c3d8ecbee6aa59a9563066edfc2e4ee89c869aabd7c5971

+ SHA512 (spring-4.0.0.gem) = 22b64b8d268c5fd5b87a5ecfda390d108451887c9b8df27c6b623074322ced3f1745e16e57a591b252fe5ffd75da2c19fa524d140f3f56e91b770079764fef7d

+ SHA512 (spring-4.0.0-tests.txz) = d1bc983f496fc70573b90626a5e9f37a5b87463aebe0c7c53c9fefb1f377feec1716c05034f10004ee09fc2e921685a73affe3979fb60c58cd5bebf30eee5d97


To have latest spring gem in Fedora.

Koji scratch-build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=79442053

Copr build:
https://copr.fedorainfracloud.org/coprs/build/2995095

Checks:

  • Koji build: ok
  • Tests: ok
  • Syntax check: ok
  • Reverse dependencies: needs inspection (rubygem-spring-watcher-listen: (rubygem(spring) >= 1.2 with rubygem(spring) < 3.0) )
  • Smoke test: failed (ruby -e "require '\''spring'\''" || ruby -e "require '\''spring'\''")
  • rpmlint: ok

Update log: https://git.io/JM2aA
Test log: https://git.io/JM2ah
gem2rpm diff: https://git.io/JM2aj

Yep, the rubygem-spring-watcher-listen would need to test and relax the dependency, so this is not acceptable on its own

rebased onto a78d3b4

2 years ago

How do you proceed this PR? Rebase relaxing the rubygem-spring-watcher-listen dependency?

Actually, spring-watcher-listen doesn't have update AFAIR, and it would break (won't work with new spring). Therefore the upgrade might not be possible.

Let me investigate if this has changed.

Pull-Request has been closed by vondruch

a year ago

I have update Spring to 4.1.1 as well as spring-watcher-listen to 2.1.0