PR#2: Fix outdated URL. - rpms/rubygem-thin

rpms / rubygem-thin

#2 Fix outdated URL.

Merged 3 years ago by jaruga. Opened 3 years ago by jaruga.

rpms/ jaruga/rubygem-thin wip/outdated-url into master

Fix outdated URL.

Jun Aruga • 3 years ago

0829d25

rubygem-thin.spec

file modified

+3 -2

		`@@ -7,7 +7,7 @@`
		`# lib/thin/stats.html.erb: BSD`
		`# spec/rails_app/public/javascripts/*.js: MIT`
		`License: (GPLv2+ or Ruby) and BSD and MIT`
		`- URL: http://code.macournoyer.com/thin/`
		`+ URL: https://github.com/macournoyer/thin`
		`Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem`
		`# git clone https://github.com/macournoyer/thin.git && cd thing`
		`# git checkout v1.7.2 && tar czvf thin-1.7.2-tests.tgz spec/`
		`@@ -155,8 +155,9 @@`
		`%{gem_instdir}/Rakefile`

		`%changelog`
		`- * Tue Oct 27 2020 Jun Aruga <jaruga@redhat.com> - 1.7.2-15`
		`+ * Fri Oct 30 2020 Jun Aruga <jaruga@redhat.com> - 1.7.2-15`
pvalena commented 3 years ago If you don't need "bump" for build, the release this case, then there's no need to add changelog / change date. Also this message (fix URL) is concerning packaging only, IMHO it should be only in commit msg.
		`- Fix to run the tests on RSpec 3.`
		`+ - Fix outdated URL.`

		`* Wed Jul 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1.7.2-14`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild`

jaruga commented 3 years ago

This PR is to fix the following the rpmlint warning about the outdated URL.

rubygem-thin.src: W: invalid-url URL: http://code.macournoyer.com/thin/ <urlopen error [Errno -2] Name or service not known>
The value should be a valid, public HTTP, HTTPS, or FTP URL.

See this upstream commit for detail.
https://github.com/macournoyer/thin/commit/ff003f09e4fc338d5c7d4f6834257328a8f6aed5

I confirmed the warning was disappeared after fixing it.

If the review is okay, I will merge and build it.

pvalena commented on line 15 of rubygem-thin.spec 3 years ago

If you don't need "bump" for build, the release this case, then there's no need to add changelog / change date. Also this message (fix URL) is concerning packaging only, IMHO it should be only in commit msg.

pvalena commented 3 years ago

Thanks for bringing this up, I'll add an URL updater into my update tooling!

jaruga commented 3 years ago

Sure!

jaruga commented 3 years ago

I would merge this PR, as I do see nobody complaining about it.

Pull-Request has been merged by jaruga

3 years ago