PR#2: Update to 1.1.0 - rpms/rubygem-thor

rpms / rubygem-thor

#2 Update to 1.1.0

Closed 3 years ago by pvalena. Opened 3 years ago by ignatenkobrain.

rpms/ ignatenkobrain/rubygem-thor master into master

Update to 1.1.0

Igor Raits • 3 years ago

d8b351c

rubygem-thor.spec

file modified

+10 -7

		`@@ -1,27 +1,27 @@`
		`- # Generated from thor-0.12.0.gem by gem2rpm -- rpm-spec --`
		`+ # Generated from thor-1.1.0.gem by gem2rpm -- rpm-spec --`
pvalena commented 3 years ago This line shouldn't be chaged.
ignatenkobrain commented 3 years ago why not? I mean, it is obsolete and we can even remove it
		`%global gem_name thor`

		`Name: rubygem-%{gem_name}`
		`- Version: 1.0.1`
		`+ Version: 1.1.0`
		`Release: 1%{?dist}`
		`Summary: Thor is a toolkit for building powerful command-line interfaces`
		`License: MIT`
		`URL: http://whatisthor.com/`
		`Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem`
		`# The test suite is not shipped with the gem, you may check it out like so:`
		`- # git clone https://github.com/erikhuda/thor.git --no-checkout`
		`- # cd thor && git archive -v -o thor-1.0.1-spec.txz v1.0.1 spec/`
		`+ # git clone https://github.com/erikhuda/thor --no-checkout`
		`+ # git -C thor archive -v -o $PWD/thor-1.1.0-spec.txz v1.1.0 spec/`
		`Source1: %{gem_name}-%{version}-spec.txz`
		`# ruby package has just soft dependency on rubygem(io-console), while`
		`# Thor always requires it.`
		`Requires: rubygem(io-console)`
		`BuildRequires: ruby(release)`
		`- BuildRequires: rubygems-devel`
		`- BuildRequires: ruby`
		`+ BuildRequires: rubygems-devel >= 1.3.5`
		`+ BuildRequires: ruby >= 2.0.0`
		`BuildRequires: rubygem(io-console)`
		`BuildRequires: rubygem(rspec)`
		`BuildRequires: rubygem(webmock)`
		`- BuildRequires: %{_bindir}/git`
		`+ BuildRequires: /usr/bin/git`
pvalena commented 3 years ago This seems to me like a step back IMO.
ignatenkobrain commented 3 years ago well, if you build in different %{_prefix} (e.g. flatpak build) then your package will fail to build.
vondruch commented 3 years ago As long as there is no upstream RPM support neither Fedora guideline, then I prefer to have `%{_bindir}`. What is the right value for flatpak is questionable anyway.
		`BuildArch: noarch`

		`%description`
		`@@ -92,6 +92,9 @@`
		`%{gem_instdir}/thor.gemspec`

		`%changelog`
		`+ * Sun Jan 24 2021 Igor Raits <ignatenkobrain@fedoraproject.org> - 1.1.0-1`
		`+ - Update to 1.1.0`
		`+`
		`* Wed Aug 05 23:45:19 GMT 2020 Pavel Valena <pvalena@redhat.com> - 1.0.1-1`
		`- Update to Thor 1.0.1.`
		`Resolves: rhbz#1783465`

sources

file modified

+2 -2

		`@@ -1,2 +1,2 @@`
		`- SHA512 (thor-1.0.1.gem) = 51560fabff2df52ff1d6745d419dfd3e26d58d79d36e2baa5a6aa9304a5ac0dc539abf956cfa9d8c1ad882586aa7e9edc886ea4cdc9a9574315befaf5dfb91b0`
		`- SHA512 (thor-1.0.1-spec.txz) = 5c542a3fa280c0e5de68e0e490ececd3bdfb72822fec571494c0b0c89221fe9410e70829b5175548a5767df7dc4b241d4f508328b00bca014c1d7eb67b794a9d`
		`+ SHA512 (thor-1.1.0.gem) = 98e96ad70f8452e590b7c5266c495f4fbe11af2ce38aa2b3295da8cffe4bba7d660fab4faf604011cc4774ee77451d32002c43c74f3c422e1ed50866f7bcd927`
		`+ SHA512 (thor-1.1.0-spec.txz) = 8ae3877da1108c4d291c9025c824560bc9ed2ff7618ffbcc3f0622793ebeb4ba434692a2c3138b28058bf65fb8396d946243b84ce255b72d3165630c4de3e6d9`

ignatenkobrain commented 3 years ago

Signed-off-by: Igor Raits ignatenkobrain@fedoraproject.org

pvalena commented on line 3 of rubygem-thor.spec 3 years ago

This line shouldn't be chaged.

pvalena commented on line 32 of rubygem-thor.spec 3 years ago

This seems to me like a step back IMO.

pvalena commented 3 years ago

Was this created by some automation, was it tested somehow? (Not just the CI build.) Are reverse dependencies solved? rpmlint?

I'm not trying to unappreciate the effort, I'm just trying to find out where this came from?

FYI: I have an automation in place, doing exactly this :) with the addion of testing. It is halted for a little bit, because of some .gitignore change I need to do.

Edited 3 years ago by pvalena

pvalena commented 3 years ago

See this PR for comparison: https://src.fedoraproject.org/rpms/rubygem-thor/pull-request/3

ignatenkobrain commented on line 3 of rubygem-thor.spec 3 years ago

why not? I mean, it is obsolete and we can even remove it

ignatenkobrain commented on line 32 of rubygem-thor.spec 3 years ago

well, if you build in different %{_prefix} (e.g. flatpak build) then your package will fail to build.

ignatenkobrain commented 3 years ago

Was this created by some automation, was it tested somehow? (Not just the CI build.) Are reverse dependencies solved? rpmlint?

yes, I checked reverse dependencies via https://gist.github.com/ignatenkobrain/a2b21a4db497a2a4b441e3957fcc8483. and that it builds, nothing more.

vondruch commented on line 32 of rubygem-thor.spec 3 years ago

As long as there is no upstream RPM support neither Fedora guideline, then I prefer to have %{_bindir}. What is the right value for flatpak is questionable anyway.

pvalena commented 3 years ago

Was this created by some automation, was it tested somehow? (Not just the CI build.) Are reverse dependencies solved? rpmlint?

yes, I checked reverse dependencies via https://gist.github.com/ignatenkobrain/a2b21a4db497a2a4b441e3957fcc8483. and that it builds, nothing more.

Great!

Looks good, can I use it for my tooling? Do you intend to keep some git / maintain it in more collaborative way?

pvalena commented 3 years ago

why not? I mean, it is obsolete and we can even remove it

It's informative (we don't want to remove it, it points to version from which the .spec was generated), and as it's just a comment, there's no point in updating, therefore the more conservative approach seems preferential to me.

pvalena commented 3 years ago

Closing in favor of https://src.fedoraproject.org/rpms/rubygem-thor/pull-request/3.