#1 Update to XPath 3.0.0.
Merged 5 years ago by pvalena. Opened 5 years ago by pvalena.
rpms/ pvalena/rubygem-xpath rebase  into  master

file modified
+1 -2
@@ -1,2 +1,1 @@ 

- /xpath-0.1.4.gem

- /xpath-2.0.0.gem

+ /xpath-*.gem

I think this is good try.

file modified
+10 -16
@@ -3,26 +3,19 @@ 

  

  Summary: Generate XPath expressions from Ruby

  Name: rubygem-%{gem_name}

- Version: 2.0.0

- Release: 7%{?dist}

- Group: Development/Languages

+ Version: 3.0.0

+ Release: 1%{?dist}

  License: MIT

- URL: http://github.com/jnicklas/xpath

+ URL: https://github.com/teamcapybara/xpath

  Source0: http://rubygems.org/gems/%{gem_name}-%{version}.gem

- # Fix test suite in RSpec 3.

- # https://github.com/jnicklas/xpath/pull/74.patch

- Patch0: rubygem-xpath-2.0.0-fix-test-for-rspec-3.patch

  Requires: ruby(release)

  Requires: ruby(rubygems)

- Requires: rubygem(nokogiri) >= 1.3

- Requires: rubygem(nokogiri) < 2

  BuildRequires: ruby(release)

  BuildRequires: rubygems-devel

  BuildRequires: rubygem(rspec-core)

  BuildRequires: rubygem(rspec-mocks)

  BuildRequires: rubygem(rspec-expectations)

- BuildRequires: rubygem(nokogiri) >= 1.3

- BuildRequires: rubygem(nokogiri) < 2

+ BuildRequires: rubygem(nokogiri)

  BuildArch: noarch

  

  %description
@@ -31,7 +24,6 @@ 

  

  %package doc

  Summary: Documentation for %{name}

- Group: Documentation

  Requires: %{name} = %{version}-%{release}

  BuildArch: noarch

  
@@ -51,9 +43,8 @@ 

  

  %check

  pushd .%{gem_instdir}

- # kill bundler

- sed -i '2d' spec/spec_helper.rb

- patch -p1 < %{PATCH0}

+ sed -i "/^require 'pry'$/ s/^/#/" spec/spec_helper.rb

+ 

  rspec -Ilib spec

  popd

  
@@ -61,7 +52,7 @@ 

  %dir %{gem_instdir}

  %doc %{gem_instdir}/README.md

  %{gem_libdir}

- %{gem_cache}

+ %exclude %{gem_cache}

  %{gem_spec}

  

  %files doc
@@ -70,6 +61,9 @@ 

  

  

  %changelog

+ * Mon May 14 2018 Pavel Valena <pvalena@redhat.com> - 3.0.0-1

+ - Update to XPath 3.0.0.

+ 

  * Fri Feb 09 2018 Fedora Release Engineering <releng@fedoraproject.org> - 2.0.0-7

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild

  

file modified
+1 -1
@@ -1,1 +1,1 @@ 

- ee492d351f9f2f462bd9921b94bc7435  xpath-2.0.0.gem

+ SHA512 (xpath-3.0.0.gem) = fd1e8cfff11e8c14efb1ad2cabb9a0a3bc3d79d40b61264c524ff4524c5e7b9ff86de0746f4530fe7501f5e5e1683cb87c4a479f5e67deb7d8f93ed552ec78d6

Basically it looks good.

  • No update for License information?
  • How about the dependency RPM packages of the rubygem-xpath? All the packages are fine for that?

I think this is good try.

2 new commits added

  • Enhance .spec and .gitignore files.
  • Update to XPath 3.0.0.
5 years ago

I've made the following change:

-BuildRequires: (rubygem(nokogiri) >= 1.8 with rubygem(nokogiri) < 2)
+BuildRequires: rubygem(nokogiri)

as I reallized there's no need for versioned BuildRequires in this case.

I think this is good try.

Thanks. I'm using it in numerous packages now.

No update for License information?

No change. I've done all the necessary checks.

How about the dependency RPM packages of the rubygem-xpath? All the packages are fine for that?

Actually, this is part of requirements of ongoing RoR rebase. Other developers are responsible for fixing dependent packages.

Other developers: Update Rails dependent packages to be working with Ruby on Rails 5.2

https://fedoraproject.org/wiki/Changes/Ruby_on_Rails_5.2


Just to be sure, dependencies are:

rubygem-capybara-0:2.14.3-4.fc29
rubygem-xpath-doc-0:2.0.0-7.fc28



And XPath rebase is needed to make updated Capybara work:
https://src.fedoraproject.org/rpms/rubygem-capybara/pull-request/1

Pull-Request has been merged by pvalena

5 years ago