#1 Update to 0.7.1
Merged 2 months ago by ignatenkobrain. Opened 2 months ago by rfairley.
rpms/ rfairley/rust-env_logger rfairley-0.7.0  into  master

file modified
+1

@@ -16,3 +16,4 @@ 

  /env_logger-0.6.0.crate

  /env_logger-0.6.1.crate

  /env_logger-0.6.2.crate

+ /env_logger-0.7.1.crate

file modified
+4 -1

@@ -5,7 +5,7 @@ 

  %global crate env_logger

  

  Name:           rust-%{crate}

- Version:        0.6.2

+ Version:        0.7.1

  Release:        1%{?dist}

  Summary:        Logging implementation for `log` which is configured via environment variable

  

@@ -120,6 +120,9 @@ 

  %endif

  

  %changelog

+ * Sun Oct 20 2019 Robert Fairley <rfairley@redhat.com> - 0.7.1-1

+ - Update to 0.7.1

+ 

  * Sun Aug 18 16:13:12 CEST 2019 Igor Gnatenko <ignatenkobrain@fedoraproject.org> - 0.6.2-1

  - Update to 0.6.2

  

file modified
+1 -1

@@ -1,1 +1,1 @@ 

- SHA512 (env_logger-0.6.2.crate) = ec90dc0cee99a743d4cdc772fa66a9c4e81793e452000bc1432fb47436b62c6a02c36c40ea48550db493df65c4eb37e8a6d6d3b4011f00648294d745a200dafa

+ SHA512 (env_logger-0.7.1.crate) = 604060d2ee83ab337a2d20d6784d1b7541534d2fd9e1662fc5c709fa681672a9db5e34d00face864b56ae321962e644ebe29fbb6d68a0d556419cf5d71c6149f

Signed-off-by: Robert Fairley rfairley@redhat.com


Needed in order to update Zincati to 0.0.6 (see https://bugzilla.redhat.com/show_bug.cgi?id=1759996#c1).

Ran through a test build locally - succeeded up to error: 29 files in the working directory contain changes that were not yet committed into git, with fedpkg local; this should be OK to build in Koji.

Requires fedpkg new-sources env_logger-0.7.1.crate, before building in Koji.

==========================================================================rust-env_logger-0.6.2-1.fc32.src==========================================================================
PACKAGE                                            DEPENDENT                                             DEPENDENCIES
rust-env_logger+atty-devel-0.6.2-1.fc32.noarch                                                           
rust-env_logger+default-devel-0.6.2-1.fc32.noarch  rust-bindgen+env_logger-devel-0.51.0-1.fc31.noarch    (crate(env_logger/default) >= 0.6.0 with crate(env_logger/default) < 0.7.0)
                                                   rust-bindgen+logging-devel-0.51.0-1.fc31.noarch       (crate(env_logger/default) >= 0.6.0 with crate(env_logger/default) < 0.7.0)
                                                   rust-cargo-devel-0.36.0-2.fc31.noarch                 (crate(env_logger/default) >= 0.6.0 with crate(env_logger/default) < 0.7.0)
                                                   rust-pretty_env_logger-devel-0.3.1-1.fc32.noarch      (crate(env_logger/default) >= 0.6.2 with crate(env_logger/default) < 0.7.0)
                                                   rust-skim-devel-0.6.9-1.fc32.noarch                   (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-tokei-devel-10.0.1-2.fc31.noarch                 (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-actix-server-0.6.0-1.fc31.src                    (crate(env_logger/default) >= 0.6.0 with crate(env_logger/default) < 0.7.0)
                                                   rust-ammonia-3.0.0-1.fc32.src                         (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-askalono-0.3.0-4.fc31.src                        (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-askalono-cli-0.3.0-3.fc31.src                    (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-bindgen-0.51.0-1.fc31.src                        (crate(env_logger/default) >= 0.6.0 with crate(env_logger/default) < 0.7.0)
                                                   rust-cargo-0.36.0-2.fc31.src                          (crate(env_logger/default) >= 0.6.0 with crate(env_logger/default) < 0.7.0)
                                                   rust-exa-0.9.0-3.fc31.src                             (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-fedora-coreos-pinger-0.0.4-2.fc31.src            (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-handlebars-1.1.0-2.fc31.src                      (crate(env_logger/default) >= 0.6.0 with crate(env_logger/default) < 0.7.0)
                                                   rust-pretty_env_logger-0.3.1-1.fc32.src               (crate(env_logger/default) >= 0.6.2 with crate(env_logger/default) < 0.7.0)
                                                   rust-skim-0.6.9-1.fc32.src                            (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-tokei-10.0.1-2.fc31.src                          (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-trust-dns-proto-0.7.4-4.fc31.src                 (crate(env_logger/default) >= 0.6.0 with crate(env_logger/default) < 0.7.0)
                                                   rust-tuikit-0.2.9-1.fc32.src                          (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-tungstenite-0.8.1-2.fc31.src                     (crate(env_logger/default) >= 0.6.1 with crate(env_logger/default) < 0.7.0)
                                                   rust-zincati-0.0.5-1.fc32.src                         (crate(env_logger/default) >= 0.6.2 with crate(env_logger/default) < 0.7.0)
rust-env_logger+humantime-devel-0.6.2-1.fc32.noarch

rust-env_logger+regex-devel-0.6.2-1.fc32.noarch    rust-quickcheck+regex-devel-0.9.0-1.fc32.noarch       (crate(env_logger/regex) >= 0.6.0 with crate(env_logger/regex) < 0.7.0)
                                                   rust-quickcheck-0.9.0-1.fc32.src                      (crate(env_logger/regex) >= 0.6.0 with crate(env_logger/regex) < 0.7.0)
rust-env_logger+termcolor-devel-0.6.2-1.fc32.noarch

rust-env_logger-devel-0.6.2-1.fc32.noarch          rust-quickcheck+env_logger-devel-0.9.0-1.fc32.noarch  (crate(env_logger) >= 0.6.0 with crate(env_logger) < 0.7.0)
                                                   rust-quickcheck+use_logging-devel-0.9.0-1.fc32.noarch (crate(env_logger) >= 0.6.0 with crate(env_logger) < 0.7.0)
                                                   rust-quickcheck-0.9.0-1.fc32.src                      (crate(env_logger) >= 0.6.0 with crate(env_logger) < 0.7.0)

what about packages which depend on 0.6.x? should we create compat package?

what about packages which depend on 0.6.x? should we create compat package?

Right, I should have considered this before. Yes, a compat package should be created first (similar to rust-env_logger0.5 would work well https://koji.fedoraproject.org/koji/packageinfo?packageID=27953).

Opened a review request for a compat package: https://bugzilla.redhat.com/show_bug.cgi?id=1762408

Would changes need to be made to the packages dependent on 0.6.x to use the new compat package, or is this handled with dynamic BuildRequires?

what about packages which depend on 0.6.x? should we create compat package?

Right, I should have considered this before. Yes, a compat package should be created first (similar to rust-env_logger0.5 would work well https://koji.fedoraproject.org/koji/packageinfo?packageID=27953).

Is a compat package needed? Have you tried bumping the dependent packages? The changelog doesn't mention breaking changes.

what about packages which depend on 0.6.x? should we create compat package?

Right, I should have considered this before. Yes, a compat package should be created first (similar to rust-env_logger0.5 would work well https://koji.fedoraproject.org/koji/packageinfo?packageID=27953).

Is a compat package needed? Have you tried bumping the dependent packages? The changelog doesn't mention breaking changes.

I haven't tried bumping the dependent packages that are currently using env_logger 0.6.x to use 0.7.x - it looks like that would work. I guess the min Rust version bump to 1.31.0 was considered a breaking change in the env_logger 0.7.0 changelog? Scanning over https://github.com/rust-lang/rust/blob/master/RELEASES.md it doesn't look like bumping the Rust version introduced breaking changes.

EDIT: "I guess the min Rust version bump to 1.31.0 was considered a breaking change in the env_logger 0.7.0 changelog?" - just looked at the semver spec https://semver.org/ and bumping the minor version makes sense. I had thought initially that bumping the minor number had introduced backwards-incompatible changes. Understood that there should be no problem with bumping the dependent packages.

An alternative for now which will work fine is to patch rust-zincati to use the 0.6.2 env_logger API - since this is all that the Zincati upstream is using from the 0.7.0 version https://github.com/coreos/zincati/pull/144/commits/a728c9914b5721d98caee74a40c2b82fba3b77db. I'll try this for the rust-zincati package now.

We need to update to 0.7.0 anyhow, let me work on the dependencies this week-end and I'll report back to you.

Could you bump your PR to 0.7.1 which was release on the 17th?

rebased onto 47cec68

2 months ago

rebased onto bed2a85

2 months ago

rebased onto bed2a85

Fixed the date in the specfile changelog in this - should be good now.

I'll handle all this stuff today.

Pull-Request has been merged by ignatenkobrain

2 months ago