PR#1: Skip tests that fail on riscv64 - rpms/rust-shared_library

rpms / rust-shared_library

#1 Skip tests that fail on riscv64

Opened a month ago by jasenchao. Modified 8 days ago

https://github.com/fedora-riscv/rust-shared_library.git rawhide into rawhide

Skip tests that fail on riscv64

Jasen Chao • 15 days ago

5917fb6

rust-shared_library.spec

file modified

+2 -2

		`@@ -62,8 +62,8 @@`

		`%if %{with check}`
		`%check`
		`- %ifarch aarch64 ppc64le`
		`- # * skip tests that fail on aarch64 and ppc64le:`
		`+ %ifarch aarch64 ppc64le riscv64`
		`+ # * skip tests that fail on aarch64, ppc64le and riscv64:`
		`# https://github.com/tomaka/shared_library/issues/17`
		`%cargo_test -- -- --skip test_loading_cosine`
		`%else`

no initial comment

jasenchao commented a month ago

Built success in https://openkoji.iscas.ac.cn/koji/taskinfo?taskID=1352

decathorpe commented 16 days ago

It's not "fixing" test error on riscv64, it's adding riscv64 to the list of architectures where tests are not run at all.

And you didn't update the comment one line below (or added a comment at the upstream issue to add that the test also fails on riscv64).

rebased onto 5917fb6

15 days ago

jasenchao commented 15 days ago

It's not "fixing" test error on riscv64, it's adding riscv64 to the list of architectures where tests are not run at all.

And you didn't update the comment one line below (or added a comment at the upstream issue to add that the test also fails on riscv64).

Thanks for your comment, I have modified accordingly.

decathorpe commented 8 days ago

Thank you, looks good to me now!

I'll merge and build this for Rawhide, do you need a build for other branches of Fedora too?