PR#2: Install binary under /usr/libexec - rpms/rust-zincati

rpms / rust-zincati

#2 Install binary under /usr/libexec

Closed 4 years ago by rfairley. Opened 4 years ago by rfairley.

rpms/ rfairley/rust-zincati rfairley-libexec into master

Install binary under /usr/libexec

rfairley • 4 years ago

4f4b588

rust-zincati.spec

file modified

+8 -2

		`@@ -5,7 +5,7 @@`
		`%global crate zincati`

		`Name: rust-%{crate}`
		`- Version: 0.0.4`
		`+ Version: 0.0.5`
		`Release: 1%{?dist}`
		`Summary: Update agent for Fedora CoreOS`

		`@@ -34,7 +34,7 @@`
		`%description -n %{crate} %{_description}`

		`%files -n %{crate}`
		`- %{_bindir}/zincati`
		`+ %{_libexecdir}/zincati`
		`%doc README.md`
		`%license COPYRIGHT LICENSE`
		`%dir %{_prefix}/lib/%{crate}`
		`@@ -77,6 +77,9 @@`

		`%install`
		`%cargo_install`
		+ # `zincati` should not be executed directly by users.
jlebon commented 4 years ago Maybe let's link to https://github.com/coreos/fedora-coreos-tracker/issues/244 here? It also explains why we have to do this with `mv` manually after the fact.
		`+ mkdir -p %{buildroot}%{_libexecdir}`
		`+ mv %{buildroot}%{_bindir}/zincati %{buildroot}%{_libexecdir}/zincati`
		`install -Dpm0644 -t %{buildroot}%{_prefix}/lib/%{crate}/config.d \`
		`dist/config.d/*.toml`
		`mkdir -p %{buildroot}/run/%{crate}/config.d`
		`@@ -97,6 +100,9 @@`
		`%endif`

		`%changelog`
		`+ * Thu Aug 15 2019 Robert Fairley <rfairley@redhat.com> - 0.0.5-1`
		`+ - Install binary under /usr/libexec`
		`+`
		`* Fri Aug 02 2019 Robert Fairley <rfairley@redhat.com> - 0.0.4-1`
		`- Update to 0.0.4`

rfairley commented 4 years ago

See: https://github.com/coreos/fedora-coreos-tracker/issues/244

Signed-off-by: Robert Fairley rfairley@redhat.com

Holding for now - requires: https://github.com/coreos/zincati/pull/103

rebased onto 4f4b588

4 years ago

rfairley commented 4 years ago

Will include this change in the update for the next upstream release.

jlebon commented on line 23 of rust-zincati.spec 4 years ago

Maybe let's link to https://github.com/coreos/fedora-coreos-tracker/issues/244 here? It also explains why we have to do this with mv manually after the fact.

jlebon commented 4 years ago

LGTM, just one optional comment!

rfairley commented 4 years ago

Maybe let's link to https://github.com/coreos/fedora-coreos-tracker/issues/244 here? It also explains why we have to do this with mv manually after the fact.

Thanks! Added this in with https://src.fedoraproject.org/rpms/rust-zincati/c/791bd6bd3a0a5f829f8754271f817aa45461da10?branch=master.

Pull-Request has been closed by rfairley

4 years ago