Blame singularity-Make-syslog-call-format-safe.patch
|
 |
57c4797 |
From c8dfa956e1732bd73ae44721ec5092b56740bcf5 Mon Sep 17 00:00:00 2001
|
|
|
57c4797 |
From: Dave Love <dave.love@manchester.ac.uk>
|
|
|
57c4797 |
Date: Sun, 14 May 2017 16:44:59 +0100
|
|
|
57c4797 |
Subject: [PATCH 02/30] Make syslog call format safe
|
|
|
57c4797 |
|
|
|
57c4797 |
---
|
|
|
57c4797 |
src/lib/message.c | 5 +----
|
|
|
57c4797 |
1 file changed, 1 insertion(+), 4 deletions(-)
|
|
|
57c4797 |
|
|
|
57c4797 |
diff --git a/src/lib/message.c b/src/lib/message.c
|
|
|
57c4797 |
index 8d010cc8..dbaba509 100644
|
|
|
57c4797 |
--- a/src/lib/message.c
|
|
|
57c4797 |
+++ b/src/lib/message.c
|
|
|
57c4797 |
@@ -102,10 +102,7 @@ void _singularity_message(int level, const char *function, const char *file, int
|
|
|
57c4797 |
}
|
|
|
57c4797 |
|
|
|
57c4797 |
if ( level <= LOG ) {
|
|
|
57c4797 |
- char syslog_string[540]; // Flawfinder: ignore (512 max message length + 28'ish chars for header)
|
|
|
57c4797 |
- snprintf(syslog_string, 540, "%s (U=%d,P=%d)> %s", __progname, geteuid(), getpid(), message); // Flawfinder: ignore
|
|
|
57c4797 |
-
|
|
|
57c4797 |
- syslog(syslog_level, syslog_string, strlength(syslog_string, 1024)); // Flawfinder: ignore (format is internally defined)
|
|
|
57c4797 |
+ syslog(syslog_level, "%s (U=%d,P=%d)> %s", __progname, geteuid(), getpid(), message);
|
|
|
57c4797 |
}
|
|
|
57c4797 |
|
|
|
57c4797 |
if ( level <= messagelevel ) {
|
|
|
57c4797 |
--
|
|
|
57c4797 |
2.11.0
|
|
|
57c4797 |
|