#5 Remove unused config variable, and reapply lost patch
Opened 3 months ago by ferdnyc. Modified 3 months ago
rpms/ ferdnyc/smartmontools no-config-gen  into  rawhide

file modified
+6 -1
@@ -7,7 +7,7 @@ 

  Summary:	Tools for monitoring SMART capable hard disks

  Name:		smartmontools

  Version:	7.3

- Release:	2%{?dist}

+ Release:	3%{?dist}

  Epoch:		1

  License:	GPLv2+

  URL:		http://smartmontools.sourceforge.net/
@@ -161,6 +161,11 @@ 

  %ghost %{_sharedstatedir}/selinux/%{selinuxtype}/active/modules/200/%{modulename}

  

  %changelog

+ * Sun May 01 2022 FeRD (Frank Dana) <ferdnyc@gmail.com> - 1:7.3-3

+ - Drop smartd_conf_opts setting from sysconfig file, config hasn't

+   been autogenerated since 2008.

+ - Reapply "Add trailing slash to persistence prefix"

+ 

  * Wed Mar 09 2022 Michal Hlavinka <mhlavink@redhat.com> - 1:7.3-2

  - use --capabilities=mail for exim mail notification (#2060526)

  

file modified
+1 -3
@@ -1,6 +1,4 @@ 

  # command line options for smartd

- # Add -s /var/lib/smartmontools to enable state persistence

+ # Add -s /var/lib/smartmontools/ to enable state persistence

  smartd_opts="-q never --capabilities=mail"

  

- # autogenerated config file options

- # smartd_conf_opts="-H -m root"

The feature to autogenerate the smartd.conf file was removed in commit e97b2bc, applied on 2008-05-12. Since then, the smartd_conf_opts setting in /etc/sysconfig/smartmontools has done nothing, as the config file is no longer autogenerated. This PR removes the useless setting from the sysconfig file.

It also reapplies my patch from 97d20d6, which WAS merged as PR #4, but got subsequently overridden.