diff --git a/snap-mgmt.sh b/snap-mgmt.sh index 7119527..0ccf0f3 100644 --- a/snap-mgmt.sh +++ b/snap-mgmt.sh @@ -8,7 +8,7 @@ set -e SNAP_MOUNT_DIR="/var/lib/snapd/snap" -SNAP_UNIT_PREFIX=$(systemd-escape -p ${SNAP_MOUNT_DIR}) +SNAP_UNIT_PREFIX="$(systemd-escape -p ${SNAP_MOUNT_DIR})" systemctl_stop() { unit="$1" @@ -21,7 +21,7 @@ systemctl_stop() { if [ "$1" = "purge" ]; then # undo any bind mount to ${SNAP_MOUNT_DIR} that resulted from LP:#1668659 if grep -q "${SNAP_MOUNT_DIR} ${SNAP_MOUNT_DIR}" /proc/self/mountinfo; then - umount -l ${SNAP_MOUNT_DIR} || true + umount -l "${SNAP_MOUNT_DIR}" || true fi mounts=$(systemctl list-unit-files --full | grep "^${SNAP_UNIT_PREFIX}[-.].*\.mount" | cut -f1 -d ' ') @@ -43,9 +43,9 @@ if [ "$1" = "purge" ]; then if [ -n "$snap" ]; then echo "Removing snap $snap" # aliases - if [ -d ${SNAP_MOUNT_DIR}/bin ]; then - find ${SNAP_MOUNT_DIR}/bin -maxdepth 1 -lname "$snap" -delete - find ${SNAP_MOUNT_DIR}/bin -maxdepth 1 -lname "$snap.*" -delete + if [ -d "${SNAP_MOUNT_DIR}/bin" ]; then + find "${SNAP_MOUNT_DIR}/bin" -maxdepth 1 -lname "$snap" -delete + find "${SNAP_MOUNT_DIR}/bin" -maxdepth 1 -lname "$snap.*" -delete fi # generated binaries rm -f "${SNAP_MOUNT_DIR}/bin/$snap" @@ -61,7 +61,7 @@ if [ "$1" = "purge" ]; then # opportunistic remove (may fail if there are still revisions left) for d in "${SNAP_MOUNT_DIR}/$snap" "/var/snap/$snap"; do if [ -d "$d" ]; then - rmdir --ignore-fail-on-non-empty $d + rmdir --ignore-fail-on-non-empty "$d" fi done fi @@ -83,7 +83,7 @@ if [ "$1" = "purge" ]; then rm -rf /var/lib/snapd/snaps/* echo "Final directory cleanup" - rm -rf ${SNAP_MOUNT_DIR}/* + rm -rf "${SNAP_MOUNT_DIR}"/* rm -rf /var/snap/* echo "Removing leftover snap shared state data"