#1 Install SnappyConfig.cmake in default location
Closed 4 years ago by mgieseki. Opened 5 years ago by xhochy.
rpms/ xhochy/snappy fix-1679727  into  master

file modified
+4 -3
@@ -1,6 +1,6 @@ 

  Name:           snappy

  Version:        1.1.7

- Release:        7%{?dist}

+ Release:        8%{?dist}

  Summary:        Fast compression and decompression library

  

  License:        BSD
@@ -65,8 +65,6 @@ 

  chmod 644 *.txt AUTHORS COPYING NEWS README.md

  %make_install

  install -m644 -D snappy.pc %{buildroot}%{_libdir}/pkgconfig/snappy.pc

- mkdir -p %{buildroot}%{_datadir}/cmake/Modules/

- mv %{buildroot}%{_libdir}/cmake/Snappy/*cmake %{buildroot}%{_datadir}/cmake/Modules/

  rm -rf %{buildroot}%{_datadir}/doc/snappy/

  rm -rf %{buildroot}%{_datadir}/doc/snappy-devel/

  
@@ -93,6 +91,9 @@ 

  * Sun Feb 03 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1.1.7-7

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild

  

+ * Thu Feb 21 2019 Uwe L. Korn <fedora@uwekorn.com> - 1.1.7-8

+ - Install SnappyConfig.cmake in default location

+ 

  * Sat Jul 14 2018 Fedora Release Engineering <releng@fedoraproject.org> - 1.1.7-6

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild

  

This will support find_package(Snappy) out of the box in CMake.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1679727

This is my first contribution to Fedora packaging, so please be extra careful.

Thanks for pointing out the issue. You need to adapt the entry in the %files section as well, though. It should look like this:

%{_libdir}/cmake/Snappy/

Otherwise, rpmbuild reports an error that the four cmake files are installed but not packaged.

Also, please move your changelog entry to the top of the %changelog list. ;-)

Metadata Update from @mgieseki:
- Request assigned

5 years ago

Pull-Request has been closed by mgieseki

4 years ago
Metadata