Blob Blame Raw
From 99a2628b0ff04e0aadd130e45aa2598c4df64690 Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@verbum.org>
Date: Tue, 11 Jun 2013 15:21:13 -0400
Subject: [linux-vdagent PATCH 04/12] Not having the virtio channel is not an
 error; instead silently do nothing

Fedora for example bundles the SPICE agent by default; however, we
don't want to spew an error when running non-virtualized, or with
plain VNC.

Let's just silently exit; while we could change LOG_ERR -> LOG_INFO
or something, that's still pointless noise in most people's syslog.

Someone who was debugging a misconfigured SPICE setup would pretty
quickly notice that they were missing the virtio port.

(This patch is part of a larger initiative to reduce error
 spew on default startup in common deployment scenarios such as
 KVM+VNC.)

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 src/vdagent.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/vdagent.c b/src/vdagent.c
index 9e238d3..10ebf6e 100644
--- a/src/vdagent.c
+++ b/src/vdagent.c
@@ -226,9 +226,7 @@ int main(int argc, char *argv[])
             LOG_USER);
 
     if (file_test(portdev) != 0) {
-        syslog(LOG_ERR, "Missing virtio device '%s': %s",
-                portdev, strerror(errno));
-        return 1;
+        return 0;
     }
 
     if (do_daemonize)
-- 
1.8.3.1