4e47864
From 101934f29e6b76931b1499adc19ae7f7a976789d Mon Sep 17 00:00:00 2001
4e47864
From: Lukas Slebodnik <lslebodn@redhat.com>
4e47864
Date: Tue, 14 Aug 2018 08:20:57 +0000
4e47864
Subject: [PATCH 1/4] BUILD: Fix issue with installation of libsss_secrets
4e47864
MIME-Version: 1.0
4e47864
Content-Type: text/plain; charset=UTF-8
4e47864
Content-Transfer-Encoding: 8bit
4e47864
4e47864
libsss_secret.so is linked with libsss_util.so therefore it shoudl be
4e47864
added into pkglib_LTLIBRARIES after libsss_util.so.
4e47864
Otherwise there can failure in linking phase.
4e47864
4e47864
libtool: warning: relinking 'libsss_secrets.la'
4e47864
libtool: install: (cd /home/build/sssd/ci-build-debug/intg/bld; /bin/sh
4e47864
  "/home/build/sssd/ci-build-debug/intg/bld/libtool"  --tag CC
4e47864
  --mode=relink gcc -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith
4e47864
  -Wcast-qual -Wcast-align -Wwrite-strings -Wundef
4e47864
  -Werror-implicit-function-declaration -Winit-self -Wmissing-include-dirs
4e47864
  -fno-strict-aliasing -std=gnu99 -O2 -g -g3 -O2 -Werror
4e47864
  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
4e47864
  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
4e47864
  -avoid-version -o libsss_secrets.la -rpath
4e47864
  /tmp/sssd-intg.l7nl5pgb/lib/sssd
4e47864
  src/util/secrets/libsss_secrets_la-secrets.lo
4e47864
  src/util/secrets/libsss_secrets_la-config.lo -ltalloc -lldb
4e47864
  libsss_crypt.la libsss_debug.la libsss_util.la )
4e47864
libtool: relink: gcc -shared  -fPIC -DPIC
4e47864
  src/util/secrets/.libs/libsss_secrets_la-secrets.o
4e47864
  src/util/secrets/.libs/libsss_secrets_la-config.o   -Wl,-rpath
4e47864
  -Wl,/tmp/sssd-intg.l7nl5pgb/lib/sssd -ltalloc -lldb
4e47864
  -L/tmp/sssd-intg.l7nl5pgb/lib/sssd -lsss_crypt -lsss_debug -lsss_util
4e47864
  -O2 -g -g3 -O2   -Wl,-soname -Wl,libsss_secrets.so -o
4e47864
  .libs/libsss_secrets.so
4e47864
/usr/bin/ld: cannot find -lsss_util
4e47864
collect2: error: ld returned 1 exit status
4e47864
libtool:   error: error: relink 'libsss_secrets.la' with the above
4e47864
command before installing it
4e47864
4e47864
Merges: https://pagure.io/SSSD/sssd/pull-request/3808
4e47864
4e47864
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
4e47864
---
4e47864
 Makefile.am | 43 +++++++++++++++++++++----------------------
4e47864
 1 file changed, 21 insertions(+), 22 deletions(-)
4e47864
4e47864
diff --git a/Makefile.am b/Makefile.am
4e47864
index d313957..a2d8ea4 100644
4e47864
--- a/Makefile.am
4e47864
+++ b/Makefile.am
4e47864
@@ -1209,28 +1209,6 @@ libsss_iface_sync_la_LDFLAGS = \
4e47864
     -avoid-version \
4e47864
     $(NULL)
4e47864
 
4e47864
-if BUILD_WITH_LIBSECRET
4e47864
-pkglib_LTLIBRARIES += libsss_secrets.la
4e47864
-
4e47864
-libsss_secrets_la_SOURCES = \
4e47864
-    src/util/secrets/secrets.c \
4e47864
-    src/util/secrets/config.c \
4e47864
-    $(NULL)
4e47864
-libsss_secrets_la_CFLAGS = \
4e47864
-    $(AM_CFLAGS) \
4e47864
-    $(NULL)
4e47864
-libsss_secrets_la_LIBADD = \
4e47864
-    $(TALLOC_LIBS) \
4e47864
-    $(LDB_LIBS) \
4e47864
-    libsss_crypt.la \
4e47864
-    libsss_debug.la \
4e47864
-    libsss_util.la \
4e47864
-    $(NULL)
4e47864
-libsss_secrets_la_LDFLAGS = \
4e47864
-    -avoid-version \
4e47864
-    $(NULL)
4e47864
-endif
4e47864
-
4e47864
 pkglib_LTLIBRARIES += libsss_util.la
4e47864
 libsss_util_la_SOURCES = \
4e47864
     src/confdb/confdb.c \
4e47864
@@ -1314,6 +1292,27 @@ libsss_util_la_LIBADD += stap_generated_probes.lo
4e47864
 endif
4e47864
 libsss_util_la_LDFLAGS = -avoid-version
4e47864
 
4e47864
+if BUILD_WITH_LIBSECRET
4e47864
+pkglib_LTLIBRARIES += libsss_secrets.la
4e47864
+libsss_secrets_la_SOURCES = \
4e47864
+    src/util/secrets/secrets.c \
4e47864
+    src/util/secrets/config.c \
4e47864
+    $(NULL)
4e47864
+libsss_secrets_la_CFLAGS = \
4e47864
+    $(AM_CFLAGS) \
4e47864
+    $(NULL)
4e47864
+libsss_secrets_la_LIBADD = \
4e47864
+    $(TALLOC_LIBS) \
4e47864
+    $(LDB_LIBS) \
4e47864
+    libsss_crypt.la \
4e47864
+    libsss_debug.la \
4e47864
+    libsss_util.la \
4e47864
+    $(NULL)
4e47864
+libsss_secrets_la_LDFLAGS = \
4e47864
+    -avoid-version \
4e47864
+    $(NULL)
4e47864
+endif
4e47864
+
4e47864
 pkglib_LTLIBRARIES += libsss_semanage.la
4e47864
 libsss_semanage_la_CFLAGS = \
4e47864
     $(AM_CFLAGS) \
4e47864
-- 
4e47864
2.9.5
4e47864