Blame 0019-util-consider-0x7F-a-control-chracter-which-it-is-DE.patch
|
 |
43ff24c |
From a71b7b7e52f312c7a9fc19154ac0d444e057e1d4 Mon Sep 17 00:00:00 2001
|
|
|
43ff24c |
From: Lennart Poettering <lennart@poettering.net>
|
|
|
43ff24c |
Date: Mon, 7 Jul 2014 11:47:10 +0200
|
|
|
43ff24c |
Subject: [PATCH] util: consider 0x7F a control chracter (which it is: DEL)
|
|
|
43ff24c |
|
|
|
43ff24c |
Let's better be safe than sorry.
|
|
|
43ff24c |
|
|
|
43ff24c |
(cherry picked from commit 3a8a916338d8446b938f3cf40f6aae0c611892e3)
|
|
|
43ff24c |
---
|
|
|
43ff24c |
src/shared/util.c | 12 ++++++++++--
|
|
|
43ff24c |
1 file changed, 10 insertions(+), 2 deletions(-)
|
|
|
43ff24c |
|
|
|
43ff24c |
diff --git a/src/shared/util.c b/src/shared/util.c
|
|
|
43ff24c |
index 3d875c72b3..d25ee6652f 100644
|
|
|
43ff24c |
--- a/src/shared/util.c
|
|
|
43ff24c |
+++ b/src/shared/util.c
|
|
|
43ff24c |
@@ -1608,8 +1608,9 @@ int read_one_char(FILE *f, char *ret, usec_t t, bool *need_nl) {
|
|
|
43ff24c |
return -ETIMEDOUT;
|
|
|
43ff24c |
}
|
|
|
43ff24c |
|
|
|
43ff24c |
+ errno = 0;
|
|
|
43ff24c |
if (!fgets(line, sizeof(line), f))
|
|
|
43ff24c |
- return -EIO;
|
|
|
43ff24c |
+ return errno ? -errno : -EIO;
|
|
|
43ff24c |
|
|
|
43ff24c |
truncate_nl(line);
|
|
|
43ff24c |
|
|
|
43ff24c |
@@ -5355,6 +5356,9 @@ bool string_is_safe(const char *p) {
|
|
|
43ff24c |
if (*t > 0 && *t < ' ')
|
|
|
43ff24c |
return false;
|
|
|
43ff24c |
|
|
|
43ff24c |
+ if (*t == 127)
|
|
|
43ff24c |
+ return false;
|
|
|
43ff24c |
+
|
|
|
43ff24c |
if (strchr("\\\"\'", *t))
|
|
|
43ff24c |
return false;
|
|
|
43ff24c |
}
|
|
|
43ff24c |
@@ -5371,10 +5375,14 @@ bool string_has_cc(const char *p) {
|
|
|
43ff24c |
|
|
|
43ff24c |
assert(p);
|
|
|
43ff24c |
|
|
|
43ff24c |
- for (t = p; *t; t++)
|
|
|
43ff24c |
+ for (t = p; *t; t++) {
|
|
|
43ff24c |
if (*t > 0 && *t < ' ' && *t != '\t')
|
|
|
43ff24c |
return true;
|
|
|
43ff24c |
|
|
|
43ff24c |
+ if (*t == 127)
|
|
|
43ff24c |
+ return true;
|
|
|
43ff24c |
+ }
|
|
|
43ff24c |
+
|
|
|
43ff24c |
return false;
|
|
|
43ff24c |
}
|
|
|
43ff24c |
|