60ed16
From a814fa3f3a2067a17a6698d2fcb6230774d0f981 Mon Sep 17 00:00:00 2001
60ed16
From: Jan Synacek <jsynacek@redhat.com>
60ed16
Date: Fri, 2 Oct 2015 11:00:19 +0200
60ed16
Subject: [PATCH 06/12] import: hash URL in paths if they are too long
60ed16
60ed16
https://bugzilla.redhat.com/show_bug.cgi?id=1266775
60ed16
(cherry picked from commit 9818005de6cc6f525be8aa62a2b8593a7c72e798)
60ed16
60ed16
Resolves: #1266775
60ed16
---
60ed16
 src/import/pull-common.c | 44 ++++++++++++++++++++++++++++++++++++++------
60ed16
 1 file changed, 38 insertions(+), 6 deletions(-)
60ed16
60ed16
diff --git a/src/import/pull-common.c b/src/import/pull-common.c
60ed16
index 652277e..84611cb 100644
60ed16
--- a/src/import/pull-common.c
60ed16
+++ b/src/import/pull-common.c
60ed16
@@ -31,8 +31,10 @@
60ed16
 #include "pull-common.h"
60ed16
 #include "process-util.h"
60ed16
 #include "signal-util.h"
60ed16
+#include "siphash24.h"
60ed16
 
60ed16
 #define FILENAME_ESCAPE "/.#\"\'"
60ed16
+#define HASH_URL_THRESHOLD_LENGTH (_POSIX_PATH_MAX - 16)
60ed16
 
60ed16
 int pull_find_old_etags(const char *url, const char *image_root, int dt, const char *prefix, const char *suffix, char ***etags) {
60ed16
         _cleanup_free_ char *escaped_url = NULL;
60ed16
@@ -142,8 +144,21 @@ int pull_make_local_copy(const char *final, const char *image_root, const char *
60ed16
         return 0;
60ed16
 }
60ed16
 
60ed16
+static int hash_url(const char *url, char **ret) {
60ed16
+        uint64_t h;
60ed16
+        static const sd_id128_t k = SD_ID128_ARRAY(df,89,16,87,01,cc,42,30,98,ab,4a,19,a6,a5,63,4f);
60ed16
+
60ed16
+        assert(url);
60ed16
+
60ed16
+        siphash24((uint8_t *) &h, url, strlen(url), k.bytes);
60ed16
+        if (asprintf(ret, "%"PRIx64, h) < 0)
60ed16
+                return -ENOMEM;
60ed16
+
60ed16
+        return 0;
60ed16
+}
60ed16
+
60ed16
 int pull_make_path(const char *url, const char *etag, const char *image_root, const char *prefix, const char *suffix, char **ret) {
60ed16
-        _cleanup_free_ char *escaped_url = NULL;
60ed16
+        _cleanup_free_ char *escaped_url = NULL, *escaped_etag = NULL;
60ed16
         char *path;
60ed16
 
60ed16
         assert(url);
60ed16
@@ -157,18 +172,35 @@ int pull_make_path(const char *url, const char *etag, const char *image_root, co
60ed16
                 return -ENOMEM;
60ed16
 
60ed16
         if (etag) {
60ed16
-                _cleanup_free_ char *escaped_etag = NULL;
60ed16
-
60ed16
                 escaped_etag = xescape(etag, FILENAME_ESCAPE);
60ed16
                 if (!escaped_etag)
60ed16
                         return -ENOMEM;
60ed16
+        }
60ed16
 
60ed16
-                path = strjoin(image_root, "/", strempty(prefix), escaped_url, ".", escaped_etag, strempty(suffix), NULL);
60ed16
-        } else
60ed16
-                path = strjoin(image_root, "/", strempty(prefix), escaped_url, strempty(suffix), NULL);
60ed16
+        path = strjoin(image_root, "/", strempty(prefix), escaped_url, escaped_etag ? "." : "",
60ed16
+                       strempty(escaped_etag), strempty(suffix), NULL);
60ed16
         if (!path)
60ed16
                 return -ENOMEM;
60ed16
 
60ed16
+        /* URLs might make the path longer than the maximum allowed length for a file name.
60ed16
+         * When that happens, a URL hash is used instead. Paths returned by this function
60ed16
+         * can be later used with tempfn_random() which adds 16 bytes to the resulting name. */
60ed16
+        if (strlen(path) >= HASH_URL_THRESHOLD_LENGTH) {
60ed16
+                _cleanup_free_ char *hash = NULL;
60ed16
+                int r;
60ed16
+
60ed16
+                free(path);
60ed16
+
60ed16
+                r = hash_url(url, &hash);
60ed16
+                if (r < 0)
60ed16
+                        return r;
60ed16
+
60ed16
+                path = strjoin(image_root, "/", strempty(prefix), hash, escaped_etag ? "." : "",
60ed16
+                               strempty(escaped_etag), strempty(suffix), NULL);
60ed16
+                if (!path)
60ed16
+                        return -ENOMEM;
60ed16
+        }
60ed16
+
60ed16
         *ret = path;
60ed16
         return 0;
60ed16
 }
60ed16
-- 
60ed16
2.5.0
60ed16