44a72b9
From 773fe149cec50517ff1ed113c802c4e1a047a3e4 Mon Sep 17 00:00:00 2001
44a72b9
From: Lennart Poettering <lennart@poettering.net>
44a72b9
Date: Fri, 22 Sep 2017 18:01:32 +0200
44a72b9
Subject: [PATCH] fileio: rework read_one_line_file() on top of read_line()
44a72b9
44a72b9
(cherry picked from commit f4b51a2d092685c9a080e84130fec2d74c834f5c)
44a72b9
---
44a72b9
 src/basic/fileio.c | 18 ++----------------
44a72b9
 1 file changed, 2 insertions(+), 16 deletions(-)
44a72b9
44a72b9
diff --git a/src/basic/fileio.c b/src/basic/fileio.c
44a72b9
index db5897c360..c66b7b814e 100644
44a72b9
--- a/src/basic/fileio.c
44a72b9
+++ b/src/basic/fileio.c
44a72b9
@@ -30,6 +30,7 @@
44a72b9
 
44a72b9
 #include "alloc-util.h"
44a72b9
 #include "ctype.h"
44a72b9
+#include "def.h"
44a72b9
 #include "env-util.h"
44a72b9
 #include "escape.h"
44a72b9
 #include "fd-util.h"
44a72b9
@@ -163,7 +164,6 @@ fail:
44a72b9
 
44a72b9
 int read_one_line_file(const char *fn, char **line) {
44a72b9
         _cleanup_fclose_ FILE *f = NULL;
44a72b9
-        char t[LINE_MAX], *c;
44a72b9
 
44a72b9
         assert(fn);
44a72b9
         assert(line);
44a72b9
@@ -172,21 +172,7 @@ int read_one_line_file(const char *fn, char **line) {
44a72b9
         if (!f)
44a72b9
                 return -errno;
44a72b9
 
44a72b9
-        if (!fgets(t, sizeof(t), f)) {
44a72b9
-
44a72b9
-                if (ferror(f))
44a72b9
-                        return errno > 0 ? -errno : -EIO;
44a72b9
-
44a72b9
-                t[0] = 0;
44a72b9
-        }
44a72b9
-
44a72b9
-        c = strdup(t);
44a72b9
-        if (!c)
44a72b9
-                return -ENOMEM;
44a72b9
-        truncate_nl(c);
44a72b9
-
44a72b9
-        *line = c;
44a72b9
-        return 0;
44a72b9
+        return read_line(f, LONG_LINE_MAX, line);
44a72b9
 }
44a72b9
 
44a72b9
 int verify_file(const char *fn, const char *blob, bool accept_extra_nl) {