|
 |
d22a5aa |
From 67002cbc9aba1b05576f3390410a84775dd060f2 Mon Sep 17 00:00:00 2001
|
|
|
d22a5aa |
From: Denis Tikhomirov <dvtikhomirov@gmail.com>
|
|
|
d22a5aa |
Date: Thu, 5 Jun 2014 23:59:40 +0400
|
|
|
d22a5aa |
Subject: [PATCH] backlight: Do not clamp brightness for LEDs
|
|
|
d22a5aa |
|
|
|
d22a5aa |
https://bugs.freedesktop.org/show_bug.cgi?id=77092
|
|
|
d22a5aa |
|
|
|
d22a5aa |
On Thu, Jun 05, 2014 at 08:37:20AM +0200, Lennart Poettering wrote:
|
|
|
d22a5aa |
> The patch is line-broken, please send an uncorrupted patch!
|
|
|
d22a5aa |
I am very sorry, I forgot that my client limits line width. I will use
|
|
|
d22a5aa |
mutt now on.
|
|
|
d22a5aa |
> clamp_brightness() clamps the brightness value to the range of the
|
|
|
d22a5aa |
> actual device. This is a recent addition that was added to deal with
|
|
|
d22a5aa |
> driver updates where the resolution is changed. I don't think this part
|
|
|
d22a5aa |
> should be dropped for LED devices. The clamp_brightness() call hence
|
|
|
d22a5aa |
> should be called unconditionally, however, internally it should use a
|
|
|
d22a5aa |
> different min_brightness value if something is an !backlight devices...
|
|
|
d22a5aa |
Thank you for explanation, this sounds very reasonable to me. Please,
|
|
|
d22a5aa |
see updated patch:
|
|
|
d22a5aa |
|
|
|
d22a5aa |
(cherry picked from commit 4cd2b2cf8ca585d15ebc859701b346658262b5bb)
|
|
|
d22a5aa |
(cherry picked from commit 385d2ab37b1a00b513edf5c3888b91d91ad3aae3)
|
|
|
d22a5aa |
---
|
|
|
d22a5aa |
src/backlight/backlight.c | 13 ++++++++++---
|
|
|
d22a5aa |
1 file changed, 10 insertions(+), 3 deletions(-)
|
|
|
d22a5aa |
|
|
|
d22a5aa |
diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c
|
|
|
d22a5aa |
index 77ae48c..e944f57 100644
|
|
|
d22a5aa |
--- a/src/backlight/backlight.c
|
|
|
d22a5aa |
+++ b/src/backlight/backlight.c
|
|
|
d22a5aa |
@@ -221,11 +221,13 @@ static unsigned get_max_brightness(struct udev_device *device) {
|
|
|
d22a5aa |
|
|
|
d22a5aa |
/* Some systems turn the backlight all the way off at the lowest levels.
|
|
|
d22a5aa |
* clamp_brightness clamps the saved brightness to at least 1 or 5% of
|
|
|
d22a5aa |
- * max_brightness. This avoids preserving an unreadably dim screen, which
|
|
|
d22a5aa |
- * would otherwise force the user to disable state restoration. */
|
|
|
d22a5aa |
+ * max_brightness in case of 'backlight' subsystem. This avoids preserving
|
|
|
d22a5aa |
+ * an unreadably dim screen, which would otherwise force the user to
|
|
|
d22a5aa |
+ * disable state restoration. */
|
|
|
d22a5aa |
static void clamp_brightness(struct udev_device *device, char **value, unsigned max_brightness) {
|
|
|
d22a5aa |
int r;
|
|
|
d22a5aa |
unsigned brightness, new_brightness, min_brightness;
|
|
|
d22a5aa |
+ const char *subsystem;
|
|
|
d22a5aa |
|
|
|
d22a5aa |
r = safe_atou(*value, &brightness);
|
|
|
d22a5aa |
if (r < 0) {
|
|
|
d22a5aa |
@@ -233,7 +235,12 @@ static void clamp_brightness(struct udev_device *device, char **value, unsigned
|
|
|
d22a5aa |
return;
|
|
|
d22a5aa |
}
|
|
|
d22a5aa |
|
|
|
d22a5aa |
- min_brightness = MAX(1U, max_brightness/20);
|
|
|
d22a5aa |
+ subsystem = udev_device_get_subsystem(device);
|
|
|
d22a5aa |
+ if (streq_ptr(subsystem, "backlight"))
|
|
|
d22a5aa |
+ min_brightness = MAX(1U, max_brightness/20);
|
|
|
d22a5aa |
+ else
|
|
|
d22a5aa |
+ min_brightness = 0;
|
|
|
d22a5aa |
+
|
|
|
d22a5aa |
new_brightness = CLAMP(brightness, min_brightness, max_brightness);
|
|
|
d22a5aa |
if (new_brightness != brightness) {
|
|
|
d22a5aa |
char *old_value = *value;
|