From 1af87b4e93f8fd4873dfbbd12e069e81894f6943 Mon Sep 17 00:00:00 2001
From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 30 May 2012 15:42:35 +0200
Subject: [PATCH] journald: ignore messages read from /proc/kmsg that we
generated via /dev/kmsg
Avoid a busy loop.
(cherry picked from commit 6c3569e11aa1f658a9ef3f3c6efda4ae696e5aa8)
Conflicts:
TODO
---
src/journal/journald.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/src/journal/journald.c b/src/journal/journald.c
index de0c604..0799f20 100644
--- a/src/journal/journald.c
+++ b/src/journal/journald.c
@@ -1768,6 +1768,17 @@ static int parse_kernel_timestamp(char **_p, usec_t *t) {
return 1;
}
+static bool is_us(const char *pid) {
+ pid_t t;
+
+ assert(pid);
+
+ if (parse_pid(pid, &t) < 0)
+ return false;
+
+ return t == getpid();
+}
+
static void proc_kmsg_line(Server *s, const char *p) {
struct iovec iovec[N_IOVEC_META_FIELDS + 7];
char *message = NULL, *syslog_priority = NULL, *syslog_pid = NULL, *syslog_facility = NULL, *syslog_identifier = NULL, *source_time = NULL;
@@ -1807,6 +1818,11 @@ static void proc_kmsg_line(Server *s, const char *p) {
} else {
read_identifier(&p, &identifier, &pid);
+ /* Avoid any messages we generated ourselves via
+ * log_info() and friends. */
+ if (is_us(pid))
+ goto finish;
+
if (s->forward_to_syslog)
forward_syslog(s, priority, identifier, p, NULL, NULL);
@@ -1832,6 +1848,7 @@ static void proc_kmsg_line(Server *s, const char *p) {
dispatch_message(s, iovec, n, ELEMENTSOF(iovec), NULL, NULL, NULL, 0, priority);
+finish:
free(message);
free(syslog_priority);
free(syslog_identifier);