PR#42: + systemd-247.1-2 - rpms/systemd

rpms / systemd

#42 + systemd-247.1-2

Merged 3 years ago by zbyszek. Opened 3 years ago by hadess.

Unknown source master into master

Bastien Nocera • 3 years ago

a91e823

systemd.spec

file modified

+6 -2

		`@@ -21,7 +21,7 @@`
		`Name: systemd`
		`Url: https://www.freedesktop.org/wiki/Software/systemd`
		`Version: 247.1`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`# For a breakdown of the licensing, see README`
		`License: LGPLv2+ and MIT and GPLv2+`
		`Summary: System and Service Manager`
		`@@ -444,7 +444,6 @@`
		`-Db_ndebug=false`
		`-Dman=true`
		`-Dversion-tag=v%{version}-%{release}`
		`- -Dfallback-hostname=fedora`
		`-Ddefault-dnssec=no`
		`# https://bugzilla.redhat.com/show_bug.cgi?id=1867830`
		`-Ddefault-mdns=no`
		`@@ -892,6 +891,11 @@`
		`%files standalone-sysusers -f .file-list-standalone-sysusers`

		`%changelog`
		`+ * Fri Dec 04 2020 Bastien Nocera <bnocera@redhat.com> - 247.1-2`
		`+ + systemd-247.1-2`
		`+ - Unset fallback-hostname as plenty of applications expected localhost`
		`+ to mean "default hostname" without ever standardising it (#1892235)`
		`+`
		`* Tue Dec 1 2020 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - 247.1-1`
		`- Latest stable release`
		`- Fixes #1902819.`

hadess commented 3 years ago

Unset fallback-hostname as plenty of applications expected localhost
to mean "default hostname" without ever standardising it (#1892235)

This reverts commit 6eb8bcd.

zuul commented 3 years ago

Build failed.

rpm-scratch-build : SUCCESS in 8m 27s
rpm-linter : SUCCESS in 7m 34s
rpm-rpminspect : SUCCESS in 15m 18s (non-voting)
check-for-tests : SUCCESS in 6s
rpm-install-test : FAILURE in 4m 08s
rpm-test : SKIPPED

lorbus commented 3 years ago

Thank you for doing this - this has actually uncovered a whole bunch of issues, especially in handling of networking in OpenShift, so it's not all bad and we're learning a lot and improving from it.
Let's get the affected parts fixed and then safely re-introduce this change :)

Pull-Request has been merged by zbyszek

3 years ago

zbyszek commented 3 years ago

Oh, punish me harder!
With this patch, I now get "linux" as the hostname.
It seems NM queries resolved for the local IP address and gets "linux" and sets that as the transient hostname. I don't think this is an improvement, since "linux" is a problematic as "fedora". So I'll revert the change for now.

@dustymabe ^