From 4f0d2ef232fe578576a2bec5076fda19de15ff27 Mon Sep 17 00:00:00 2001 From: Martin Pitt Date: Mon, 4 Nov 2013 07:25:45 +0100 Subject: [PATCH] udev-builtin-keyboard: Fix large scan codes on 32 bit architectures Use strtoul(), as scan codes are always positive. On 32 bit architectures strtol gives wrong results: strtol("fffffff0", &endptr, 16) returns 2147483647 instead of 4294967280. https://launchpad.net/bugs/1247676 --- src/udev/udev-builtin-keyboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/udev/udev-builtin-keyboard.c b/src/udev/udev-builtin-keyboard.c index ddd8535..8f457ab 100644 --- a/src/udev/udev-builtin-keyboard.c +++ b/src/udev/udev-builtin-keyboard.c @@ -88,7 +88,7 @@ static int builtin_keyboard(struct udev_device *dev, int argc, char *argv[], boo continue; /* KEYBOARD_KEY_= */ - scancode = strtol(key + 13, &endptr, 16); + scancode = strtoul(key + 13, &endptr, 16); if (endptr[0] != '\0') { log_error("Error, unable to parse scan code from '%s'\n", key); continue;