Blame 0011-pgm-don-t-advance-bp-by-the-option-haeder-length-twi.patch
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
From 627a1b7fdceaad8745c438bb0037e59689a1f0df Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
From: Guy Harris <gharris@sonic.net>
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
Date: Tue, 22 Aug 2023 12:23:20 -0700
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
Subject: [PATCH] pgm: don't advance bp by the option haeder length twice.
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
At those points, we've already advanced it by the option header length,
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
and opt_len includes that length, so advance bp by opt_len minus the
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
option header length.
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
(cherry picked from commit 09b0447fad52298440e05e7368f9d24492d0b0fe)
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
---
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
print-pgm.c | 6 +++---
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
1 file changed, 3 insertions(+), 3 deletions(-)
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
diff --git a/print-pgm.c b/print-pgm.c
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
index 8a7e215b..1e67db77 100644
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
--- a/print-pgm.c
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
+++ b/print-pgm.c
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
@@ -661,7 +661,7 @@ pgm_print(netdissect_options *ndo,
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
case PGM_OPT_PATH_NLA:
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
ND_PRINT(" PATH_NLA [%u]", opt_len);
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
- bp += opt_len;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
+ bp += opt_len - 2;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
opts_len -= opt_len;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
break;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
@@ -703,7 +703,7 @@ pgm_print(netdissect_options *ndo,
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
case PGM_OPT_CR:
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
ND_PRINT(" CR");
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
- bp += opt_len;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
+ bp += opt_len - 2;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
opts_len -= opt_len;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
break;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
@@ -807,7 +807,7 @@ pgm_print(netdissect_options *ndo,
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
default:
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
ND_PRINT(" OPT_%02X [%u] ", opt_type, opt_len);
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
- bp += opt_len;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
+ bp += opt_len - 2;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
opts_len -= opt_len;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
break;
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
}
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
--
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
2.41.0
|
|
![](https://seccdn.libravatar.org/avatar/3b2d6e4338c2edc687b2346beaa131b6859c283554ab516e1630062d54d813a4?s=16&d=retro) |
ba8cf09 |
|