Blame texlive-20190410-poppler-0.73.patch

35362e6
diff -up texlive-base-20190410/source/texk/web2c/pdftexdir/pdftoepdf.cc.poppler-0.73 texlive-base-20190410/source/texk/web2c/pdftexdir/pdftoepdf.cc
35362e6
--- texlive-base-20190410/source/texk/web2c/pdftexdir/pdftoepdf.cc.poppler-0.73	2019-05-23 15:50:17.849768543 -0400
35362e6
+++ texlive-base-20190410/source/texk/web2c/pdftexdir/pdftoepdf.cc	2019-05-23 16:00:41.022262790 -0400
35362e6
@@ -120,7 +120,7 @@ struct UsedEncoding {
35362e6
 
35362e6
 static InObj *inObjList;
35362e6
 static UsedEncoding *encodingList;
35362e6
-static GBool isInit = gFalse;
35362e6
+static bool isInit = false;
35362e6
 
35362e6
 // --------------------------------------------------------------------
35362e6
 // Maintain list of open embedded PDF files
35362e6
@@ -275,7 +275,7 @@ static int getNewObjectNumber(Ref ref)
35362e6
 
35362e6
 static void copyObject(Object *);
35362e6
 
35362e6
-static void copyName(char *s)
35362e6
+static void copyName(const char *s)
35362e6
 {
35362e6
     pdf_puts("/");
35362e6
     for (; *s != 0; s++) {
35362e6
@@ -310,7 +310,7 @@ static void copyDict(Object * obj)
35362e6
 static void copyFontDict(Object * obj, InObj * r)
35362e6
 {
35362e6
     int i, l;
35362e6
-    char *key;
35362e6
+    const char *key;
35362e6
     if (!obj->isDict())
35362e6
         pdftex_fail("PDF inclusion: invalid dict type <%s>",
35362e6
                     obj->getTypeName());
35362e6
@@ -382,7 +382,7 @@ static bool embeddableFont(Object * font
35362e6
     return false;
35362e6
 }
35362e6
 
35362e6
-static void copyFont(char *tag, Object * fontRef)
35362e6
+static void copyFont(const char *tag, Object * fontRef)
35362e6
 {
35362e6
     Object fontdict, subtype, basefont, fontdescRef, fontdesc, charset,
35362e6
         stemV;
35362e6
@@ -418,7 +418,7 @@ static void copyFont(char *tag, Object *
35362e6
         && fontdescRef.isRef()
35362e6
         && fontdesc.isDict()
35362e6
         && embeddableFont(&fontdesc)
35362e6
-        && (fontmap = lookup_fontmap(basefont.getName())) != NULL) {
35362e6
+        && (fontmap = lookup_fontmap((char *)basefont.getName())) != NULL) {
35362e6
         // round /StemV value, since the PDF input is a float
35362e6
         // (see Font Descriptors in PDF reference), but we only store an
35362e6
         // integer, since we don't want to change the struct.
35362e6
@@ -427,7 +427,7 @@ static void copyFont(char *tag, Object *
35362e6
         charset = fontdesc.dictLookup("CharSet");
35362e6
         if (!charset.isNull() &&
35362e6
             charset.isString() && is_subsetable(fontmap))
35362e6
-            epdf_mark_glyphs(fd, charset.getString()->getCString());
35362e6
+            epdf_mark_glyphs(fd, (char *)charset.getString()->c_str());
35362e6
         else
35362e6
             embed_whole_font(fd);
35362e6
         addFontDesc(fontdescRef.getRef(), fd);
35362e6
@@ -467,7 +467,7 @@ static void copyFontResources(Object * o
35362e6
     pdf_puts(">>\n");
35362e6
 }
35362e6
 
35362e6
-static void copyOtherResources(Object * obj, char *key)
35362e6
+static void copyOtherResources(Object * obj, const char *key)
35362e6
 {
35362e6
     // copies all other resources (write_epdf handles Fonts and ProcSets),
35362e6
 
35362e6
@@ -554,8 +554,8 @@ static void copyObject(Object * obj)
35362e6
     Object obj1;
35362e6
     int i, l, c;
35362e6
     Ref ref;
35362e6
-    char *p;
35362e6
-    GString *s;
35362e6
+    const char *p;
35362e6
+    const GString *s;
35362e6
     if (obj->isBool()) {
35362e6
         pdf_printf("%s", obj->getBool()? "true" : "false");
35362e6
     } else if (obj->isInt()) {
35362e6
@@ -566,7 +566,7 @@ static void copyObject(Object * obj)
35362e6
         pdf_printf("%s", convertNumToPDF(obj->getNum()));
35362e6
     } else if (obj->isString()) {
35362e6
         s = obj->getString();
35362e6
-        p = s->getCString();
35362e6
+        p = s->c_str();
35362e6
         l = s->getLength();
35362e6
         if (strlen(p) == (unsigned int) l) {
35362e6
             pdf_puts("(");
35362e6
@@ -664,7 +664,7 @@ static void writeEncodings()
35362e6
                     ("PDF inclusion: CID fonts are not supported"
35362e6
                      " (try to disable font replacement to fix this)");
35362e6
             }
35362e6
-            if ((s = ((Gfx8BitFont *) r->font)->getCharName(i)) != 0)
35362e6
+            if ((s = (char *) ((Gfx8BitFont *) r->font)->getCharName(i)) != 0)
35362e6
                 glyphNames[i] = s;
35362e6
             else
35362e6
                 glyphNames[i] = notdef;
35362e6
@@ -683,7 +683,7 @@ static void writeEncodings()
35362e6
 }
35362e6
 
35362e6
 // get the pagebox according to the pagebox_spec
35362e6
-static PDFRectangle *get_pagebox(Page * page, int pagebox_spec)
35362e6
+static const PDFRectangle *get_pagebox(Page * page, int pagebox_spec)
35362e6
 {
35362e6
     if (pagebox_spec == pdfboxspecmedia)
35362e6
         return page->getMediaBox();
35362e6
@@ -715,7 +715,7 @@ read_pdf_info(char *image_name, char *pa
35362e6
 {
35362e6
     PdfDocument *pdf_doc;
35362e6
     Page *page;
35362e6
-    PDFRectangle *pagebox;
35362e6
+    const PDFRectangle *pagebox;
35362e6
 #ifdef POPPLER_VERSION
35362e6
     int pdf_major_version_found, pdf_minor_version_found;
35362e6
 #else
35362e6
@@ -724,8 +724,8 @@ read_pdf_info(char *image_name, char *pa
35362e6
     // initialize
35362e6
     if (!isInit) {
35362e6
         globalParams = new GlobalParams();
35362e6
-        globalParams->setErrQuiet(gFalse);
35362e6
-        isInit = gTrue;
35362e6
+        globalParams->setErrQuiet(false);
35362e6
+        isInit = true;
35362e6
     }
35362e6
     // open PDF file
35362e6
     pdf_doc = find_add_document(image_name);
35362e6
@@ -822,7 +822,7 @@ void write_epdf(void)
35362e6
     Object groupDict;
35362e6
     bool writeSepGroup = false;
35362e6
     Object info;
35362e6
-    char *key;
35362e6
+    const char *key;
35362e6
     char s[256];
35362e6
     int i, l;
35362e6
     int rotate;
35362e6
@@ -849,7 +849,7 @@ void write_epdf(void)
35362e6
     pageObj = xref->fetch(pageRef->num, pageRef->gen);
35362e6
     pageDict = pageObj.getDict();
35362e6
     rotate = page->getRotate();
35362e6
-    PDFRectangle *pagebox;
35362e6
+    const PDFRectangle *pagebox;
35362e6
     // write the Page header
35362e6
     pdf_puts("/Type /XObject\n");
35362e6
     pdf_puts("/Subtype /Form\n");
35362e6
@@ -977,7 +977,7 @@ The changes below seem to work fine.
35362e6
             }
35362e6
             l = dic1.getLength();
35362e6
             for (i = 0; i < l; i++) {
35362e6
-                groupDict.dictAdd(copyString(dic1.getKey(i)),
35362e6
+                groupDict.dictAdd(dic1.getKey(i),
35362e6
                                   dic1.getValNF(i));
35362e6
             }
35362e6
 // end modification
35362e6
diff -up texlive-base-20190410/source/texk/web2c/pdftexdir/pdftosrc.cc.poppler-0.73 texlive-base-20190410/source/texk/web2c/pdftexdir/pdftosrc.cc
35362e6
--- texlive-base-20190410/source/texk/web2c/pdftexdir/pdftosrc.cc.poppler-0.73	2019-05-23 15:50:17.850768522 -0400
35362e6
+++ texlive-base-20190410/source/texk/web2c/pdftexdir/pdftosrc.cc	2019-05-23 15:50:17.858768349 -0400
35362e6
@@ -109,7 +109,7 @@ int main(int argc, char *argv[])
35362e6
             fprintf(stderr, "No SourceName found\n");
35362e6
             exit(1);
35362e6
         }
35362e6
-        outname = srcName.getString()->getCString();
35362e6
+        outname = (char *)srcName.getString()->c_str();
35362e6
         // We cannot free srcName, as objname shares its string.
35362e6
         // srcName.free();
35362e6
     } else if (objnum > 0) {
35362e6
@@ -118,7 +118,7 @@ int main(int argc, char *argv[])
35362e6
             fprintf(stderr, "Not a Stream object\n");
35362e6
             exit(1);
35362e6
         }
35362e6
-        sprintf(buf, "%s", fileName->getCString());
35362e6
+        sprintf(buf, "%s", fileName->c_str());
35362e6
         if ((p = strrchr(buf, '.')) == 0)
35362e6
             p = strchr(buf, 0);
35362e6
         if (objgen == 0)
35362e6
@@ -128,7 +128,7 @@ int main(int argc, char *argv[])
35362e6
         outname = buf;
35362e6
     } else {                    // objnum < 0 means we are extracting the XRef table
35362e6
         extract_xref_table = true;
35362e6
-        sprintf(buf, "%s", fileName->getCString());
35362e6
+        sprintf(buf, "%s", fileName->c_str());
35362e6
         if ((p = strrchr(buf, '.')) == 0)
35362e6
             p = strchr(buf, 0);
35362e6
         sprintf(p, ".xref");
35362e6
@@ -161,7 +161,7 @@ int main(int argc, char *argv[])
35362e6
                 Object objStr, obj1, obj2;
35362e6
                 int nObjects, first, n;
35362e6
                 int localOffset = 0;
35362e6
-                Guint firstOffset;
35362e6
+                unsigned int firstOffset;
35362e6
 
35362e6
                 objStr = xref->fetch(e->offset, 0);
35362e6
                 assert(objStr.isStream());
35362e6
@@ -173,9 +173,9 @@ int main(int argc, char *argv[])
35362e6
 
35362e6
                 // parse the header: object numbers and offsets
35362e6
                 objStr.streamReset();
35362e6
-                str = new EmbedStream(objStr.getStream(), Object(objNull), gTrue, first);
35362e6
+                str = new EmbedStream(objStr.getStream(), Object(objNull), true, first);
35362e6
                 lexer = new Lexer(xref, str);
35362e6
-                parser = new Parser(xref, lexer, gFalse);
35362e6
+                parser = new Parser(xref, lexer, false);
35362e6
                 for (n = 0; n < nObjects; ++n) {
35362e6
                     obj1 = parser->getObj();
35362e6
                     obj2 = parser->getObj();
35362e6
diff -up texlive-base-20190410/source/texk/web2c/xetexdir/pdfimage.cpp.poppler-0.73 texlive-base-20190410/source/texk/web2c/xetexdir/pdfimage.cpp
35362e6
--- texlive-base-20190410/source/texk/web2c/xetexdir/pdfimage.cpp.poppler-0.73	2018-12-25 00:48:22.000000000 -0500
35362e6
+++ texlive-base-20190410/source/texk/web2c/xetexdir/pdfimage.cpp	2019-05-23 15:50:17.858768349 -0400
35362e6
@@ -78,26 +78,29 @@ pdf_get_rect(char* filename, int page_nu
35362e6
 
35362e6
 	Page*		page = doc->getCatalog()->getPage(page_num);
35362e6
 
35362e6
-	const PDFRectangle*	r;
35362e6
+	PDFRectangle*	r;
35362e6
+	const PDFRectangle*	cr;
35362e6
 	switch (pdf_box) {
35362e6
 		default:
35362e6
 		case pdfbox_crop:
35362e6
-			r = page->getCropBox();
35362e6
+			cr = page->getCropBox();
35362e6
 			break;
35362e6
 		case pdfbox_media:
35362e6
-			r = page->getMediaBox();
35362e6
+			cr = page->getMediaBox();
35362e6
 			break;
35362e6
 		case pdfbox_bleed:
35362e6
-			r = page->getBleedBox();
35362e6
+			cr = page->getBleedBox();
35362e6
 			break;
35362e6
 		case pdfbox_trim:
35362e6
-			r = page->getTrimBox();
35362e6
+			cr = page->getTrimBox();
35362e6
 			break;
35362e6
 		case pdfbox_art:
35362e6
-			r = page->getArtBox();
35362e6
+			cr = page->getArtBox();
35362e6
 			break;
35362e6
 	}
35362e6
 
35362e6
+	r = new PDFRectangle (cr->x1, cr->y1, cr->x2, cr->y2);
35362e6
+
35362e6
 	int RotAngle = 0;
35362e6
 	RotAngle = (int)page->getRotate() % 360;
35362e6
 	if (RotAngle < 0)
35362e6
@@ -112,6 +115,7 @@ pdf_get_rect(char* filename, int page_nu
35362e6
 	box->x  = 72.27 / 72 * my_fmin(r->x1, r->x2);
35362e6
 	box->y  = 72.27 / 72 * my_fmin(r->y1, r->y2);
35362e6
 
35362e6
+	delete r;
35362e6
 	delete doc;
35362e6
 
35362e6
 	return 0;