Blame texlive-20200327-new-poppler.patch

75e825d
diff -up texlive-base-20200327/source/texk/web2c/pdftexdir/pdftoepdf.cc.newpoppler texlive-base-20200327/source/texk/web2c/pdftexdir/pdftoepdf.cc
75e825d
--- texlive-base-20200327/source/texk/web2c/pdftexdir/pdftoepdf.cc.newpoppler	2019-11-27 17:45:26.000000000 -0500
75e825d
+++ texlive-base-20200327/source/texk/web2c/pdftexdir/pdftoepdf.cc	2020-04-20 14:28:40.111986243 -0400
75e825d
@@ -1,5 +1,5 @@
75e825d
 /*
75e825d
-Copyright 1996-2016 Han The Thanh, <thanh@pdftex.org>
75e825d
+Copyright 1996-2017 Han The Thanh, <thanh@pdftex.org>
75e825d
 
75e825d
 This file is part of pdfTeX.
75e825d
 
75e825d
@@ -17,6 +17,15 @@ You should have received a copy of the G
75e825d
 with this program.  If not, see <http://www.gnu.org/licenses/>.
75e825d
 */
75e825d
 
75e825d
+/*
75e825d
+This is based on the patch texlive-poppler-0.59.patch <2017-09-19> at
75e825d
+https://git.archlinux.org/svntogit/packages.git/plain/texlive-bin/trunk
75e825d
+by Arch Linux. A little modifications are made to avoid a crash for
75e825d
+some kind of pdf images, such as figure_missing.pdf in gnuplot.
75e825d
+The poppler should be 0.59.0 or newer versions.
75e825d
+POPPLER_VERSION should be defined.
75e825d
+*/
75e825d
+
75e825d
 /* Do this early in order to avoid a conflict between
75e825d
    MINGW32 <rpcndr.h> defining 'boolean' as 'unsigned char' and
75e825d
    <kpathsea/types.h> defining Pascal's boolean as 'int'.
75e825d
@@ -39,10 +48,7 @@ with this program.  If not, see 
75e825d
 #include <goo/gfile.h>
75e825d
 #define GString GooString
75e825d
 #else
75e825d
-#include <aconf.h>
75e825d
-#include <GString.h>
75e825d
-#include <gmem.h>
75e825d
-#include <gfile.h>
75e825d
+#error POPPLER_VERSION should be defined.
75e825d
 #endif
75e825d
 #include <assert.h>
75e825d
 
75e825d
@@ -84,31 +90,6 @@ extern integer zround(double);
75e825d
 #define MASK_SUPPRESS_PTEX_PAGENUMBER 0x04
75e825d
 #define MASK_SUPPRESS_PTEX_INFODICT   0x08
75e825d
 
75e825d
-// PdfObject encapsulates the xpdf Object type,
75e825d
-// and properly frees its resources on destruction.
75e825d
-// Use obj-> to access members of the Object,
75e825d
-// and &obj to get a pointer to the object.
75e825d
-// It is no longer necessary to call Object::free explicitely.
75e825d
-
75e825d
-class PdfObject {
75e825d
-  public:
75e825d
-    PdfObject() {               // nothing
75e825d
-    } ~PdfObject() {
75e825d
-        iObject.free();
75e825d
-    }
75e825d
-    Object *operator->() {
75e825d
-        return &iObject;
75e825d
-    }
75e825d
-    Object *operator&() {
75e825d
-        return &iObject;
75e825d
-    }
75e825d
-  private:                     // no copying or assigning
75e825d
-    PdfObject(const PdfObject &);
75e825d
-    void operator=(const PdfObject &);
75e825d
-  public:
75e825d
-    Object iObject;
75e825d
-};
75e825d
-
75e825d
 // When copying the Resources of the selected page, all objects are copied
75e825d
 // recusively top-down. Indirect objects however are not fetched during
75e825d
 // copying, but get a new object number from pdfTeX and then will be
75e825d
@@ -212,18 +193,6 @@ static void delete_document(PdfDocument
75e825d
     delete pdf_doc;
75e825d
 }
75e825d
 
75e825d
-// Replacement for
75e825d
-//      Object *initDict(Dict *dict1){ initObj(objDict); dict = dict1; return this; }
75e825d
-
75e825d
-static void initDictFromDict(PdfObject & obj, Dict * dict)
75e825d
-{
75e825d
-    obj->initDict(xref);
75e825d
-    for (int i = 0, l = dict->getLength(); i < l; i++) {
75e825d
-        Object obj1;
75e825d
-        obj->dictAdd(copyString(dict->getKey(i)), dict->getValNF(i, &obj1));
75e825d
-    }
75e825d
-}
75e825d
-
75e825d
 // --------------------------------------------------------------------
75e825d
 
75e825d
 static int addEncoding(GfxFont * gfont)
75e825d
@@ -320,10 +289,10 @@ static void copyName(char *s)
75e825d
 
75e825d
 static void copyDictEntry(Object * obj, int i)
75e825d
 {
75e825d
-    PdfObject obj1;
75e825d
+    Object obj1;
75e825d
     copyName(obj->dictGetKey(i));
75e825d
     pdf_puts(" ");
75e825d
-    obj->dictGetValNF(i, &obj1);
75e825d
+    obj1 = obj->dictGetValNF(i);
75e825d
     copyObject(&obj1);
75e825d
     pdf_puts("\n");
75e825d
 }
75e825d
@@ -376,17 +345,17 @@ static void copyStream(Stream * str)
75e825d
 static void copyProcSet(Object * obj)
75e825d
 {
75e825d
     int i, l;
75e825d
-    PdfObject procset;
75e825d
+    Object procset;
75e825d
     if (!obj->isArray())
75e825d
         pdftex_fail("PDF inclusion: invalid ProcSet array type <%s>",
75e825d
                     obj->getTypeName());
75e825d
     pdf_puts("/ProcSet [ ");
75e825d
     for (i = 0, l = obj->arrayGetLength(); i < l; ++i) {
75e825d
-        obj->arrayGetNF(i, &procset);
75e825d
-        if (!procset->isName())
75e825d
+        procset = obj->arrayGetNF(i);
75e825d
+        if (!procset.isName())
75e825d
             pdftex_fail("PDF inclusion: invalid ProcSet entry type <%s>",
75e825d
-                        procset->getTypeName());
75e825d
-        copyName(procset->getName());
75e825d
+                        procset.getTypeName());
75e825d
+        copyName(procset.getName());
75e825d
         pdf_puts(" ");
75e825d
     }
75e825d
     pdf_puts("]\n");
75e825d
@@ -394,10 +363,29 @@ static void copyProcSet(Object * obj)
75e825d
 
75e825d
 #define REPLACE_TYPE1C true
75e825d
 
75e825d
+static bool embeddableFont(Object * fontdesc)
75e825d
+{
75e825d
+    Object fontfile, ffsubtype;
75e825d
+
75e825d
+    if (!fontdesc->isDict())
75e825d
+        return false;
75e825d
+    fontfile = fontdesc->dictLookup("FontFile");
75e825d
+    if (fontfile.isStream())
75e825d
+        return true;
75e825d
+    if (REPLACE_TYPE1C) {
75e825d
+        fontfile = fontdesc->dictLookup("FontFile3");
75e825d
+        if (!fontfile.isStream())
75e825d
+            return false;
75e825d
+        ffsubtype = fontfile.streamGetDict()->lookup("Subtype");
75e825d
+        return ffsubtype.isName() && !strcmp(ffsubtype.getName(), "Type1C");
75e825d
+    }
75e825d
+    return false;
75e825d
+}
75e825d
+
75e825d
 static void copyFont(char *tag, Object * fontRef)
75e825d
 {
75e825d
-    PdfObject fontdict, subtype, basefont, fontdescRef, fontdesc, charset,
75e825d
-        fontfile, ffsubtype, stemV;
75e825d
+    Object fontdict, subtype, basefont, fontdescRef, fontdesc, charset,
75e825d
+        stemV;
75e825d
     GfxFont *gfont;
75e825d
     fd_entry *fd;
75e825d
     fm_entry *fontmap;
75e825d
@@ -413,33 +401,39 @@ static void copyFont(char *tag, Object *
75e825d
     }
75e825d
     // Only handle included Type1 (and Type1C) fonts; anything else will be copied.
75e825d
     // Type1C fonts are replaced by Type1 fonts, if REPLACE_TYPE1C is true.
75e825d
-    if (!fixedinclusioncopyfont && fontRef->fetch(xref, &fontdict)->isDict()
75e825d
-        && fontdict->dictLookup("Subtype", &subtype)->isName()
75e825d
-        && !strcmp(subtype->getName(), "Type1")
75e825d
-        && fontdict->dictLookup("BaseFont", &basefont)->isName()
75e825d
-        && fontdict->dictLookupNF("FontDescriptor", &fontdescRef)->isRef()
75e825d
-        && fontdescRef->fetch(xref, &fontdesc)->isDict()
75e825d
-        && (fontdesc->dictLookup("FontFile", &fontfile)->isStream()
75e825d
-            || (REPLACE_TYPE1C
75e825d
-                && fontdesc->dictLookup("FontFile3", &fontfile)->isStream()
75e825d
-                && fontfile->streamGetDict()->lookup("Subtype",
75e825d
-                                                     &ffsubtype)->isName()
75e825d
-                && !strcmp(ffsubtype->getName(), "Type1C")))
75e825d
-        && (fontmap = lookup_fontmap(basefont->getName())) != NULL) {
75e825d
+    fontdict = fontRef->fetch(xref);
75e825d
+    fontdesc = Object(objNull);
75e825d
+    if (fontdict.isDict()) {
75e825d
+        subtype = fontdict.dictLookup("Subtype");
75e825d
+        basefont = fontdict.dictLookup("BaseFont");
75e825d
+        fontdescRef = fontdict.dictLookupNF("FontDescriptor");
75e825d
+        if (fontdescRef.isRef()) {
75e825d
+            fontdesc = fontdescRef.fetch(xref);
75e825d
+        }
75e825d
+    }
75e825d
+    if (!fixedinclusioncopyfont && fontdict.isDict()
75e825d
+        && subtype.isName()
75e825d
+        && !strcmp(subtype.getName(), "Type1")
75e825d
+        && basefont.isName()
75e825d
+        && fontdescRef.isRef()
75e825d
+        && fontdesc.isDict()
75e825d
+        && embeddableFont(&fontdesc)
75e825d
+        && (fontmap = lookup_fontmap(basefont.getName())) != NULL) {
75e825d
         // round /StemV value, since the PDF input is a float
75e825d
         // (see Font Descriptors in PDF reference), but we only store an
75e825d
         // integer, since we don't want to change the struct.
75e825d
-        fontdesc->dictLookup("StemV", &stemV);
75e825d
-        fd = epdf_create_fontdescriptor(fontmap, zround(stemV->getNum()));
75e825d
-        if (fontdesc->dictLookup("CharSet", &charset) &&
75e825d
-            charset->isString() && is_subsetable(fontmap))
75e825d
-            epdf_mark_glyphs(fd, charset->getString()->getCString());
75e825d
+        stemV = fontdesc.dictLookup("StemV");
75e825d
+        fd = epdf_create_fontdescriptor(fontmap, zround(stemV.getNum()));
75e825d
+        charset = fontdesc.dictLookup("CharSet");
75e825d
+        if (!charset.isNull() &&
75e825d
+            charset.isString() && is_subsetable(fontmap))
75e825d
+            epdf_mark_glyphs(fd, charset.getString()->getCString());
75e825d
         else
75e825d
             embed_whole_font(fd);
75e825d
-        addFontDesc(fontdescRef->getRef(), fd);
75e825d
+        addFontDesc(fontdescRef.getRef(), fd);
75e825d
         copyName(tag);
75e825d
         gfont = GfxFont::makeFont(xref, tag, fontRef->getRef(),
75e825d
-                                  fontdict->getDict());
75e825d
+                                  fontdict.getDict());
75e825d
         pdf_printf(" %d 0 R ", addFont(fontRef->getRef(), fd,
75e825d
                                        addEncoding(gfont)));
75e825d
     } else {
75e825d
@@ -451,24 +445,24 @@ static void copyFont(char *tag, Object *
75e825d
 
75e825d
 static void copyFontResources(Object * obj)
75e825d
 {
75e825d
-    PdfObject fontRef;
75e825d
+    Object fontRef;
75e825d
     int i, l;
75e825d
     if (!obj->isDict())
75e825d
         pdftex_fail("PDF inclusion: invalid font resources dict type <%s>",
75e825d
                     obj->getTypeName());
75e825d
     pdf_puts("/Font << ");
75e825d
     for (i = 0, l = obj->dictGetLength(); i < l; ++i) {
75e825d
-        obj->dictGetValNF(i, &fontRef);
75e825d
-        if (fontRef->isRef())
75e825d
+        fontRef = obj->dictGetValNF(i);
75e825d
+        if (fontRef.isRef())
75e825d
             copyFont(obj->dictGetKey(i), &fontRef);
75e825d
-        else if (fontRef->isDict()) {   // some programs generate pdf with embedded font object
75e825d
+        else if (fontRef.isDict()) {   // some programs generate pdf with embedded font object
75e825d
             copyName(obj->dictGetKey(i));
75e825d
             pdf_puts(" ");
75e825d
             copyObject(&fontRef);
75e825d
         }
75e825d
         else
75e825d
             pdftex_fail("PDF inclusion: invalid font in reference type <%s>",
75e825d
-                        fontRef->getTypeName());
75e825d
+                        fontRef.getTypeName());
75e825d
     }
75e825d
     pdf_puts(">>\n");
75e825d
 }
75e825d
@@ -557,7 +551,7 @@ static char *convertNumToPDF(double n)
75e825d
 
75e825d
 static void copyObject(Object * obj)
75e825d
 {
75e825d
-    PdfObject obj1;
75e825d
+    Object obj1;
75e825d
     int i, l, c;
75e825d
     Ref ref;
75e825d
     char *p;
75e825d
@@ -601,8 +595,8 @@ static void copyObject(Object * obj)
75e825d
     } else if (obj->isArray()) {
75e825d
         pdf_puts("[");
75e825d
         for (i = 0, l = obj->arrayGetLength(); i < l; ++i) {
75e825d
-            obj->arrayGetNF(i, &obj1);
75e825d
-            if (!obj1->isName())
75e825d
+            obj1 = obj->arrayGetNF(i);
75e825d
+            if (!obj1.isName())
75e825d
                 pdf_puts(" ");
75e825d
             copyObject(&obj1);
75e825d
         }
75e825d
@@ -612,9 +606,8 @@ static void copyObject(Object * obj)
75e825d
         copyDict(obj);
75e825d
         pdf_puts(">>");
75e825d
     } else if (obj->isStream()) {
75e825d
-        initDictFromDict(obj1, obj->streamGetDict());
75e825d
         pdf_puts("<<\n");
75e825d
-        copyDict(&obj1);
75e825d
+        copyDict(obj->getStream()->getDictObject());
75e825d
         pdf_puts(">>\n");
75e825d
         pdf_puts("stream\n");
75e825d
         copyStream(obj->getStream()->getUndecodedStream());
75e825d
@@ -638,9 +631,8 @@ static void writeRefs()
75e825d
     InObj *r;
75e825d
     for (r = inObjList; r != 0; r = r->next) {
75e825d
         if (!r->written) {
75e825d
-            Object obj1;
75e825d
             r->written = 1;
75e825d
-            xref->fetch(r->ref.num, r->ref.gen, &obj1);
75e825d
+            Object obj1 = xref->fetch(r->ref.num, r->ref.gen);
75e825d
             if (r->type == objFont) {
75e825d
                 assert(!obj1.isStream());
75e825d
                 pdfbeginobj(r->num, 2);         // \pdfobjcompresslevel = 2 is for this
75e825d
@@ -656,7 +648,6 @@ static void writeRefs()
75e825d
                 pdf_puts("\n");
75e825d
                 pdfendobj();
75e825d
             }
75e825d
-            obj1.free();
75e825d
         }
75e825d
     }
75e825d
 }
75e825d
@@ -685,7 +676,7 @@ static void writeEncodings()
75e825d
 #ifdef POPPLER_VERSION
75e825d
         r->font->decRefCnt();
75e825d
 #else
75e825d
-        delete r->font;
75e825d
+#error POPPLER_VERSION should be defined.
75e825d
 #endif
75e825d
         delete r;
75e825d
     }
75e825d
@@ -728,7 +719,7 @@ read_pdf_info(char *image_name, char *pa
75e825d
 #ifdef POPPLER_VERSION
75e825d
     int pdf_major_version_found, pdf_minor_version_found;
75e825d
 #else
75e825d
-    float pdf_version_found, pdf_version_wanted;
75e825d
+#error POPPLER_VERSION should be defined.
75e825d
 #endif
75e825d
     // initialize
75e825d
     if (!isInit) {
75e825d
@@ -760,19 +751,7 @@ read_pdf_info(char *image_name, char *pa
75e825d
         }
75e825d
     }
75e825d
 #else
75e825d
-    pdf_version_found = pdf_doc->doc->getPDFVersion();
75e825d
-    pdf_version_wanted = major_pdf_version_wanted + (minor_pdf_version_wanted * 0.1);
75e825d
-    if (pdf_version_found > pdf_version_wanted + 0.01) {
75e825d
-        char msg[] =
75e825d
-            "PDF inclusion: found PDF version <%.1f>, but at most version <%.1f> allowed";
75e825d
-        if (pdf_inclusion_errorlevel > 0) {
75e825d
-            pdftex_fail(msg, pdf_version_found, pdf_version_wanted);
75e825d
-        } else if (pdf_inclusion_errorlevel < 0) {
75e825d
-            ; /* do nothing */
75e825d
-        } else { /* = 0, give warning */
75e825d
-            pdftex_warn(msg, pdf_version_found, pdf_version_wanted);
75e825d
-        }
75e825d
-    }
75e825d
+#error POPPLER_VERSION should be defined.
75e825d
 #endif
75e825d
     epdf_num_pages = pdf_doc->doc->getCatalog()->getNumPages();
75e825d
     if (page_name) {
75e825d
@@ -839,8 +818,8 @@ void write_epdf(void)
75e825d
     Page *page;
75e825d
     Ref *pageRef;
75e825d
     Dict *pageDict;
75e825d
-    PdfObject contents, obj1, obj2, pageObj, dictObj;
75e825d
-    PdfObject groupDict;
75e825d
+    Object contents, obj1, obj2, pageObj, dictObj;
75e825d
+    Object groupDict;
75e825d
     bool writeSepGroup = false;
75e825d
     Object info;
75e825d
     char *key;
75e825d
@@ -867,8 +846,8 @@ void write_epdf(void)
75e825d
     encodingList = 0;
75e825d
     page = pdf_doc->doc->getCatalog()->getPage(epdf_selected_page);
75e825d
     pageRef = pdf_doc->doc->getCatalog()->getPageRef(epdf_selected_page);
75e825d
-    xref->fetch(pageRef->num, pageRef->gen, &pageObj);
75e825d
-    pageDict = pageObj->getDict();
75e825d
+    pageObj = xref->fetch(pageRef->num, pageRef->gen);
75e825d
+    pageDict = pageObj.getDict();
75e825d
     rotate = page->getRotate();
75e825d
     PDFRectangle *pagebox;
75e825d
     // write the Page header
75e825d
@@ -886,7 +865,7 @@ void write_epdf(void)
75e825d
         pdf_printf("/%s.PageNumber %i\n", pdfkeyprefix, (int) epdf_selected_page);
75e825d
     }
75e825d
     if ((suppress_ptex_info & MASK_SUPPRESS_PTEX_INFODICT) == 0) {
75e825d
-        pdf_doc->doc->getDocInfoNF(&info;;
75e825d
+        info = pdf_doc->doc->getDocInfoNF();
75e825d
         if (info.isRef()) {
75e825d
             // the info dict must be indirect (PDF Ref p. 61)
75e825d
             pdf_printf("/%s.InfoDict ", pdfkeyprefix);
75e825d
@@ -942,14 +921,14 @@ void write_epdf(void)
75e825d
     pdf_puts(stripzeros(s));
75e825d
 
75e825d
     // Metadata validity check (as a stream it must be indirect)
75e825d
-    pageDict->lookupNF("Metadata", &dictObj);
75e825d
-    if (!dictObj->isNull() && !dictObj->isRef())
75e825d
+    dictObj = pageDict->lookupNF("Metadata");
75e825d
+    if (!dictObj.isNull() && !dictObj.isRef())
75e825d
         pdftex_warn("PDF inclusion: /Metadata must be indirect object");
75e825d
 
75e825d
     // copy selected items in Page dictionary except Resources & Group
75e825d
     for (i = 0; pageDictKeys[i] != NULL; i++) {
75e825d
-        pageDict->lookupNF(pageDictKeys[i], &dictObj);
75e825d
-        if (!dictObj->isNull()) {
75e825d
+        dictObj = pageDict->lookupNF(pageDictKeys[i]);
75e825d
+        if (!dictObj.isNull()) {
75e825d
             pdf_newline();
75e825d
             pdf_printf("/%s ", pageDictKeys[i]);
75e825d
             copyObject(&dictObj); // preserves indirection
75e825d
@@ -957,8 +936,8 @@ void write_epdf(void)
75e825d
     } 
75e825d
 
75e825d
     // handle page group
75e825d
-    pageDict->lookupNF("Group", &dictObj);
75e825d
-    if (!dictObj->isNull()) {
75e825d
+    dictObj = pageDict->lookupNF("Group");
75e825d
+    if (!dictObj.isNull()) {
75e825d
         if (pdfpagegroupval == 0) { 
75e825d
             // another pdf with page group was included earlier on the
75e825d
             // same page; copy the Group entry as is.  See manual for
75e825d
@@ -972,11 +951,36 @@ void write_epdf(void)
75e825d
             copyObject(&dictObj);
75e825d
         } else {
75e825d
             // write Group dict as a separate object, since the Page dict also refers to it
75e825d
-            pageDict->lookup("Group", &dictObj);
75e825d
-            if (!dictObj->isDict())
75e825d
+            dictObj = pageDict->lookup("Group");
75e825d
+            if (!dictObj.isDict())
75e825d
                 pdftex_fail("PDF inclusion: /Group dict missing");
75e825d
             writeSepGroup = true;
75e825d
-            initDictFromDict(groupDict, page->getGroup());
75e825d
+/*
75e825d
+This part is only a single line
75e825d
+            groupDict = Object(page->getGroup());
75e825d
+in the original patch. In this case, however, pdftex crashes at
75e825d
+"delete pdf_doc->doc" in "delete_document()" for inclusion of some
75e825d
+kind of pdf images, for example, figure_missing.pdf in gnuplot.
75e825d
+A change
75e825d
+            groupDict = Object(page->getGroup()).copy();
75e825d
+does not improve the situation.
75e825d
+The changes below seem to work fine. 
75e825d
+*/
75e825d
+// begin modification
75e825d
+            groupDict = pageDict->lookup("Group");
75e825d
+            const Dict& dic1 = page->getGroup();
75e825d
+            const Dict& dic2 = groupDict.getDict();
75e825d
+            // replace dic2 in groupDict with dic1
75e825d
+            l = dic2.getLength();
75e825d
+            for (i = 0; i < l; i++) {
75e825d
+                groupDict.dictRemove(dic2.getKey(i));
75e825d
+            }
75e825d
+            l = dic1.getLength();
75e825d
+            for (i = 0; i < l; i++) {
75e825d
+                groupDict.dictAdd(copyString(dic1.getKey(i)),
75e825d
+                                  dic1.getValNF(i));
75e825d
+            }
75e825d
+// end modification
75e825d
             pdf_printf("/Group %ld 0 R\n", (long)pdfpagegroupval);
75e825d
         }
75e825d
     }
75e825d
@@ -989,14 +993,14 @@ void write_epdf(void)
75e825d
         pdftex_warn
75e825d
             ("PDF inclusion: /Resources missing. 'This practice is not recommended' (PDF Ref)");
75e825d
     } else {
75e825d
-        initDictFromDict(obj1, page->getResourceDict());
75e825d
+        Object *obj1 = page->getResourceDictObject();
75e825d
         if (!obj1->isDict())
75e825d
             pdftex_fail("PDF inclusion: invalid resources dict type <%s>",
75e825d
                         obj1->getTypeName());
75e825d
         pdf_newline();
75e825d
         pdf_puts("/Resources <<\n");
75e825d
         for (i = 0, l = obj1->dictGetLength(); i < l; ++i) {
75e825d
-            obj1->dictGetVal(i, &obj2);
75e825d
+            obj2 = obj1->dictGetVal(i);
75e825d
             key = obj1->dictGetKey(i);
75e825d
             if (strcmp("Font", key) == 0)
75e825d
                 copyFontResources(&obj2);
75e825d
@@ -1009,8 +1013,8 @@ void write_epdf(void)
75e825d
     }
75e825d
 
75e825d
     // write the page contents
75e825d
-    page->getContents(&contents);
75e825d
-    if (contents->isStream()) {
75e825d
+    contents = page->getContents();
75e825d
+    if (contents.isStream()) {
75e825d
 
75e825d
         // Variant A: get stream and recompress under control
75e825d
         // of \pdfcompresslevel
75e825d
@@ -1021,36 +1025,35 @@ void write_epdf(void)
75e825d
 
75e825d
         // Variant B: copy stream without recompressing
75e825d
         //
75e825d
-        contents->streamGetDict()->lookup("F", &obj1);
75e825d
-        if (!obj1->isNull()) {
75e825d
+        obj1 = contents.streamGetDict()->lookup("F");
75e825d
+        if (!obj1.isNull()) {
75e825d
             pdftex_fail("PDF inclusion: Unsupported external stream");
75e825d
         }
75e825d
-        contents->streamGetDict()->lookup("Length", &obj1);
75e825d
-        assert(!obj1->isNull());
75e825d
+        obj1 = contents.streamGetDict()->lookup("Length");
75e825d
+        assert(!obj1.isNull());
75e825d
         pdf_puts("/Length ");
75e825d
         copyObject(&obj1);
75e825d
         pdf_puts("\n");
75e825d
-        contents->streamGetDict()->lookup("Filter", &obj1);
75e825d
-        if (!obj1->isNull()) {
75e825d
+        obj1 = contents.streamGetDict()->lookup("Filter");
75e825d
+        if (!obj1.isNull()) {
75e825d
             pdf_puts("/Filter ");
75e825d
             copyObject(&obj1);
75e825d
             pdf_puts("\n");
75e825d
-            contents->streamGetDict()->lookup("DecodeParms", &obj1);
75e825d
-            if (!obj1->isNull()) {
75e825d
+            obj1 = contents.streamGetDict()->lookup("DecodeParms");
75e825d
+            if (!obj1.isNull()) {
75e825d
                 pdf_puts("/DecodeParms ");
75e825d
                 copyObject(&obj1);
75e825d
                 pdf_puts("\n");
75e825d
             }
75e825d
         }
75e825d
         pdf_puts(">>\nstream\n");
75e825d
-        copyStream(contents->getStream()->getUndecodedStream());
75e825d
+        copyStream(contents.getStream()->getUndecodedStream());
75e825d
         pdfendstream();
75e825d
-    } else if (contents->isArray()) {
75e825d
+    } else if (contents.isArray()) {
75e825d
         pdfbeginstream();
75e825d
-        for (i = 0, l = contents->arrayGetLength(); i < l; ++i) {
75e825d
-            Object contentsobj;
75e825d
-            copyStream((contents->arrayGet(i, &contentsobj))->getStream());
75e825d
-            contentsobj.free();
75e825d
+        for (i = 0, l = contents.arrayGetLength(); i < l; ++i) {
75e825d
+            Object contentsobj = contents.arrayGet(i);
75e825d
+            copyStream(contentsobj.getStream());
75e825d
             if (i < l - 1)
75e825d
                 pdf_newline();  // add a newline after each stream except the last
75e825d
         }
75e825d
diff -up texlive-base-20200327/source/texk/web2c/pdftexdir/pdftosrc.cc.newpoppler texlive-base-20200327/source/texk/web2c/pdftexdir/pdftosrc.cc
75e825d
--- texlive-base-20200327/source/texk/web2c/pdftexdir/pdftosrc.cc.newpoppler	2017-10-17 00:24:27.000000000 -0400
75e825d
+++ texlive-base-20200327/source/texk/web2c/pdftexdir/pdftosrc.cc	2020-04-20 14:25:55.786266341 -0400
75e825d
@@ -16,6 +16,14 @@ GNU General Public License for more deta
75e825d
 You should have received a copy of the GNU General Public License along
75e825d
 with this program.  If not, see <http://www.gnu.org/licenses/>.
75e825d
 */
75e825d
+
75e825d
+/*
75e825d
+This is based on the patch texlive-poppler-0.59.patch <2017-09-19> at
75e825d
+https://git.archlinux.org/svntogit/packages.git/plain/texlive-bin/trunk
75e825d
+by Arch Linux. The poppler should be 0.59.0 or newer versions.
75e825d
+POPPLER_VERSION should be defined.
75e825d
+*/
75e825d
+
75e825d
 #include <w2c/config.h>
75e825d
 
75e825d
 #include <stdlib.h>
75e825d
@@ -32,10 +40,7 @@ with this program.  If not, see 
75e825d
 #include <goo/gmem.h>
75e825d
 #include <goo/gfile.h>
75e825d
 #else
75e825d
-#include <aconf.h>
75e825d
-#include <GString.h>
75e825d
-#include <gmem.h>
75e825d
-#include <gfile.h>
75e825d
+#error POPPLER_VERSION should be defined.
75e825d
 #endif
75e825d
 #include <assert.h>
75e825d
 
75e825d
@@ -86,22 +91,20 @@ int main(int argc, char *argv[])
75e825d
             objgen = atoi(argv[3]);
75e825d
     }
75e825d
     xref = doc->getXRef();
75e825d
-    catalogDict.initNull();
75e825d
-    xref->getCatalog(&catalogDict);
75e825d
+    catalogDict = xref->getCatalog();
75e825d
     if (!catalogDict.isDict("Catalog")) {
75e825d
         fprintf(stderr, "No Catalog found\n");
75e825d
         exit(1);
75e825d
     }
75e825d
-    srcStream.initNull();
75e825d
+    srcStream = Object(objNull);
75e825d
     if (objnum == 0) {
75e825d
-        catalogDict.dictLookup("SourceObject", &srcStream);
75e825d
+        srcStream = catalogDict.dictLookup("SourceObject");
75e825d
         static char const_SourceFile[] = "SourceFile";
75e825d
         if (!srcStream.isStream(const_SourceFile)) {
75e825d
             fprintf(stderr, "No SourceObject found\n");
75e825d
             exit(1);
75e825d
         }
75e825d
-        srcName.initNull();
75e825d
-        srcStream.getStream()->getDict()->lookup("SourceName", &srcName);
75e825d
+        srcName = srcStream.getStream()->getDict()->lookup("SourceName");
75e825d
         if (!srcName.isString()) {
75e825d
             fprintf(stderr, "No SourceName found\n");
75e825d
             exit(1);
75e825d
@@ -110,7 +113,7 @@ int main(int argc, char *argv[])
75e825d
         // We cannot free srcName, as objname shares its string.
75e825d
         // srcName.free();
75e825d
     } else if (objnum > 0) {
75e825d
-        xref->fetch(objnum, objgen, &srcStream);
75e825d
+        srcStream = xref->fetch(objnum, objgen);
75e825d
         if (!srcStream.isStream()) {
75e825d
             fprintf(stderr, "Not a Stream object\n");
75e825d
             exit(1);
75e825d
@@ -160,26 +163,24 @@ int main(int argc, char *argv[])
75e825d
                 int localOffset = 0;
75e825d
                 Guint firstOffset;
75e825d
 
75e825d
-                assert(xref->fetch(e->offset, 0, &objStr)->isStream());
75e825d
-                nObjects = objStr.streamGetDict()->lookup("N", &obj1)->getInt();
75e825d
-                obj1.free();
75e825d
-                first = objStr.streamGetDict()->lookup("First", &obj1)->getInt();
75e825d
-                obj1.free();
75e825d
+                objStr = xref->fetch(e->offset, 0);
75e825d
+                assert(objStr.isStream());
75e825d
+                obj1 = objStr.streamGetDict()->lookup("N");
75e825d
+                nObjects = obj1.getInt();
75e825d
+                obj1 = objStr.streamGetDict()->lookup("First");
75e825d
+                first = obj1.getInt();
75e825d
                 firstOffset = objStr.getStream()->getBaseStream()->getStart() + first;
75e825d
 
75e825d
                 // parse the header: object numbers and offsets
75e825d
                 objStr.streamReset();
75e825d
-                obj1.initNull();
75e825d
-                str = new EmbedStream(objStr.getStream(), &obj1, gTrue, first);
75e825d
+                str = new EmbedStream(objStr.getStream(), Object(objNull), gTrue, first);
75e825d
                 lexer = new Lexer(xref, str);
75e825d
                 parser = new Parser(xref, lexer, gFalse);
75e825d
                 for (n = 0; n < nObjects; ++n) {
75e825d
-                    parser->getObj(&obj1);
75e825d
-                    parser->getObj(&obj2);
75e825d
+                    obj1 = parser->getObj();
75e825d
+                    obj2 = parser->getObj();
75e825d
                     if (n == e->gen)
75e825d
                         localOffset = obj2.getInt();
75e825d
-                    obj1.free();
75e825d
-                    obj2.free();
75e825d
                 }
75e825d
 #if defined(POPPLER_VERSION) || defined(XPDF304)
75e825d
                 while (str->getChar() != EOF) ;
75e825d
@@ -187,7 +188,6 @@ int main(int argc, char *argv[])
75e825d
                 lexer->skipToEOF();
75e825d
 #endif
75e825d
                 delete parser;
75e825d
-                objStr.free();
75e825d
 
75e825d
                 fprintf(outfile, "%.10lu 00000 n\n",
75e825d
                         (long unsigned)(firstOffset + localOffset));
75e825d
@@ -198,7 +198,6 @@ int main(int argc, char *argv[])
75e825d
         s->reset();
75e825d
         while ((c = s->getChar()) != EOF)
75e825d
             fputc(c, outfile);
75e825d
-        srcStream.free();
75e825d
     }
75e825d
     if (objnum == 0)
75e825d
         fprintf(stderr, "Source file extracted to %s\n", outname);
75e825d
@@ -207,7 +206,6 @@ int main(int argc, char *argv[])
75e825d
     else
75e825d
         fprintf(stderr, "Cross-reference table extracted to %s\n", outname);
75e825d
     fclose(outfile);
75e825d
-    catalogDict.free();
75e825d
     delete doc;
75e825d
     delete globalParams;
75e825d
 }