rpms / thunarx-python

Clone
Source Code
GIT

#1 remove specific python versions
Closed 3 years ago by nonamedotc. Opened 4 years ago by nonamedotc.
rpms/ nonamedotc/thunarx-python master  into  master

file modified
+7 -5 
@@ -13,7 +13,9 @@ 
 

  BuildRequires: Thunar-devel >= 1.8.0
 

  BuildRequires: pygobject3-devel >= 2.6.0
 

  BuildRequires: gtk-doc
 

- BuildRequires: python3 python3-devel
 

+ BuildRequires: python3 

+ BuildRequires: python3-devel
 

+ 

  # Renamed / Obsoleted in F32
 

  Provides:       python2-thunarx = %{version}-%{release}
 

  Provides:       python2-thunarx%{?_isa} = %{version}-%{release}
 
@@ -34,10 +36,10 @@ 
 

  %setup -q
 

  

  %build
 

- export PYTHON=/usr/bin/python3.8
 

- export PYTHON_LIBS=-lpython3.8
 

- export PKG_CONFIG_PATH=/usr/lib64/pkgconfig
 

- %configure --enable-gtk-doc --with-python3
 

+ export PYTHON=%{python3}
 

+ export PYTHON_LIBS=-lpython%{python3_version}
 

+ export PKG_CONFIG_PATH=%{_libdir}/pkgconfig
 

+ %configure --enable-gtk-doc
 

  %make_build
 

  

  %install

Fixes python 3.9 builds.

The 3.9 build fails: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/build/1169683/ -- seems like it's linking twice? cc @vstinner

Copy of the errors:

make[2]: Entering directory '/builddir/build/BUILD/thunarx-python-0.5.1/src'
/bin/sh ../libtool  --tag=CC   --mode=link gcc -I/usr/include/thunarx-3 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/fribidi -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -pthread   -I/usr/include/python3.9 -I/usr/include/python3.9 -I/usr/include/pygobject-3.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include                              -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -avoid-version -module   -I/usr/include/pygobject-3.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include                         -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--as-needed -Wl,-O1 -o thunarx-python.la -rpath /usr/lib64/thunarx-3 thunarx_python_la-thunarx-python.lo thunarx_python_la-thunarx-python-object.lo -lthunarx-3 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0  -lpython3.9 -lgobject-2.0 -lglib-2.0                          
libtool: link: gcc -shared  -fPIC -DPIC  .libs/thunarx_python_la-thunarx-python.o .libs/thunarx_python_la-thunarx-python-object.o   -lthunarx-3 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpython3.9 -lgobject-2.0 -lglib-2.0 -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -pthread -O2 -g -fstack-protector-strong -grecord-gcc-switches -m64 -mtune=generic -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -Wl,--as-needed -Wl,-O1   -pthread -Wl,-soname -Wl,thunarx-python.so -o .libs/thunarx-python.so
make[2]: Leaving directory '/builddir/build/BUILD/thunarx-python-0.5.1/src'
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/usr/include/pygobject-3.0/pygobject.h:230: multiple definition of `_PyGObject_API'; .libs/thunarx_python_la-thunarx-python.o:/usr/include/pygobject-3.0/pygobject.h:230: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:64: multiple definition of `_PyThunarxPropertyPage_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:64: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:52: multiple definition of `_PyThunarxMenuItem_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:52: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:73: multiple definition of `_PyThunarxRenamer_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:73: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:67: multiple definition of `_PyThunarxPropertyPageProvider_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:67: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:58: multiple definition of `_PyThunarxMenuProvider_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:58: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:76: multiple definition of `_PyThunarxRenamerProvider_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:76: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:61: multiple definition of `_PyThunarxPreferencesProvider_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:61: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:70: multiple definition of `_PyThunarxProviderPlugin_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:70: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:55: multiple definition of `_PyThunarxMenu_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:55: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:49: multiple definition of `_PyThunarxFileInfo_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:49: first defined here
/usr/bin/ld: .libs/thunarx_python_la-thunarx-python-object.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:46: multiple definition of `_PyGtkWidget_Type'; .libs/thunarx_python_la-thunarx-python.o:/builddir/build/BUILD/thunarx-python-0.5.1/src/thunarx-python.h:46: first defined here

libtool says "(...) .libs/thunarx_python_la-thunarx-python.o .libs/thunarx_python_la-thunarx-python-object.o (...)" it looks strange to pass the same .o object twice. This issue doesn't seem to be related to Python, is it?

Sounds like new gcc 10 behavior.

And see a similar problem in different package: https://bugzilla.redhat.com/show_bug.cgi?id=1793470

libtool says "(...) .libs/thunarx_python_la-thunarx-python.o .libs/thunarx_python_la-thunarx-python-object.o (...)" it looks strange to pass the same .o object twice.

Oh sorry, thunarx_python_la-thunarx-python.o is different than thunarx_python_la-thunarx-python-object.o. I misread the filenames.

No idea where multiple definition of _PyThunarxPropertyPage_Type error comes from.

And see a similar problem in different package: https://bugzilla.redhat.com/show_bug.cgi?id=1793470

I have fixed that hopefully :-)

https://github.com/linuxmint/nemo-extensions/pull/352

I could not work on this earlier. I will try a patch in the next couple of days.

I have a patch locally. I will close this and build on python 3.9 side tag

Thanks for your nemo extensions patch Leigh!

Pull-Request has been closed by nonamedotc
3 years ago
Metadata
None
No Tags
Changes Summary 1
+7 -5
file changed
thunarx-python.spec
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.