#1 Use standard Fedora linker flags.
Closed 2 years ago by pbrobinson. Opened 6 years ago by rdossant.
rpms/ rdossant/uboot-tools master  into  rawhide

file modified
+8 -5
@@ -2,7 +2,7 @@ 

  

  Name:      uboot-tools

  Version:   2018.05

- Release:   0.2%{?candidate:.%{candidate}}%{?dist}

+ Release:   0.3%{?candidate:.%{candidate}}%{?dist}

  Summary:   U-Boot utilities

  License:   GPLv2+ BSD LGPL-2.1+ LGPL-2.0+

  URL:       http://www.denx.de/wiki/U-Boot
@@ -125,18 +125,18 @@ 

    fi

    # End ATF

    make $(echo $board)_defconfig O=builds/$(echo $board)/

-   make HOSTCC="gcc $RPM_OPT_FLAGS" CROSS_COMPILE="" %{?_smp_mflags} V=1 O=builds/$(echo $board)/

+   make HOSTCC="gcc $RPM_OPT_FLAGS $RPM_LD_FLAGS" CROSS_COMPILE="" %{?_smp_mflags} V=1 O=builds/$(echo $board)/

    rk33xx=(evb-rk3399 firefly-rk3399)

    if [[ " ${rk33xx[*]} " == *" $board "* ]]; then

      echo "Board: $board using rk33xx"

-     make HOSTCC="gcc $RPM_OPT_FLAGS" CROSS_COMPILE="" u-boot.itb V=1 O=builds/$(echo $board)/

+     make HOSTCC="gcc $RPM_OPT_FLAGS $RPM_LD_FLAGS" CROSS_COMPILE="" u-boot.itb V=1 O=builds/$(echo $board)/

    fi

  done

  

  %endif

  

- make HOSTCC="gcc $RPM_OPT_FLAGS" %{?_smp_mflags} CROSS_COMPILE="" defconfig V=1 O=builds/

- make HOSTCC="gcc $RPM_OPT_FLAGS" %{?_smp_mflags} CROSS_COMPILE="" tools-all V=1 O=builds/

+ make HOSTCC="gcc $RPM_OPT_FLAGS $RPM_LD_FLAGS" %{?_smp_mflags} CROSS_COMPILE="" defconfig V=1 O=builds/

+ make HOSTCC="gcc $RPM_OPT_FLAGS $RPM_LD_FLAGS" %{?_smp_mflags} CROSS_COMPILE="" tools-all V=1 O=builds/

  

  %install

  mkdir -p $RPM_BUILD_ROOT%{_bindir}
@@ -289,6 +289,9 @@ 

  %endif

  

  %changelog

+ * Wed Apr 18 2018 Rafael dos Santos <rdossant@redhat.com> - 2018.05-0.3.rc2

+ - Use standard Fedora linker flags (bug #1543966)

+ 

  * Tue Apr 17 2018 Peter Robinson <pbrobinson@fedoraproject.org> 2018.05-0.2-rc2

  - 2018.05 RC2

  - Enable Raspberry Pi option to use firmware DT

  • Resolves #1543966

Signed-off-by: Rafael dos Santos rdossant@redhat.com

Have you tested the firmware builds on any actual devices? Most of these are firmware. The change on line ~28 of the patch looks correct for the tools side of things that the bug is reporting but I would have concern about the actual device firmware with out wide testing of functionality and that's hard across 150 odd devices

Pull-Request has been closed by pbrobinson

2 years ago