Mark Wielaard c728a33
--- valgrind/coregrind/m_debuginfo/readelf.c	(revision 12871)
Mark Wielaard c728a33
+++ valgrind/coregrind/m_debuginfo/readelf.c	(working copy)
Mark Wielaard 56078f1
@@ -888,7 +888,7 @@
Mark Wielaard 56078f1
  * http://fedoraproject.org/wiki/RolandMcGrath/BuildID
Mark Wielaard 56078f1
  */
Mark Wielaard 56078f1
 static
Mark Wielaard 56078f1
-Char *find_buildid(Addr image, UWord n_image, Bool rel_ok)
Mark Wielaard 56078f1
+Char *find_buildid(Addr image, UWord n_image, Bool rel_ok, Bool search_shdrs)
Mark Wielaard 56078f1
 {
Mark Wielaard 56078f1
    Char* buildid = NULL;
Mark Wielaard 56078f1
    __attribute__((unused)) /* on Android, at least */
Mark Wielaard 56078f1
@@ -930,7 +930,11 @@
Mark Wielaard 56078f1
          }
Mark Wielaard 56078f1
       }
Mark Wielaard 56078f1
 
Mark Wielaard 56078f1
-      if (buildid || !rel_ok)
Mark Wielaard 56078f1
+      /* Normally we would only search shdrs for ET_REL files, but when
Mark Wielaard 56078f1
+         we search for a separate .debug file phdrs might not be there
Mark Wielaard 56078f1
+         (they are never loaded) or have been corrupted, so try again
Mark Wielaard 56078f1
+         against shdrs. */
Mark Wielaard 56078f1
+      if (buildid || (!rel_ok && !search_shdrs))
Mark Wielaard 56078f1
          return buildid;
Mark Wielaard 56078f1
 
Mark Wielaard 56078f1
       for (i = 0; i < ehdr->e_shnum; i++) {
Mark Wielaard 56078f1
@@ -1074,7 +1078,7 @@
Mark Wielaard 56078f1
       return 0;
Mark Wielaard 56078f1
 
Mark Wielaard 56078f1
    if (buildid) {
Mark Wielaard 56078f1
-      Char* debug_buildid = find_buildid(sr_Res(sres), *size, rel_ok);
Mark Wielaard 56078f1
+      Char* debug_buildid = find_buildid(sr_Res(sres), *size, rel_ok, True);
Mark Wielaard 56078f1
       if (debug_buildid == NULL || VG_(strcmp)(buildid, debug_buildid) != 0) {
Mark Wielaard 56078f1
          SysRes res = VG_(am_munmap_valgrind)(sr_Res(sres), *size);
Mark Wielaard 56078f1
          vg_assert(!sr_isError(res));
Mark Wielaard 56078f1
@@ -2274,7 +2278,7 @@
Mark Wielaard 56078f1
       vg_assert(dimage == 0 && n_dimage == 0);
Mark Wielaard 56078f1
 
Mark Wielaard 56078f1
       /* Look for a build-id */
Mark Wielaard 56078f1
-      buildid = find_buildid(oimage, n_oimage, False);
Mark Wielaard 56078f1
+      buildid = find_buildid(oimage, n_oimage, False, False);
Mark Wielaard 56078f1
 
Mark Wielaard 56078f1
       /* Look for a debug image */
Mark Wielaard 56078f1
       if (buildid != NULL || debuglink_img != NULL) {