From 842835b3120d5c0825fa30f7dcc9c4090454c7e2 Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Thu, 3 Apr 2014 10:30:37 -0400 Subject: [PATCH] details: Fix showing vcpus values in 'customize' dialog (bz 1083903) (cherry picked from commit ee6a541167b787a84cc5c7e553089cbd5ab9ada3) --- virtManager/details.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/virtManager/details.py b/virtManager/details.py index c1833ae..ea9d91a 100644 --- a/virtManager/details.py +++ b/virtManager/details.py @@ -2533,6 +2533,12 @@ class vmmDetails(vmmGObjectUI): self.vm.network_traffic_vector()) def refresh_config_cpu(self): + # This bit needs to come first, since CPU values can be affected + # by whether topology is enabled + cpu = self.vm.get_cpu_config() + show_top = bool(cpu.sockets or cpu.cores or cpu.threads) + self.widget("cpu-topology-enable").set_active(show_top) + conn = self.vm.conn host_active_count = conn.host_active_processor_count() maxvcpus = self.vm.vcpu_max_count() @@ -2550,13 +2556,10 @@ class vmmDetails(vmmGObjectUI): self.widget("config-vcpus-warn-box").set_visible(warn) # CPU model config - cpu = self.vm.get_cpu_config() - show_top = bool(cpu.sockets or cpu.cores or cpu.threads) sockets = cpu.sockets or 1 cores = cpu.cores or 1 threads = cpu.threads or 1 - self.widget("cpu-topology-enable").set_active(show_top) self.widget("cpu-sockets").set_value(sockets) self.widget("cpu-cores").set_value(cores) self.widget("cpu-threads").set_value(threads)