From c809170f42582f3f02fbcc10e5157ebae9efd0ce Mon Sep 17 00:00:00 2001

From: Debarshi Ray <debarshir@gnome.org>

Date: Wed, 7 Jan 2015 16:01:00 +0100

Subject: [PATCH 01/11] Add sequences and signals for desktop notification

Add sequences

  OSC 777 ; notify ; SUMMARY ; BODY BEL

  OSC 777 ; notify ; SUMMARY BEL

  OSC 777 ; notify ; SUMMARY ; BODY ST

  OSC 777 ; notify ; SUMMARY ST

that let terminal applications send a notification to the desktop

environment.

Based on Enlightenment's Terminology:

https://phab.enlightenment.org/T1765

https://bugzilla.gnome.org/show_bug.cgi?id=711059

---

 src/marshal.list      |  1 +

 src/vte.cc            |  8 ++++++++

 src/vte/vteterminal.h |  4 +++-

 src/vtegtk.cc         | 21 +++++++++++++++++++++

 src/vtegtk.hh         |  1 +

 src/vteinternal.hh    |  8 ++++++++

 src/vteseq.cc         | 32 +++++++++++++++++++++++++++++++-

 7 files changed, 73 insertions(+), 2 deletions(-)

diff --git a/src/marshal.list b/src/marshal.list

index 241128c3..4412cf3d 100644

--- a/src/marshal.list

+++ b/src/marshal.list

@@ -1,3 +1,4 @@

 VOID:STRING,BOXED

+VOID:STRING,STRING

 VOID:STRING,UINT

 VOID:UINT,UINT

diff --git a/src/vte.cc b/src/vte.cc

index 8b75883f..05cc5589 100644

--- a/src/vte.cc

+++ b/src/vte.cc

@@ -10032,6 +10032,14 @@ Terminal::emit_pending_signals()

 	emit_adjustment_changed();

+        if (m_pending_changes & vte::to_integral(PendingChanges::NOTIFICATION)) {

+                _vte_debug_print (VTE_DEBUG_SIGNALS,

+                                  "Emitting `notification-received'.\n");

+                g_signal_emit(freezer.get(), signals[SIGNAL_NOTIFICATION_RECEIVED], 0,

+                              m_notification_summary.c_str(),

+                              m_notification_body.c_str());

+        }

+

 	if (m_pending_changes & vte::to_integral(PendingChanges::TITLE)) {

                 if (m_window_title != m_window_title_pending) {

                         m_window_title.swap(m_window_title_pending);

diff --git a/src/vte/vteterminal.h b/src/vte/vteterminal.h

index 41f153d0..1e9a737a 100644

--- a/src/vte/vteterminal.h

+++ b/src/vte/vteterminal.h

@@ -108,10 +108,12 @@ struct _VteTerminalClass {

 	void (*bell)(VteTerminal* terminal);

+	void (*notification_received)(VteTerminal* terminal, const gchar *summary, const gchar *body);

+

 #if _VTE_GTK == 3

         /* Compatibility padding due to fedora patches intruding on our ABI */

         /*< private >*/

-        gpointer _extra_padding[3];

+        gpointer _extra_padding[2];

 #endif /* _VTE_GTK == 3 */

         /* Add new vfuncs here, and subtract from the padding below. */

diff --git a/src/vtegtk.cc b/src/vtegtk.cc

index 05b82294..a09a2f75 100644

--- a/src/vtegtk.cc

+++ b/src/vtegtk.cc

@@ -1242,6 +1242,7 @@ vte_terminal_class_init(VteTerminalClass *klass)

 	klass->child_exited = NULL;

 	klass->encoding_changed = NULL;

 	klass->char_size_changed = NULL;

+	klass->notification_received = NULL;

 	klass->window_title_changed = NULL;

 	klass->icon_title_changed = NULL;

 	klass->selection_changed = NULL;

@@ -1325,6 +1326,26 @@ vte_terminal_class_init(VteTerminalClass *klass)

                                    G_OBJECT_CLASS_TYPE(klass),

                                    g_cclosure_marshal_VOID__INTv);

+        /**

+         * VteTerminal::notification-received:

+         * @vteterminal: the object which received the signal

+         * @summary: The summary

+         * @body: (allow-none): Extra optional text

+         *

+         * Emitted when a process running in the terminal wants to

+         * send a notification to the desktop environment.

+         */

+        signals[SIGNAL_NOTIFICATION_RECEIVED] =

+                g_signal_new(I_("notification-received"),

+                             G_OBJECT_CLASS_TYPE(klass),

+                             G_SIGNAL_RUN_LAST,

+                             G_STRUCT_OFFSET(VteTerminalClass, notification_received),

+                             NULL,

+                             NULL,

+                             _vte_marshal_VOID__STRING_STRING,

+                             G_TYPE_NONE,

+                             2, G_TYPE_STRING, G_TYPE_STRING);

+

         /**

          * VteTerminal::window-title-changed:

          * @vteterminal: the object which received the signal

diff --git a/src/vtegtk.hh b/src/vtegtk.hh

index 6b7a1ea2..8ba10395 100644

--- a/src/vtegtk.hh

+++ b/src/vtegtk.hh

@@ -52,6 +52,7 @@ enum {

         SIGNAL_RESIZE_WINDOW,

         SIGNAL_RESTORE_WINDOW,

         SIGNAL_SELECTION_CHANGED,

+        SIGNAL_NOTIFICATION_RECEIVED,

         SIGNAL_WINDOW_TITLE_CHANGED,

         LAST_SIGNAL

 };

diff --git a/src/vteinternal.hh b/src/vteinternal.hh

index eb95ad68..69a32276 100644

--- a/src/vteinternal.hh

+++ b/src/vteinternal.hh

@@ -660,6 +660,10 @@ public:

         gboolean m_cursor_moved_pending;

         gboolean m_contents_changed_pending;

+        /* desktop notification */

+        std::string m_notification_summary;

+        std::string m_notification_body;

+

         std::string m_window_title{};

         std::string m_current_directory_uri{};

         std::string m_current_file_uri{};

@@ -673,6 +677,7 @@ public:

                 TITLE = 1u << 0,

                 CWD   = 1u << 1,

                 CWF   = 1u << 2,

+                NOTIFICATION = 1u << 3,

         };

         unsigned m_pending_changes{0};

@@ -1488,6 +1493,9 @@ public:

                              int osc) noexcept;

         /* OSC handlers */

+        void handle_urxvt_extension(vte::parser::Sequence const& seq,

+                                    vte::parser::StringTokeniser::const_iterator& token,

+                                    vte::parser::StringTokeniser::const_iterator const& endtoken) noexcept;

         void set_color(vte::parser::Sequence const& seq,

                        vte::parser::StringTokeniser::const_iterator& token,

                        vte::parser::StringTokeniser::const_iterator const& endtoken,

diff --git a/src/vteseq.cc b/src/vteseq.cc

index 874d2405..537e8e13 100644

--- a/src/vteseq.cc

+++ b/src/vteseq.cc

@@ -1376,6 +1376,33 @@ Terminal::delete_lines(vte::grid::row_t param)

         m_text_deleted_flag = TRUE;

 }

+void

+Terminal::handle_urxvt_extension(vte::parser::Sequence const& seq,

+                                 vte::parser::StringTokeniser::const_iterator& token,

+                                 vte::parser::StringTokeniser::const_iterator const& endtoken) noexcept

+{

+        if (token == endtoken)

+                return;

+

+        if (*token == "notify") {

+                ++token;

+

+                if (token == endtoken)

+                        return;

+

+                m_notification_summary = *token;

+                m_notification_body.clear();

+                m_pending_changes |= vte::to_integral(PendingChanges::NOTIFICATION);

+                ++token;

+

+                if (token == endtoken)

+                        return;

+

+                m_notification_body = *token;

+                return;

+        }

+}

+

 bool

 Terminal::get_osc_color_index(int osc,

                                         int value,

@@ -6541,6 +6568,10 @@ Terminal::OSC(vte::parser::Sequence const& seq)

                 reset_color(VTE_HIGHLIGHT_FG, VTE_COLOR_SOURCE_ESCAPE);

                 break;

+        case VTE_OSC_URXVT_EXTENSION:

+                handle_urxvt_extension(seq, it, cend);

+                break;

+

         case VTE_OSC_XTERM_SET_ICON_TITLE:

         case VTE_OSC_XTERM_SET_XPROPERTY:

         case VTE_OSC_XTERM_SET_COLOR_MOUSE_CURSOR_FG:

@@ -6582,7 +6613,6 @@ Terminal::OSC(vte::parser::Sequence const& seq)

         case VTE_OSC_URXVT_SET_FONT_BOLD_ITALIC:

         case VTE_OSC_URXVT_VIEW_UP:

         case VTE_OSC_URXVT_VIEW_DOWN:

-        case VTE_OSC_URXVT_EXTENSION:

         case VTE_OSC_YF_RQGWR:

         default:

                 break;

-- 

2.35.1

From 05a642746f1c3985ea204571e0179a1147dda1a9 Mon Sep 17 00:00:00 2001

From: Debarshi Ray <debarshir@gnome.org>

Date: Thu, 29 Jan 2015 13:09:17 +0100

Subject: [PATCH 02/11] vte.sh: Emit OSC 777 from PROMPT_COMMAND

For some reason, the three consecutive backslashes break the parsing.

As Christian Persch suggested, replacing the double quotes with

singles fixes it.

https://bugzilla.gnome.org/show_bug.cgi?id=711059

---

 src/vte.sh.in | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/vte.sh.in b/src/vte.sh.in

index 242d6c42..50242223 100644

--- a/src/vte.sh.in

+++ b/src/vte.sh.in

@@ -33,10 +33,12 @@ __vte_osc7 () {

 }

 __vte_prompt_command() {

+  local command=$(HISTTIMEFORMAT= history 1 | sed 's/^ *[0-9]\+ *//')

+  command="${command//;/ }"

   local pwd='~'

   [ "$PWD" != "$HOME" ] && pwd=${PWD/#$HOME\//\~\/}

   pwd="${pwd//[[:cntrl:]]}"

-  printf "\033]0;%s@%s:%s\033\\" "${USER}" "${HOSTNAME%%.*}" "${pwd}"

+  printf '\033]777;notify;Command completed;%s\033\\\033]0;%s@%s:%s\033\\' "${command}" "${USER}" "${HOSTNAME%%.*}" "${pwd}"

   __vte_osc7

 }

-- 

2.35.1

From d0cca4421d0108b0f9e23ea03ea5e99f745646a6 Mon Sep 17 00:00:00 2001

From: Debarshi Ray <debarshir@gnome.org>

Date: Thu, 22 Jan 2015 16:37:10 +0100

Subject: [PATCH 03/11] Test the notification-received signal

---

 bindings/vala/app.vala |  7 +++++++

 src/app/app.cc         | 10 ++++++++++

 2 files changed, 17 insertions(+)

diff --git a/bindings/vala/app.vala b/bindings/vala/app.vala

index 4bcb5804..06546440 100644

--- a/bindings/vala/app.vala

+++ b/bindings/vala/app.vala

@@ -309,6 +309,8 @@ class Window : Gtk.ApplicationWindow

     if (Options.object_notifications)

       terminal.notify.connect(notify_cb);

+    terminal.notification_received.connect(notification_received_cb);

+

     /* Settings */

     if (Options.no_double_buffer)

       terminal.set_double_buffered(false);

@@ -780,6 +782,11 @@ class Window : Gtk.ApplicationWindow

     set_title(terminal.get_window_title());

   }

+  private void notification_received_cb(Vte.Terminal terminal, string summary, string? body)

+  {

+    print ("[%s]: %s\n", summary, body);

+  }

+

 } /* class Window */

 class App : Gtk.Application

diff --git a/src/app/app.cc b/src/app/app.cc

index 3b7835aa..fc8220a5 100644

--- a/src/app/app.cc

+++ b/src/app/app.cc

@@ -2209,6 +2209,14 @@ window_window_title_changed_cb(VteTerminal* terminal,

         gtk_window_set_title(GTK_WINDOW(window), title && title[0] ? title : "Terminal");

 }

+static void

+notification_received_cb(VteTerminal *terminal,

+                         const gchar *summary,

+                         const gchar *body)

+{

+        g_print("[%s]: %s\n", summary, body);

+}

+

 static void

 window_lower_window_cb(VteTerminal* terminal,

                        VteappWindow* window)

@@ -2505,6 +2513,8 @@ vteapp_window_constructed(GObject *object)

         if (options.object_notifications)

                 g_signal_connect(window->terminal, "notify", G_CALLBACK(window_notify_cb), window);

+        g_signal_connect(window->terminal, "notification-received", G_CALLBACK(notification_received_cb), NULL);

+

         /* Settings */

 #if VTE_GTK == 3

         if (options.no_double_buffer) {

-- 

2.35.1

From e87bc628fdecf7480c12b861ba3fb98b03abe4d9 Mon Sep 17 00:00:00 2001

From: Debarshi Ray <debarshir@gnome.org>

Date: Fri, 13 May 2016 17:53:54 +0200

Subject: [PATCH 04/11] Add a property to configure the scroll speed

By default, it is set to zero which gives the current behaviour of

moving the buffer by a function of the number of visible rows.

https://bugzilla.redhat.com/show_bug.cgi?id=1103380

---

 doc/reference/vte-sections.txt.in |  1 +

 src/vte.cc                        | 19 +++++++++++-

 src/vte/vteterminal.h             |  4 +++

 src/vtegtk.cc                     | 51 +++++++++++++++++++++++++++++++

 src/vtegtk.hh                     |  1 +

 src/vteinternal.hh                |  2 ++

 6 files changed, 77 insertions(+), 1 deletion(-)

diff --git a/doc/reference/vte-sections.txt.in b/doc/reference/vte-sections.txt.in

index 283dd056..64907389 100644

--- a/doc/reference/vte-sections.txt.in

+++ b/doc/reference/vte-sections.txt.in

@@ -58,6 +58,7 @@ vte_terminal_get_cursor_blink_mode

 vte_terminal_set_cursor_blink_mode

 vte_terminal_get_text_blink_mode

 vte_terminal_set_text_blink_mode

+vte_terminal_set_scroll_speed

 vte_terminal_set_scrollback_lines

 vte_terminal_get_scrollback_lines

 vte_terminal_set_font

diff --git a/src/vte.cc b/src/vte.cc

index 05cc5589..a4e6069d 100644

--- a/src/vte.cc

+++ b/src/vte.cc

@@ -9239,6 +9239,7 @@ vte_cairo_get_clip_region(cairo_t *cr)

 bool

 Terminal::widget_mouse_scroll(vte::platform::ScrollEvent const& event)

 {

+	gdouble scroll_speed;

 	gdouble v;

 	gint cnt, i;

 	int button;

@@ -9273,7 +9274,13 @@ Terminal::widget_mouse_scroll(vte::platform::ScrollEvent const& event)

 		return true;

 	}

-        v = MAX (1., ceil (m_row_count /* page increment */ / 10.));

+	if (m_scroll_speed == 0) {

+		scroll_speed = ceil (m_row_count /* page increment */ / 10.);

+	} else {

+		scroll_speed = m_scroll_speed;

+	}

+

+	v = MAX (1., scroll_speed);

 	_vte_debug_print(VTE_DEBUG_EVENTS,

 			"Scroll speed is %d lines per non-smooth scroll unit\n",

 			(int) v);

@@ -9583,6 +9590,16 @@ Terminal::decscusr_cursor_shape() const noexcept

         }

 }

+bool

+Terminal::set_scroll_speed(unsigned int scroll_speed)

+{

+        if (scroll_speed == m_scroll_speed)

+                return false;

+

+        m_scroll_speed = scroll_speed;

+        return true;

+}

+

 bool

 Terminal::set_scrollback_lines(long lines)

 {

diff --git a/src/vte/vteterminal.h b/src/vte/vteterminal.h

index 1e9a737a..b63967a3 100644

--- a/src/vte/vteterminal.h

+++ b/src/vte/vteterminal.h

@@ -330,6 +330,10 @@ void vte_terminal_set_cursor_shape(VteTerminal *terminal,

 _VTE_PUBLIC

 VteCursorShape vte_terminal_get_cursor_shape(VteTerminal *terminal) _VTE_CXX_NOEXCEPT _VTE_GNUC_NONNULL(1);

+_VTE_PUBLIC

+void vte_terminal_set_scroll_speed(VteTerminal *terminal,

+                                   guint scroll_speed) _VTE_CXX_NOEXCEPT _VTE_GNUC_NONNULL(1);

+

 /* Set the number of scrollback lines, above or at an internal minimum. */

 _VTE_PUBLIC

 void vte_terminal_set_scrollback_lines(VteTerminal *terminal,

diff --git a/src/vtegtk.cc b/src/vtegtk.cc

index a09a2f75..ab1de923 100644

--- a/src/vtegtk.cc

+++ b/src/vtegtk.cc

@@ -993,6 +993,9 @@ try

                 case PROP_REWRAP_ON_RESIZE:

                         g_value_set_boolean (value, vte_terminal_get_rewrap_on_resize (terminal));

                         break;

+                case PROP_SCROLL_SPEED:

+                        g_value_set_uint (value, impl->m_scroll_speed);

+                        break;

                 case PROP_SCROLLBACK_LINES:

                         g_value_set_uint (value, vte_terminal_get_scrollback_lines(terminal));

                         break;

@@ -1114,6 +1117,9 @@ try

                 case PROP_REWRAP_ON_RESIZE:

                         vte_terminal_set_rewrap_on_resize (terminal, g_value_get_boolean (value));

                         break;

+                case PROP_SCROLL_SPEED:

+                        vte_terminal_set_scroll_speed (terminal, g_value_get_uint (value));

+                        break;

                 case PROP_SCROLLBACK_LINES:

                         vte_terminal_set_scrollback_lines (terminal, g_value_get_uint (value));

                         break;

@@ -2210,6 +2216,21 @@ vte_terminal_class_init(VteTerminalClass *klass)

                                       TRUE,

                                       (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_EXPLICIT_NOTIFY));

+        /**

+         * VteTerminal:scroll-speed:

+         *

+         * The number of lines by which the buffer is moved when

+         * scrolling with a mouse wheel on top of the terminal

+         * Setting it to zero will cause the buffer to be moved by an

+         * amount depending on the number of visible rows the widget

+         * can display.

+         */

+        pspecs[PROP_SCROLL_SPEED] =

+                g_param_spec_uint ("scroll-speed", NULL, NULL,

+                                   0, G_MAXUINT,

+                                   0,

+                                   (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_EXPLICIT_NOTIFY));

+

         /**

          * VteTerminal:scrollback-lines:

          *

@@ -5726,6 +5747,36 @@ catch (...)

         return -1;

 }

+/**

+ * vte_terminal_set_scroll_speed:

+ * @terminal: a #VteTerminal

+ * @scroll_speed: move the buffer by this number of lines while scrolling

+ *

+ * Sets the number of lines by which the buffer is moved when

+ * scrolling with a mouse wheel. Setting it to zero will cause the

+ * buffer to be moved by an amount depending on the number of visible

+ * rows the widget can display.

+ */

+void

+vte_terminal_set_scroll_speed(VteTerminal *terminal,

+                              guint scroll_speed) noexcept

+try

+{

+        g_return_if_fail(VTE_IS_TERMINAL(terminal));

+

+        GObject *object = G_OBJECT(terminal);

+        g_object_freeze_notify(object);

+

+        if (IMPL(terminal)->set_scroll_speed(scroll_speed))

+                g_object_notify_by_pspec(object, pspecs[PROP_SCROLL_SPEED]);

+

+        g_object_thaw_notify(object);

+}

+catch (...)

+{

+        vte::log_exception();

+}

+

 /**

  * vte_terminal_set_scrollback_lines:

  * @terminal: a #VteTerminal

diff --git a/src/vtegtk.hh b/src/vtegtk.hh

index 8ba10395..f6cd891b 100644

--- a/src/vtegtk.hh

+++ b/src/vtegtk.hh

@@ -86,6 +86,7 @@ enum {

         PROP_MOUSE_POINTER_AUTOHIDE,

         PROP_PTY,

         PROP_REWRAP_ON_RESIZE,

+        PROP_SCROLL_SPEED,

         PROP_SCROLLBACK_LINES,

         PROP_SCROLL_ON_KEYSTROKE,

         PROP_SCROLL_ON_OUTPUT,

diff --git a/src/vteinternal.hh b/src/vteinternal.hh

index 69a32276..d3e25179 100644

--- a/src/vteinternal.hh

+++ b/src/vteinternal.hh

@@ -426,6 +426,7 @@ public:

         bool m_fallback_scrolling{true};

         bool m_scroll_on_output{false};

         bool m_scroll_on_keystroke{true};

+        guint m_scroll_speed;

         vte::grid::row_t m_scrollback_lines{0};

         inline auto scroll_limit_lower() const noexcept

@@ -1363,6 +1364,7 @@ public:

         bool set_input_enabled(bool enabled);

         bool set_mouse_autohide(bool autohide);

         bool set_rewrap_on_resize(bool rewrap);

+        bool set_scroll_speed(unsigned int scroll_speed);

         bool set_scrollback_lines(long lines);

         bool set_fallback_scrolling(bool set);

         auto fallback_scrolling() const noexcept { return m_fallback_scrolling; }

-- 

2.35.1

From f8a8d2adf1000720f269adb80473e8971bc51135 Mon Sep 17 00:00:00 2001

From: Debarshi Ray <debarshir@gnome.org>

Date: Fri, 13 May 2016 17:54:57 +0200

Subject: [PATCH 05/11] Test the scroll-speed property

https://bugzilla.redhat.com/show_bug.cgi?id=1103380

---

 bindings/vala/app.vala | 4 ++++

 src/app/app.cc         | 4 ++++

 2 files changed, 8 insertions(+)

diff --git a/bindings/vala/app.vala b/bindings/vala/app.vala

index 06546440..552a702d 100644

--- a/bindings/vala/app.vala

+++ b/bindings/vala/app.vala

@@ -335,6 +335,7 @@ class Window : Gtk.ApplicationWindow

     terminal.set_rewrap_on_resize(!Options.no_rewrap);

     terminal.set_scroll_on_output(false);

     terminal.set_scroll_on_keystroke(true);

+    terminal.set_scroll_speed(Options.scroll_speed);

     terminal.set_scrollback_lines(Options.scrollback_lines);

     /* Style */

@@ -857,6 +858,7 @@ class App : Gtk.Application

     public static bool object_notifications = false;

     public static string? output_filename = null;

     public static bool reverse = false;

+    public static uint scroll_speed = 0;

     public static int scrollback_lines = 512;

     public static int transparency_percent = 0;

     public static bool version = false;

@@ -1050,6 +1052,8 @@ class App : Gtk.Application

         "Save terminal contents to file at exit", null },

       { "reverse", 0, 0, OptionArg.NONE, ref reverse,

         "Reverse foreground/background colors", null },

+      { "scroll-speed", 0, 0, OptionArg.INT, ref scroll_speed,

+        "Specify the scroll speed", null },

       { "scrollback-lines", 'n', 0, OptionArg.INT, ref scrollback_lines,

         "Specify the number of scrollback-lines", null },

       { "transparent", 'T', 0, OptionArg.INT, ref transparency_percent,

diff --git a/src/app/app.cc b/src/app/app.cc

index fc8220a5..c6f5cc0b 100644

--- a/src/app/app.cc

+++ b/src/app/app.cc

@@ -118,6 +118,7 @@ public:

         int verbosity{0};

         double cell_height_scale{1.0};

         double cell_width_scale{1.0};

+        unsigned int scroll_speed{0};

         VteCursorBlinkMode cursor_blink_mode{VTE_CURSOR_BLINK_SYSTEM};

         VteCursorShape cursor_shape{VTE_CURSOR_SHAPE_BLOCK};

         VteTextBlinkMode text_blink_mode{VTE_TEXT_BLINK_ALWAYS};

@@ -620,6 +621,8 @@ public:

                           "Reverse foreground/background colors", nullptr },

                         { "require-systemd-scope", 0, 0, G_OPTION_ARG_NONE, &require_systemd_scope,

                           "Require use of a systemd user scope", nullptr },

+                        { "scroll-speed", 0, 0, G_OPTION_ARG_INT, &scroll_speed,

+                          "Specify the scroll speed", nullptr },

                         { "scroll-unit-is-pixels", 0, 0, G_OPTION_ARG_NONE, &scroll_unit_is_pixels,

                           "Use pixels as scroll unit", nullptr },

                         { "scrollback-lines", 'n', 0, G_OPTION_ARG_INT, &scrollback_lines,

@@ -2549,6 +2552,7 @@ vteapp_window_constructed(GObject *object)

         vte_terminal_set_rewrap_on_resize(window->terminal, !options.no_rewrap);

         vte_terminal_set_scroll_on_output(window->terminal, false);

         vte_terminal_set_scroll_on_keystroke(window->terminal, true);

+        vte_terminal_set_scroll_speed(window->terminal, options.scroll_speed);

         vte_terminal_set_scroll_unit_is_pixels(window->terminal, options.scroll_unit_is_pixels);

         vte_terminal_set_scrollback_lines(window->terminal, options.scrollback_lines);

         vte_terminal_set_text_blink_mode(window->terminal, options.text_blink_mode);

-- 

2.35.1

From 60d5670e793d2aa2ccda489e4e468bbc9c120908 Mon Sep 17 00:00:00 2001

From: Debarshi Ray <debarshir@gnome.org>

Date: Wed, 7 Jan 2015 16:01:00 +0100

Subject: [PATCH 06/11] Support preexec notifications from an interactive shell

Add sequences

  OSC 777 ; preexec BEL

  OSC 777 ; preexec ST

that can be used from an interactive shell's preexec hook to notify

the terminal emulator that a new command is about to be executed.

Examples of such hooks are Bash's PS0 and Zsh's preexec.

The OSC 777 escape sequence is taken from Enlightenment's Terminology:

https://phab.enlightenment.org/T1765

https://bugzilla.gnome.org/show_bug.cgi?id=711059

https://bugzilla.gnome.org/show_bug.cgi?id=711060

---

 src/vte.cc            |  6 ++++++

 src/vte.sh.in         |  4 ++--

 src/vte/vteterminal.h |  3 ++-

 src/vtegtk.cc         | 18 ++++++++++++++++++

 src/vtegtk.hh         |  1 +

 src/vteinternal.hh    |  1 +

 src/vteseq.cc         |  4 ++++

 7 files changed, 34 insertions(+), 3 deletions(-)

diff --git a/src/vte.cc b/src/vte.cc

index a4e6069d..6d8ab2bb 100644

--- a/src/vte.cc

+++ b/src/vte.cc

@@ -10057,6 +10057,12 @@ Terminal::emit_pending_signals()

                               m_notification_body.c_str());

         }

+        if (m_pending_changes & vte::to_integral(PendingChanges::SHELL_PREEXEC)) {

+                _vte_debug_print (VTE_DEBUG_SIGNALS,

+                                  "Emitting `shell-preexec'.\n");

+                g_signal_emit(freezer.get(), signals[SIGNAL_SHELL_PREEXEC], 0);

+        }

+

 	if (m_pending_changes & vte::to_integral(PendingChanges::TITLE)) {

                 if (m_window_title != m_window_title_pending) {

                         m_window_title.swap(m_window_title_pending);

diff --git a/src/vte.sh.in b/src/vte.sh.in

index 50242223..01b44e23 100644

--- a/src/vte.sh.in

+++ b/src/vte.sh.in

@@ -51,9 +51,9 @@ if [[ -n "${BASH_VERSION:-}" ]]; then

     # use the __vte_prompt_command function which also sets the title.

     if [[ "$(declare -p PROMPT_COMMAND 2>&1)" =~ "declare -a" ]]; then

-	PROMPT_COMMAND+=(__vte_osc7)

+	PROMPT_COMMAND+=(__vte_osc7) && PS0=$(printf "\033]777;preexec\033\\")

     else

-	PROMPT_COMMAND="__vte_prompt_command"

+	PROMPT_COMMAND="__vte_prompt_command" && PS0=$(printf "\033]777;preexec\033\\")

     fi

 elif [[ -n "${ZSH_VERSION:-}" ]]; then

diff --git a/src/vte/vteterminal.h b/src/vte/vteterminal.h

index b63967a3..062b6694 100644

--- a/src/vte/vteterminal.h

+++ b/src/vte/vteterminal.h

@@ -109,11 +109,12 @@ struct _VteTerminalClass {

 	void (*bell)(VteTerminal* terminal);

 	void (*notification_received)(VteTerminal* terminal, const gchar *summary, const gchar *body);

+	void (*shell_preexec)(VteTerminal* terminal);

 #if _VTE_GTK == 3

         /* Compatibility padding due to fedora patches intruding on our ABI */

         /*< private >*/

-        gpointer _extra_padding[2];

+        gpointer _extra_padding[1];

 #endif /* _VTE_GTK == 3 */

         /* Add new vfuncs here, and subtract from the padding below. */

diff --git a/src/vtegtk.cc b/src/vtegtk.cc

index ab1de923..a4d51bfb 100644

--- a/src/vtegtk.cc

+++ b/src/vtegtk.cc

@@ -1249,6 +1249,7 @@ vte_terminal_class_init(VteTerminalClass *klass)

 	klass->encoding_changed = NULL;

 	klass->char_size_changed = NULL;

 	klass->notification_received = NULL;

+	klass->shell_preexec = NULL;

 	klass->window_title_changed = NULL;

 	klass->icon_title_changed = NULL;

 	klass->selection_changed = NULL;

@@ -1352,6 +1353,23 @@ vte_terminal_class_init(VteTerminalClass *klass)

                              G_TYPE_NONE,

                              2, G_TYPE_STRING, G_TYPE_STRING);

+        /**

+         * VteTerminal::shell-preexec:

+         * @vteterminal: the object which received the signal

+         *

+         * Emitted when the interactive shell has read in a complete

+         * command and is about to execute it.

+         */

+        signals[SIGNAL_SHELL_PREEXEC] =

+                g_signal_new(I_("shell-preexec"),

+                             G_OBJECT_CLASS_TYPE(klass),

+                             G_SIGNAL_RUN_LAST,

+                             G_STRUCT_OFFSET(VteTerminalClass, shell_preexec),

+                             NULL,

+                             NULL,

+                             g_cclosure_marshal_VOID__VOID,

+                             G_TYPE_NONE, 0);

+

         /**

          * VteTerminal::window-title-changed:

          * @vteterminal: the object which received the signal

diff --git a/src/vtegtk.hh b/src/vtegtk.hh

index f6cd891b..bf85bdf4 100644

--- a/src/vtegtk.hh

+++ b/src/vtegtk.hh

@@ -52,6 +52,7 @@ enum {

         SIGNAL_RESIZE_WINDOW,

         SIGNAL_RESTORE_WINDOW,

         SIGNAL_SELECTION_CHANGED,

+        SIGNAL_SHELL_PREEXEC,

         SIGNAL_NOTIFICATION_RECEIVED,

         SIGNAL_WINDOW_TITLE_CHANGED,

         LAST_SIGNAL

diff --git a/src/vteinternal.hh b/src/vteinternal.hh

index d3e25179..b4f1b4c9 100644

--- a/src/vteinternal.hh

+++ b/src/vteinternal.hh

@@ -679,6 +679,7 @@ public:

                 CWD   = 1u << 1,

                 CWF   = 1u << 2,

                 NOTIFICATION = 1u << 3,

+                SHELL_PREEXEC = 1u << 4,

         };

         unsigned m_pending_changes{0};

diff --git a/src/vteseq.cc b/src/vteseq.cc

index 537e8e13..dbc6276f 100644

--- a/src/vteseq.cc

+++ b/src/vteseq.cc

@@ -1401,6 +1401,10 @@ Terminal::handle_urxvt_extension(vte::parser::Sequence const& seq,

                 m_notification_body = *token;

                 return;

         }

+

+        if (*token == "preexec") {

+                m_pending_changes |= vte::to_integral(PendingChanges::SHELL_PREEXEC);

+        }

 }

 bool

-- 

2.35.1

From 9fe74c4f17f1fb708a90f22a64fd2b5f4aa794a9 Mon Sep 17 00:00:00 2001

From: Debarshi Ray <debarshir@gnome.org>

Date: Fri, 20 Apr 2018 18:21:53 +0200

Subject: [PATCH 07/11] Test the shell-preexec signal

https://bugzilla.gnome.org/show_bug.cgi?id=711059

https://bugzilla.gnome.org/show_bug.cgi?id=711060

---

 bindings/vala/app.vala | 6 ++++++

 src/app/app.cc         | 7 +++++++

 2 files changed, 13 insertions(+)

diff --git a/bindings/vala/app.vala b/bindings/vala/app.vala

index 552a702d..cc30f9ad 100644

--- a/bindings/vala/app.vala

+++ b/bindings/vala/app.vala

@@ -310,6 +310,7 @@ class Window : Gtk.ApplicationWindow

       terminal.notify.connect(notify_cb);

     terminal.notification_received.connect(notification_received_cb);

+    terminal.shell_preexec.connect(shell_preexec_cb);

     /* Settings */

     if (Options.no_double_buffer)

@@ -788,6 +789,11 @@ class Window : Gtk.ApplicationWindow

     print ("[%s]: %s\n", summary, body);

   }

+  private void shell_preexec_cb(Vte.Terminal terminal)

+  {

+    print("[shell] executing command\n");

+  }

+

 } /* class Window */

 class App : Gtk.Application

diff --git a/src/app/app.cc b/src/app/app.cc

index c6f5cc0b..33a9481e 100644

--- a/src/app/app.cc

+++ b/src/app/app.cc

@@ -2220,6 +2220,12 @@ notification_received_cb(VteTerminal *terminal,

         g_print("[%s]: %s\n", summary, body);

 }

+static void

+shell_preexec_cb(VteTerminal *terminal)

+{

+        g_print("[shell] executing command\n");

+}

+

 static void

 window_lower_window_cb(VteTerminal* terminal,

                        VteappWindow* window)

@@ -2517,6 +2523,7 @@ vteapp_window_constructed(GObject *object)

                 g_signal_connect(window->terminal, "notify", G_CALLBACK(window_notify_cb), window);

         g_signal_connect(window->terminal, "notification-received", G_CALLBACK(notification_received_cb), NULL);

+        g_signal_connect(window->terminal, "shell-preexec", G_CALLBACK(shell_preexec_cb), NULL);

         /* Settings */

 #if VTE_GTK == 3

-- 

2.35.1

From ed2a83fbf034f79f7c08e8d5e4eeaaea2599e484 Mon Sep 17 00:00:00 2001

From: Debarshi Ray <debarshir@gnome.org>

Date: Wed, 2 May 2018 17:20:30 +0200

Subject: [PATCH 08/11] Support precmd notifications from an interactive shell

Add sequences

  OSC 777 ; precmd BEL

  OSC 777 ; precmd ST

that can be used from an interactive shell's precmd hook to notify the

terminal emulator that a first level prompt is about to be shown.

Examples of such hooks are Bash's PROMPT_COMMAND and Zsh's precmd.

The OSC 777 escape sequence is taken from Enlightenment's Terminology:

https://phab.enlightenment.org/T1765

https://bugzilla.gnome.org/show_bug.cgi?id=711059

https://bugzilla.gnome.org/show_bug.cgi?id=711060

---