#1 Add a build-time dependency on python2-devel
Merged 6 years ago by torsava. Opened 6 years ago by ishcherb.
rpms/ ishcherb/xcb-proto master  into  master

file modified
+6 -4
@@ -1,9 +1,8 @@ 

  %define debug_package %{nil}

- %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(0)")}

  

  Name:           xcb-proto

  Version:        1.12

- Release:        4%{?dist}

+ Release:        5%{?dist}

  Summary:        XCB protocol descriptions

  

  Group:          Development/Libraries
@@ -12,7 +11,7 @@ 

  Source0:        http://xcb.freedesktop.org/dist/%{name}-%{version}.tar.bz2

  BuildArch:      noarch

  

- BuildRequires:	python

+ BuildRequires:	python2-devel

  Requires:       pkgconfig

  

  %description
@@ -43,9 +42,12 @@ 

  %dir %{_datadir}/xcb/

  %{_datadir}/xcb/*.xsd

  %{_datadir}/xcb/*.xml

- %{python_sitelib}/xcbgen

+ %{python2_sitelib}/xcbgen

  

  %changelog

+ * Fri Aug 11 2017 Iryna Shcherbina <ishcherb@redhat.com> - 1.12-5

+ - Add a build-time dependency on python2-devel

+ 

  * Thu Jul 27 2017 Fedora Release Engineering <releng@fedoraproject.org> - 1.12-4

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild

  

A build-time dependency on python2-devel is missing.

This is the reason why the dependency on Python itself is not generated for xcb-proto-0:1.12-4.fc27:

$ dnf repoquery --disablerepo=* --enablerepo=rawhide --requires xcb-proto | grep python
<nothing>

According to Fedora Packaging Guidelines for Python [0], packages building for Python 2 need BuildRequires: python2-devel.

[0] https://fedoraproject.org/wiki/Packaging:Python#Dependencies

LGTM.
As this is blocking Fedora's Python 3 PortingDB, I'm merging the PR.

Pull-Request has been merged by torsava

6 years ago
Metadata