f37f50b
------------------------------------------------------------------------
f37f50b
*From*: 	P J P
f37f50b
*Subject*: 	[Qemu-devel] [PATCH 1/3] scsi: megasas: use appropriate
f37f50b
property buffer size
f37f50b
*Date*: 	Wed, 25 May 2016 16:01:29 +0530
f37f50b
f37f50b
------------------------------------------------------------------------
f37f50b
f37f50b
From: Prasad J Pandit <address@hidden>
f37f50b
f37f50b
When setting MegaRAID SAS controller properties via MegaRAID
f37f50b
Firmware Interface(MFI) commands, a user supplied size parameter
f37f50b
is used to set property value. Use appropriate size value to avoid
f37f50b
OOB access issues.
f37f50b
f37f50b
Reported-by: Li Qiang <address@hidden>
f37f50b
Signed-off-by: Prasad J Pandit <address@hidden>
f37f50b
---
f37f50b
 hw/scsi/megasas.c | 2 +-
f37f50b
 1 file changed, 1 insertion(+), 1 deletion(-)
f37f50b
f37f50b
diff --git a/tools/qemu-xen/hw/scsi/megasas.c b/tools/qemu-xen/hw/scsi/megasas.c
f37f50b
index a63a581..dcbd3e1 100644
f37f50b
--- a/tools/qemu-xen/hw/scsi/megasas.c
f37f50b
+++ b/tools/qemu-xen/hw/scsi/megasas.c
f37f50b
@@ -1446,7 +1446,7 @@ static int megasas_dcmd_set_properties(MegasasState *s, MegasasCmd *cmd)
f37f50b
                                             dcmd_size);
f37f50b
         return MFI_STAT_INVALID_PARAMETER;
f37f50b
     }
f37f50b
-    dma_buf_write((uint8_t *)&info, cmd->iov_size, &cmd->qsg);
f37f50b
+    dma_buf_write((uint8_t *)&info, dcmd_size, &cmd->qsg);
f37f50b
     trace_megasas_dcmd_unsupported(cmd->index, cmd->iov_size);
f37f50b
     return MFI_STAT_OK;
f37f50b
 }
f37f50b
-- 
f37f50b
2.5.5
f37f50b