#3 Don't build-require files outside of permitted directories
Closed 3 months ago by myoung. Opened 4 months ago by jkolarik.
rpms/ jkolarik/xen rawhide  into  rawhide

file modified
+3 -2
@@ -128,8 +128,9 @@ 

  BuildRequires: python3-devel ncurses-devel python3-setuptools

  BuildRequires: perl-interpreter perl-generators

  %ifarch %{ix86} x86_64

- # so that x86_64 builds pick up glibc32 correctly

- BuildRequires: /usr/include/gnu/stubs-32.h

+ # Koji 64-bit buildroots do not contain packages from 32-bit builds, therefore

+ # the 'glibc-devel.i686' variant is provided as 'glibc32'.

+ BuildRequires: (glibc32 or glibc-devel(%__isa_name-32))

  %endif

  BuildRequires: gettext

  BuildRequires: gnutls-devel

Pick the right glibc-devel package instead of depending on a file require.

Packaging guidelines only allow dependencies on files in /usr/bin, /usr/sbin and /etc.

Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies

Relates: https://fedoraproject.org/wiki/Changes/BuildWithDNF5

Relates: https://fedoraproject.org/wiki/Changes/ReplaceDnfWithDnf5

The proposed code change doesn't actually work.

Pull-Request has been closed by myoung

3 months ago

My previous comment was wrong - I had a typo in one of my tests. However the glibc32 line doesn't seem to any anything to the build so I am going to drop it.

Metadata