------------------------------------------------------------------------ *From*: P J P *Subject*: [Qemu-devel] [PATCH 1/3] scsi: megasas: use appropriate property buffer size *Date*: Wed, 25 May 2016 16:01:29 +0530 ------------------------------------------------------------------------ From: Prasad J Pandit When setting MegaRAID SAS controller properties via MegaRAID Firmware Interface(MFI) commands, a user supplied size parameter is used to set property value. Use appropriate size value to avoid OOB access issues. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/qemu-xen/hw/scsi/megasas.c b/tools/qemu-xen/hw/scsi/megasas.c index a63a581..dcbd3e1 100644 --- a/tools/qemu-xen/hw/scsi/megasas.c +++ b/tools/qemu-xen/hw/scsi/megasas.c @@ -1446,7 +1446,7 @@ static int megasas_dcmd_set_properties(MegasasState *s, MegasasCmd *cmd) dcmd_size); return MFI_STAT_INVALID_PARAMETER; } - dma_buf_write((uint8_t *)&info, cmd->iov_size, &cmd->qsg); + dma_buf_write((uint8_t *)&info, dcmd_size, &cmd->qsg); trace_megasas_dcmd_unsupported(cmd->index, cmd->iov_size); return MFI_STAT_OK; } -- 2.5.5