From 4c65fed8bdf96780735dbdb92a8bd0d6b6526cc3 Mon Sep 17 00:00:00 2001 From: Prasad J Pandit Date: Thu, 3 Dec 2015 18:54:17 +0530 Subject: [PATCH] ui: vnc: avoid floating point exception While sending 'SetPixelFormat' messages to a VNC server, the client could set the 'red-max', 'green-max' and 'blue-max' values to be zero. This leads to a floating point exception in write_png_palette while doing frame buffer updates. Reported-by: Lian Yihan Signed-off-by: Prasad J Pandit Reviewed-by: Gerd Hoffmann Signed-off-by: Peter Maydell --- tools/qemu-xen-traditional/vnc.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/qemu-xen-traditional/vnc.c b/tools/qemu-xen-traditional/vnc.c index 7538405..cbe4d33 100644 --- a/tools/qemu-xen-traditional/vnc.c +++ b/tools/qemu-xen-traditional/vnc.c @@ -2198,15 +2198,15 @@ static void set_pixel_format(VncState *vs, } vs->clientds = vs->serverds; - vs->clientds.pf.rmax = red_max; + vs->clientds.pf.rmax = red_max ? red_max : 0xFF; count_bits(vs->clientds.pf.rbits, red_max); vs->clientds.pf.rshift = red_shift; vs->clientds.pf.rmask = red_max << red_shift; - vs->clientds.pf.gmax = green_max; + vs->clientds.pf.gmax = green_max ? green_max : 0xFF; count_bits(vs->clientds.pf.gbits, green_max); vs->clientds.pf.gshift = green_shift; vs->clientds.pf.gmask = green_max << green_shift; - vs->clientds.pf.bmax = blue_max; + vs->clientds.pf.bmax = blue_max ? blue_max : 0xFF; count_bits(vs->clientds.pf.bbits, blue_max); vs->clientds.pf.bshift = blue_shift; vs->clientds.pf.bmask = blue_max << blue_shift; -- 1.7.0.4