PR#125: created fmf metadata for library(selinux-policy/common) - tests/selinux

tests / selinux

#125 created fmf metadata for library(selinux-policy/common)

Closed 3 years ago by sopos. Opened 3 years ago by sopos.

Unknown source master into master

created fmf metadata for library(selinux-policy/common)

Dalibor Pospisil • 3 years ago

7c94aca

selinux-policy/Library/common/main.fmf

file added

+32

		`@@ -0,0 +1,32 @@`
		`+ summary: Common library for SELinux`
		`+ contact: Milos Malik <mmalik@redhat.com>`
		`+ component:`
		`+ - selinux-policy`
		`+ test: ./runtest.sh`
		`+ framework: beakerlib`
		`+ require:`
		`+ - library(distribution/epel)`
		`+ recommend:`
		`+ - setools`
		`+ - setools-console`
		`+ - expect`
		`+ - policycoreutils`
		`+ - /usr/sbin/semanage`
		`+ - selinux-policy-devel`
		`+ - yum-utils`
		`+ - python3`
		`+ - sqlite`
		`+ duration: 120m`
		`+ enabled: true`
		`+ tag:`
		`+ - TIPpass`
		`+ - TIPpass_Security`
		`+ - TierCandidatesPASS`
		`+ - f32friendly`
		`+ - f33friendly`
		`+ - targeted`
		`+ relevancy: \|`
		`+ distro = rhel-4: False`
		`+ extra-nitrate: TC#0202952`
		`+ extra-summary: '[rlSE] SELinux Beaker Extension (selinux-policy/common)'`
		`+ extra-task: /CoreOS/selinux-policy/Library/common`

selinux-policy/Library/common/runtest.sh

file modified

-1

		`@@ -3,7 +3,6 @@`
		`# This is a test file`

		`# Include rhts environment`
		`- . /usr/bin/rhts-environment.sh`
		`. /usr/share/beakerlib/beakerlib.sh`

		`list_booleans() {`

sopos commented 3 years ago

also removed a deprecated rhts-environment sourcing

rebased onto 7c94aca

3 years ago

plautrba commented 3 years ago

I'd appreciate an example what's the new main.fmf good for and how to use it.

It recommends setools and setools-console. Given that setools should install all other setools-** packages, you can either drop one or another.

Please split removing of rhts-environment sourcing to its own commit with more information why it's not needed anymore.

I guess it;s somehow related to Makefile but it also uses AVC_ERROR=+no_avc_check which is not propagated to main.fmf. Is it expected?

Thanks!

sopos commented 3 years ago

All the changes are done using tmt tests import It basically reflects the Makefile. I'm not sure if/how tmt handles AVC_ERROR=+no_avc_check.

sopos commented 3 years ago

I found out that you define the fmf structure with test defined in the root which make it a bit difficult to properly handle library metadata. Thus I'm closing this PR till the adequate solution is ready [1].