#5 libselinux/selinux_restorecon-functions: remove checks that expect segfault
Closed 6 years ago by plautrba. Opened 6 years ago by janzarsky.
https://github.com/janzarsky/selinux-tests.git jzarsky-restorecon  into  master

libselinux/selinux_restorecon-functions: remove checks that expect segfault
Jan Zarsky • 6 years ago  
libselinux/selinux_restorecon-functions/runtest.sh
file modified
-30
@@ -103,10 +103,6 @@

      rlPhaseStartTest "invalid path"

          rlRun "./test_restorecon EMPTY" 255 "Calling selinux_restorecon with empty path"

  

-         # should probably return both 139 (segfault) or 255, but it is not so important

-         rlRun "./test_restorecon NULL" 139,255 "Calling selinux_restorecon with null as path"

-         rlRun "./test_restorecon NULL REALPATH" 139,255 "Calling selinux_restorecon with null as path and REALPATH flag"

-         

          rlRun "./test_restorecon /nonexistent" 255 "Calling selinux_restorecon with nonexisting path"

      rlPhaseEnd

  
@@ -281,26 +277,6 @@

          rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out"

          rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out"

  

-         ### selinux_restorecon_set_exclude_list expects

-         ### "a pointer containing a NULL terminated list of one or more directories"

-         ### therefore this test doesn't make sense now

-         ### # null as list

-         ### if rlIsFedora ">=26"; then

-         ###     rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 139 "Calling selinux_restorecon_set_exclude_list with null as list"

-         ### else

-         ###     rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list with null as list"

-         ### 

-         ###     rlLogInfo "Checking lgetxattr calls"

-         ###     rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"

-         ### 

-         ###     rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"

-         ###     rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"

-         ###     rlRun "grep \"\\\"$TmpDir/afile\\\"\"       strace_xattr.out"

-         ###     rlRun "grep \"\\\"$TmpDir/a/b\\\"\"         strace_xattr.out"

-         ###     rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out"

-         ###     rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out"

-         ### fi

- 

          # exclude $TmpDir/a

          rlRun "strace -ostrace.out -s 64 ./test_exclude_list $TmpDir/a $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list"

  
@@ -323,12 +299,6 @@

      rlPhaseStartTest "selinux_restorecon_set_sehandle"

          createTestFiles

  

-         # null sehandle

-         rlRun "./test_sehandle NULL $TmpDir" 139,255 "Calling selinux_restorecon_set_sehandle with null handle"

- 

-         # invalid sehandle

-         rlRun "./test_sehandle INVALID $TmpDir" 139,255 "Calling selinux_restorecon_set_sehandle with invalid handle"

- 

          # default sehandle

          rlRun "strace -ostrace.out -s 64 ./test_sehandle DEFAULT $TmpDir" 0 "Calling selinux_restorecon_set_sehandle with default handle"

  

no initial comment

Several checks are unnecessary, because they test undefined behaviour which often changes.

Pull-Request has been closed by plautrba

6 years ago
Metadata