#71 policycoreutils/org-selinux-dbus-interfaces: Add missing requirements
Merged 4 years ago by plautrba. Opened 4 years ago by rfilo.
tests/ rfilo/selinux dbus-tools  into  master

@@ -53,7 +53,7 @@ 

  	@echo "Type:            Sanity" >> $(METADATA)

  	@echo "TestTime:        10m" >> $(METADATA)

  	@echo "RunFor:          policycoreutils" >> $(METADATA)

- 	@echo "Requires:        policycoreutils-dbus selinux-policy-minimum selinux-policy-mls selinux-policy-targeted" >> $(METADATA)

+ 	@echo "Requires:        dbus-tools policycoreutils-dbus selinux-policy-minimum selinux-policy-mls selinux-policy-targeted" >> $(METADATA)

  	@echo "Priority:        Normal" >> $(METADATA)

  	@echo "License:         GPLv2" >> $(METADATA)

  	@echo "Confidential:    no" >> $(METADATA)

Fedora CI fails because dbus-tools package is required.

fixes: https://src.fedoraproject.org/tests/selinux/issue/66

The test still fails - https://src.fedoraproject.org/rpms/setools/pull-request/16 :100:

:: [ 12:49:35 ] :: [  BEGIN   ] :: Running 'gdbus introspect --system -d org.selinux -o /'
Error: Timeout was reached
:: [ 12:49:38 ] :: [   FAIL   ] :: Command 'gdbus introspect --system -d org.selinux -o /' (Expected 0, got 1)
:: [ 12:49:38 ] :: [  BEGIN   ] :: Running 'gdbus introspect --system -d org.selinux -o /org'
Error: Timeout was reached
:: [ 12:49:41 ] :: [   FAIL   ] :: Command 'gdbus introspect --system -d org.selinux -o /org' (Expected 0, got 1)
:: [ 12:49:42 ] :: [  BEGIN   ] :: Running 'gdbus introspect --system -d org.selinux -o /org/selinux'
Error: Timeout was reached
:: [ 12:49:45 ] :: [   FAIL   ] :: Command 'gdbus introspect --system -d org.selinux -o /org/selinux' (Expected 0, got 1)
:: [ 12:49:45 ] :: [  BEGIN   ] :: Running 'gdbus introspect --system -d org.selinux -o /org/selinux/object'
Error: Timeout was reached
:: [ 12:49:48 ] :: [   FAIL   ] :: Command 'gdbus introspect --system -d org.selinux -o /org/selinux/object' (Expected 0, got 1)
:: [ 12:49:48 ] :: [  BEGIN   ] :: Running 'ps -efZ | grep -v grep | grep ':semanage_t:.*selinux_server''
:: [ 12:49:48 ] :: [   FAIL   ] :: Command 'ps -efZ | grep -v grep | grep ':semanage_t:.*selinux_server'' (Expected 0, got 1)
: [ 12:49:48 ] :: [  BEGIN   ] :: Running 'dbus-send --system --print-reply --dest=org.selinux /org/selinux/object org.selinux.semodule_list'
Error org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
:: [ 12:50:13 ] :: [   FAIL   ] :: Command 'dbus-send --system --print-reply --dest=org.selinux /org/selinux/object org.selinux.semodule_list' (Expected 0, got 1)
:: [ 12:50:13 ] :: [  BEGIN   ] :: Running 'dbus-send --system --print-reply --dest=org.selinux /org/selinux/object org.selinux.semodule_list int64:0'
Error org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
:: [ 12:50:38 ] :: [   PASS   ] :: Command 'dbus-send --system --print-reply --dest=org.selinux /org/selinux/object org.selinux.semodule_list int64:0' (Expected 1, got 1)

The problem seems to be in missing requirements in policycoreutils-dbus:

May 20 13:33:12 fedora32 selinux_server.py[23731]: Traceback (most recent call last):
May 20 13:33:12 fedora32 selinux_server.py[23731]:   File "/usr/share/system-config-selinux/selinux_server.py", line 6, in <module>
May 20 13:33:12 fedora32 selinux_server.py[23731]:     from gi.repository import GObject
May 20 13:33:12 fedora32 selinux_server.py[23731]: ModuleNotFoundError: No module named 'gi'

Reproducer:

  1. use Fedora cloud image
# dnf install policycoreutils-dbus

# gdbus introspect --system -d org.selinux -o /
Error: Timeout was reached

# dnf remove policycoreutils-dbus

# dnf install python3-gobject-base policycoreutils-dbus

# gdbus introspect --system -d org.selinux -o /
node / {
  node org {
  };
};

I'm merging this PR and will fix policycoreutils package. Thanks!

Pull-Request has been merged by plautrba

4 years ago
Metadata