Blob Blame History Raw
commit 85afc2b5cc7e68c8184ae4ca7df4e1d7ed1d5258
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Oct 23 12:08:50 2008 +0100

    bugfix: don't reuse a variable to check for installed, else we fail the resolve in pkcon

diff --git a/client/pk-console.c b/client/pk-console.c
index 78ff544..8a0af52 100644
--- a/client/pk-console.c
+++ b/client/pk-console.c
@@ -553,6 +553,7 @@ static gboolean
 pk_console_install_stuff (PkClient *client, gchar **packages, GError **error)
 {
 	gboolean ret = TRUE;
+	gboolean installed;
 	gboolean is_local;
 	gchar *package_id = NULL;
 	gchar **package_ids = NULL;
@@ -573,8 +574,8 @@ pk_console_install_stuff (PkClient *client, gchar **packages, GError **error)
 			g_ptr_array_add (array_files, g_strdup (packages[i]));
 		} else {
 			/* if already installed, then abort */
-			ret = pk_console_is_installed (packages[i]);
-			if (ret) {
+			installed = pk_console_is_installed (packages[i]);
+			if (installed) {
 				/* TRANSLATORS: The package is already installed on the system */
 				*error = g_error_new (1, 0, _("The package '%s' is already installed"), packages[i]);
 				ret = FALSE;