0f3de09
@@ -63,7 +63,6 @@
%if %{with gpm}
BuildRequires: gpm-devel
%endif
- BuildRequires: liblockfile-devel
BuildRequires: libxml2-devel
BuildRequires: autoconf
BuildRequires: bzip2
The liblockfile dependency is unnecessary since emacs is compiled with -DMAIL_USE_LOCKF [1], which disables [2] the only include of <maillock.h>, a header file exposed by liblockfile.
[1] https://src.fedoraproject.org/rpms/emacs/blob/f40/f/emacs.spec#_256 [2] https://git.savannah.gnu.org/cgit/emacs.git/tree/lib-src/movemail.c?h=emacs-29.3#n113
Has the other option been considered, to not define MAIL_USE_LOCKF so that liblockfile is used?
MAIL_USE_LOCKF
liblockfile
That would change the mailbox locking strategy of movemail from using lockf/fcntl to using .lock files. TBH, I'm a bit confused about all the locking strategies, but I suppose there is a reason why the cflag was introduced.
movemail
lockf/fcntl
.lock
procmail, for instance, uses both dotlocking and lockf/fcntl in Fedora:
procmail
$ procmail -v 2>&1 | grep Locking Locking strategies: dotlocking, fcntl()
mutt only uses lockf/fcntl:
mutt
$ mutt -v | grep -i lock -HOMESPOOL +USE_SETGID -USE_DOTLOCK +DL_STANDALONE +USE_FCNTL -USE_FLOCK
It's also worth noting that liblockfile looks dead upstream.
It looks like liblockfile wasn't working for a long time, before anyone noticed: https://src.fedoraproject.org/rpms/emacs/pull-request/40
Thanks for the pull request.
Pull-Request has been merged by mavit
pzacik
commented 2 months ago
The liblockfile dependency is unnecessary since emacs is compiled with -DMAIL_USE_LOCKF [1], which disables [2] the only include of <maillock.h>, a header file exposed by liblockfile.
[1] https://src.fedoraproject.org/rpms/emacs/blob/f40/f/emacs.spec#_256
[2] https://git.savannah.gnu.org/cgit/emacs.git/tree/lib-src/movemail.c?h=emacs-29.3#n113