Blob Blame History Raw
From: Peter Lemenkov <lemenkov@gmail.com>
Date: Thu, 6 Sep 2018 15:00:00 +0300
Subject: [PATCH] Remove excessive export_all directive

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>

diff --git a/rebar.config b/rebar.config
index fcaf4fa..9542f1b 100644
--- a/rebar.config
+++ b/rebar.config
@@ -13,7 +13,6 @@
 ]}.
 
 {deps, [
-    {riak_pb, "2\.3\.[0-9]+", {git, "https://github.com/basho/riak_pb", {tag, "2.3.2"}}}
 ]}.
 
 {edoc_opts, [
diff --git a/test/riakc_pb_socket_tests.erl b/test/riakc_pb_socket_tests.erl
index 7debc8d..21c9acf 100644
--- a/test/riakc_pb_socket_tests.erl
+++ b/test/riakc_pb_socket_tests.erl
@@ -19,12 +19,8 @@
 %% under the License.
 %%
 %% -------------------------------------------------------------------
--ifdef(TEST).
-
 -module(riakc_pb_socket_tests).
 
--compile(export_all).
-
 -include("riakc.hrl").
 
 -include_lib("riak_pb/include/riak_pb_kv_codec.hrl").
@@ -1465,4 +1461,3 @@ integration_test_() ->
                  end
              end,
     {setup, SetupFun, CleanupFun, {generator, GenFun}}.
--endif.
diff --git a/test/riakc_test_utils.erl b/test/riakc_test_utils.erl
index a356a6e..d05df1e 100644
--- a/test/riakc_test_utils.erl
+++ b/test/riakc_test_utils.erl
@@ -19,11 +19,9 @@
 %% under the License.
 %%
 %% -------------------------------------------------------------------
--ifdef(TEST).
-
 -module(riakc_test_utils).
 
--compile(export_all).
+-compile([export_all, nowarn_export_all]).
 
 -include_lib("eunit/include/eunit.hrl").
 
@@ -242,5 +240,3 @@ maybe_start_network() ->
         X ->
             X
     end.
-
--endif.
diff --git a/test/riakc_ts_tests.erl b/test/riakc_ts_tests.erl
index af8d875..ed790c1 100644
--- a/test/riakc_ts_tests.erl
+++ b/test/riakc_ts_tests.erl
@@ -19,12 +19,8 @@
 %% under the License.
 %%
 %% -------------------------------------------------------------------
--ifdef(TEST).
-
 -module(riakc_ts_tests).
 
--compile(export_all).
-
 -include("riakc.hrl").
 
 -include_lib("eunit/include/eunit.hrl").
@@ -96,4 +92,3 @@ integration_test_() ->
                  end
              end,
     {setup, SetupFun, CleanupFun, {generator, GenFun}}.
--endif.
diff --git a/test/riakc_utils_tests.erl b/test/riakc_utils_tests.erl
index b5d36ce..2898eb5 100644
--- a/test/riakc_utils_tests.erl
+++ b/test/riakc_utils_tests.erl
@@ -19,16 +19,10 @@
 %% under the License.
 %%
 %% -------------------------------------------------------------------
--ifdef(TEST).
-
 -module(riakc_utils_tests).
 
--compile(export_all).
-
 -include_lib("eunit/include/eunit.hrl").
 
 bad_unicode_binary_test() ->
     S = <<"\xa0\xa1">>,
     ?assertThrow({unicode_error, _Msg}, riakc_utils:characters_to_unicode_binary(S)).
-
--endif.